| Message ID | 20230904-cpufreq-h616-v1-2-b8842e525c43@somainline.org (mailing list archive) |
|---|---|
| State | New |
| Delegated to: | viresh kumar |
| Headers | show |
| Series | cpufreq for H616 | expand |
On Mon, 04 Sep 2023 17:57:02 +0200 Martin Botka <martin.botka@somainline.org> wrote: > The AllWinner H616 uses H6 cpufreq driver. > Add it to blocklist so its not created twice That looks alright, but I think needs to be squashed into the patch that enables the H616 driver operation, to avoid regressions during bisecting. Cheers, Andre > > Signed-off-by: Martin Botka <martin.botka@somainline.org> > --- > drivers/cpufreq/cpufreq-dt-platdev.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/cpufreq/cpufreq-dt-platdev.c b/drivers/cpufreq/cpufreq-dt-platdev.c > index e2b20080de3a..51818cef8979 100644 > --- a/drivers/cpufreq/cpufreq-dt-platdev.c > +++ b/drivers/cpufreq/cpufreq-dt-platdev.c > @@ -104,6 +104,7 @@ static const struct of_device_id allowlist[] __initconst = { > */ > static const struct of_device_id blocklist[] __initconst = { > { .compatible = "allwinner,sun50i-h6", }, > + { .compatible = "allwinner,sun50i-h616", }, > > { .compatible = "apple,arm-platform", }, > >
在 2023-09-04星期一的 21:40 +0100，Andre Przywara写道： > On Mon, 04 Sep 2023 17:57:02 +0200 > Martin Botka <martin.botka@somainline.org> wrote: > > > The AllWinner H616 uses H6 cpufreq driver. > > Add it to blocklist so its not created twice > > That looks alright, but I think needs to be squashed into the patch > that enables the H616 driver operation, to avoid regressions during > bisecting. Well I think if it's before the H616 enablement, it could be just okay. > > Cheers, > Andre > > > > > Signed-off-by: Martin Botka <martin.botka@somainline.org> > > --- > > drivers/cpufreq/cpufreq-dt-platdev.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/cpufreq/cpufreq-dt-platdev.c > > b/drivers/cpufreq/cpufreq-dt-platdev.c > > index e2b20080de3a..51818cef8979 100644 > > --- a/drivers/cpufreq/cpufreq-dt-platdev.c > > +++ b/drivers/cpufreq/cpufreq-dt-platdev.c > > @@ -104,6 +104,7 @@ static const struct of_device_id allowlist[] > > __initconst = { > > */ > > static const struct of_device_id blocklist[] __initconst = { > > { .compatible = "allwinner,sun50i-h6", }, > > + { .compatible = "allwinner,sun50i-h616", }, > > > > { .compatible = "apple,arm-platform", }, > > > > > >
On Mon, 04 Sep 2023 17:57:02 +0200 Martin Botka <martin.botka@somainline.org> wrote: > The AllWinner H616 uses H6 cpufreq driver. > Add it to blocklist so its not created twice > > Signed-off-by: Martin Botka <martin.botka@somainline.org> > --- > drivers/cpufreq/cpufreq-dt-platdev.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/cpufreq/cpufreq-dt-platdev.c b/drivers/cpufreq/cpufreq-dt-platdev.c > index e2b20080de3a..51818cef8979 100644 > --- a/drivers/cpufreq/cpufreq-dt-platdev.c > +++ b/drivers/cpufreq/cpufreq-dt-platdev.c > @@ -104,6 +104,7 @@ static const struct of_device_id allowlist[] __initconst = { > */ > static const struct of_device_id blocklist[] __initconst = { > { .compatible = "allwinner,sun50i-h6", }, > + { .compatible = "allwinner,sun50i-h616", }, The OrangePi Zero3 DT uses the "allwinner,sun50i-h618" compatible string. Definitely for the purpose of this patch the SoCs are the same, so just add another line with that name, please. Cheers, Andre > > { .compatible = "apple,arm-platform", }, > >
diff --git a/drivers/cpufreq/cpufreq-dt-platdev.c b/drivers/cpufreq/cpufreq-dt-platdev.c index e2b20080de3a..51818cef8979 100644 --- a/drivers/cpufreq/cpufreq-dt-platdev.c +++ b/drivers/cpufreq/cpufreq-dt-platdev.c @@ -104,6 +104,7 @@ static const struct of_device_id allowlist[] __initconst = { */ static const struct of_device_id blocklist[] __initconst = { { .compatible = "allwinner,sun50i-h6", }, + { .compatible = "allwinner,sun50i-h616", }, { .compatible = "apple,arm-platform", },
The AllWinner H616 uses H6 cpufreq driver. Add it to blocklist so its not created twice Signed-off-by: Martin Botka <martin.botka@somainline.org> --- drivers/cpufreq/cpufreq-dt-platdev.c | 1 + 1 file changed, 1 insertion(+)