| Message ID | 20230914111904.586744-1-ulf.hansson@linaro.org (mailing list archive) |
|---|---|
| State | Handled Elsewhere, archived |
| Headers | show |
| Series | pmdomain: Move Kconfig options/files to the pmdomain subsystem | expand |
Hey, On Thu, Sep 14, 2023 at 01:19:04PM +0200, Ulf Hansson wrote: > The Kconfig belongs closer to the corresponding implementation, hence let's > move it from the soc subsystem to the pmdomain subsystem. > > Cc: Walker Chen <walker.chen@starfivetech.com> > Cc: Conor Dooley <conor@kernel.org> > Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org> Thanks for doing this, saved me having to! The series appears to have broken threading though, which can be seen pretty easily on lore: https://lore.kernel.org/all/20230914111904.586744-1-ulf.hansson@linaro.org/ Dunno if something is borked with your process while sending patches to only a subset of the total recipient list. > --- > MAINTAINERS | 2 +- > drivers/pmdomain/Kconfig | 1 + > drivers/{soc => pmdomain}/starfive/Kconfig | 0 > drivers/soc/Kconfig | 1 - > 4 files changed, 2 insertions(+), 2 deletions(-) > rename drivers/{soc => pmdomain}/starfive/Kconfig (100%) > > diff --git a/MAINTAINERS b/MAINTAINERS > index 6b491ebcf790..b8eae18f0fb1 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -20523,7 +20523,7 @@ M: Conor Dooley <conor@kernel.org> > S: Maintained > T: git https://git.kernel.org/pub/scm/linux/kernel/git/conor/linux.git/ > F: Documentation/devicetree/bindings/soc/starfive/ > -F: drivers/soc/starfive/ > +F: drivers/pmdomain/starfive/ This isn't the correct change, just remove the drivers/soc/starfive bit entirely from this entry. I've just been doing some review & sending PRs to Arnd for this stuff (or failing to send the PRs as you saw), I don't have particular interest in this driver other than helping out the starfive people with actually getting the code merged. Instead I think you should generalise the existing entry for the driver to cover the whole directory, so that it includes the Kconfig bits too: diff --git a/MAINTAINERS b/MAINTAINERS index fa7487b7729b..22c1a5e5b130 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -20564,7 +20564,7 @@ M: Walker Chen <walker.chen@starfivetech.com> M: Changhuang Liang <changhuang.liang@starfivetech.com> S: Supported F: Documentation/devicetree/bindings/power/starfive* -F: drivers/pmdomain/starfive/jh71xx-pmu.c +F: drivers/pmdomain/starfive/ F: include/dt-bindings/power/starfive,jh7110-pmu.h STARFIVE SOC DRIVERS Thanks, Conor. > > STARFIVE TRNG DRIVER > M: Jia Jie Ho <jiajie.ho@starfivetech.com> > diff --git a/drivers/pmdomain/Kconfig b/drivers/pmdomain/Kconfig > index cfe9ea754062..67049ebf7265 100644 > --- a/drivers/pmdomain/Kconfig > +++ b/drivers/pmdomain/Kconfig > @@ -12,5 +12,6 @@ source "drivers/pmdomain/renesas/Kconfig" > source "drivers/pmdomain/rockchip/Kconfig" > source "drivers/pmdomain/samsung/Kconfig" > source "drivers/pmdomain/st/Kconfig" > +source "drivers/pmdomain/starfive/Kconfig" > > endmenu > diff --git a/drivers/soc/starfive/Kconfig b/drivers/pmdomain/starfive/Kconfig > similarity index 100% > rename from drivers/soc/starfive/Kconfig > rename to drivers/pmdomain/starfive/Kconfig > diff --git a/drivers/soc/Kconfig b/drivers/soc/Kconfig > index 8b46da40f107..10a9ff84ff41 100644 > --- a/drivers/soc/Kconfig > +++ b/drivers/soc/Kconfig > @@ -23,7 +23,6 @@ source "drivers/soc/renesas/Kconfig" > source "drivers/soc/rockchip/Kconfig" > source "drivers/soc/samsung/Kconfig" > source "drivers/soc/sifive/Kconfig" > -source "drivers/soc/starfive/Kconfig" > source "drivers/soc/sunxi/Kconfig" > source "drivers/soc/tegra/Kconfig" > source "drivers/soc/ti/Kconfig" > -- > 2.34.1 >
On 2023/9/14 19:59, Conor Dooley wrote: > Hey, > > > On Thu, Sep 14, 2023 at 01:19:04PM +0200, Ulf Hansson wrote: >> The Kconfig belongs closer to the corresponding implementation, hence let's >> move it from the soc subsystem to the pmdomain subsystem. >> >> Cc: Walker Chen <walker.chen@starfivetech.com> >> Cc: Conor Dooley <conor@kernel.org> >> Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org> > > Thanks for doing this, saved me having to! > The series appears to have broken threading though, which can be seen > pretty easily on lore: > https://lore.kernel.org/all/20230914111904.586744-1-ulf.hansson@linaro.org/ > Dunno if something is borked with your process while sending patches to > only a subset of the total recipient list. > >> --- >> MAINTAINERS | 2 +- >> drivers/pmdomain/Kconfig | 1 + >> drivers/{soc => pmdomain}/starfive/Kconfig | 0 >> drivers/soc/Kconfig | 1 - >> 4 files changed, 2 insertions(+), 2 deletions(-) >> rename drivers/{soc => pmdomain}/starfive/Kconfig (100%) >> >> diff --git a/MAINTAINERS b/MAINTAINERS >> index 6b491ebcf790..b8eae18f0fb1 100644 >> --- a/MAINTAINERS >> +++ b/MAINTAINERS >> @@ -20523,7 +20523,7 @@ M: Conor Dooley <conor@kernel.org> >> S: Maintained >> T: git https://git.kernel.org/pub/scm/linux/kernel/git/conor/linux.git/ >> F: Documentation/devicetree/bindings/soc/starfive/ >> -F: drivers/soc/starfive/ >> +F: drivers/pmdomain/starfive/ > > This isn't the correct change, just remove the drivers/soc/starfive > bit entirely from this entry. > I've just been doing some review & sending PRs to Arnd for this stuff > (or failing to send the PRs as you saw), I don't have particular > interest in this driver other than helping out the starfive people with > actually getting the code merged. > Instead I think you should generalise the existing entry for the driver > to cover the whole directory, so that it includes the Kconfig bits too: > > diff --git a/MAINTAINERS b/MAINTAINERS > index fa7487b7729b..22c1a5e5b130 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -20564,7 +20564,7 @@ M: Walker Chen <walker.chen@starfivetech.com> > M: Changhuang Liang <changhuang.liang@starfivetech.com> > S: Supported > F: Documentation/devicetree/bindings/power/starfive* > -F: drivers/pmdomain/starfive/jh71xx-pmu.c > +F: drivers/pmdomain/starfive/ > F: include/dt-bindings/power/starfive,jh7110-pmu.h > > STARFIVE SOC DRIVERS > Hi Conor, Anyway, thank you for helping maintain this driver as starfive people lack of experience in this area. You have indeed helped us a lot during this period. Best regards, Walker > Thanks, > Conor. > >> >> STARFIVE TRNG DRIVER >> M: Jia Jie Ho <jiajie.ho@starfivetech.com> >> diff --git a/drivers/pmdomain/Kconfig b/drivers/pmdomain/Kconfig >> index cfe9ea754062..67049ebf7265 100644 >> --- a/drivers/pmdomain/Kconfig >> +++ b/drivers/pmdomain/Kconfig >> @@ -12,5 +12,6 @@ source "drivers/pmdomain/renesas/Kconfig" >> source "drivers/pmdomain/rockchip/Kconfig" >> source "drivers/pmdomain/samsung/Kconfig" >> source "drivers/pmdomain/st/Kconfig" >> +source "drivers/pmdomain/starfive/Kconfig" >> >> endmenu >> diff --git a/drivers/soc/starfive/Kconfig b/drivers/pmdomain/starfive/Kconfig >> similarity index 100% >> rename from drivers/soc/starfive/Kconfig >> rename to drivers/pmdomain/starfive/Kconfig >> diff --git a/drivers/soc/Kconfig b/drivers/soc/Kconfig >> index 8b46da40f107..10a9ff84ff41 100644 >> --- a/drivers/soc/Kconfig >> +++ b/drivers/soc/Kconfig >> @@ -23,7 +23,6 @@ source "drivers/soc/renesas/Kconfig" >> source "drivers/soc/rockchip/Kconfig" >> source "drivers/soc/samsung/Kconfig" >> source "drivers/soc/sifive/Kconfig" >> -source "drivers/soc/starfive/Kconfig" >> source "drivers/soc/sunxi/Kconfig" >> source "drivers/soc/tegra/Kconfig" >> source "drivers/soc/ti/Kconfig" >> -- >> 2.34.1 >>
On Thu, 14 Sept 2023 at 14:00, Conor Dooley <conor.dooley@microchip.com> wrote: > > Hey, > > > On Thu, Sep 14, 2023 at 01:19:04PM +0200, Ulf Hansson wrote: > > The Kconfig belongs closer to the corresponding implementation, hence let's > > move it from the soc subsystem to the pmdomain subsystem. > > > > Cc: Walker Chen <walker.chen@starfivetech.com> > > Cc: Conor Dooley <conor@kernel.org> > > Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org> > > Thanks for doing this, saved me having to! > The series appears to have broken threading though, which can be seen > pretty easily on lore: > https://lore.kernel.org/all/20230914111904.586744-1-ulf.hansson@linaro.org/ > Dunno if something is borked with your process while sending patches to > only a subset of the total recipient list. Yes, I screwed up when sending. Anyway, it looks like it works for people to review it anyway. > > > --- > > MAINTAINERS | 2 +- > > drivers/pmdomain/Kconfig | 1 + > > drivers/{soc => pmdomain}/starfive/Kconfig | 0 > > drivers/soc/Kconfig | 1 - > > 4 files changed, 2 insertions(+), 2 deletions(-) > > rename drivers/{soc => pmdomain}/starfive/Kconfig (100%) > > > > diff --git a/MAINTAINERS b/MAINTAINERS > > index 6b491ebcf790..b8eae18f0fb1 100644 > > --- a/MAINTAINERS > > +++ b/MAINTAINERS > > @@ -20523,7 +20523,7 @@ M: Conor Dooley <conor@kernel.org> > > S: Maintained > > T: git https://git.kernel.org/pub/scm/linux/kernel/git/conor/linux.git/ > > F: Documentation/devicetree/bindings/soc/starfive/ > > -F: drivers/soc/starfive/ > > +F: drivers/pmdomain/starfive/ > > This isn't the correct change, just remove the drivers/soc/starfive > bit entirely from this entry. > I've just been doing some review & sending PRs to Arnd for this stuff > (or failing to send the PRs as you saw), I don't have particular > interest in this driver other than helping out the starfive people with > actually getting the code merged. > Instead I think you should generalise the existing entry for the driver > to cover the whole directory, so that it includes the Kconfig bits too: > > diff --git a/MAINTAINERS b/MAINTAINERS > index fa7487b7729b..22c1a5e5b130 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -20564,7 +20564,7 @@ M: Walker Chen <walker.chen@starfivetech.com> > M: Changhuang Liang <changhuang.liang@starfivetech.com> > S: Supported > F: Documentation/devicetree/bindings/power/starfive* > -F: drivers/pmdomain/starfive/jh71xx-pmu.c > +F: drivers/pmdomain/starfive/ > F: include/dt-bindings/power/starfive,jh7110-pmu.h Thanks for clarifying this. I will update (either amending when applying or when re-submitting). > > STARFIVE SOC DRIVERS > > Thanks, > Conor. I guess I consider this as an ack, assuming the above gets changed? [...] Kind regards Uffe
On Fri, Sep 15, 2023 at 12:24:55AM +0200, Ulf Hansson wrote: > On Thu, 14 Sept 2023 at 14:00, Conor Dooley <conor.dooley@microchip.com> wrote: > > I guess I consider this as an ack, assuming the above gets changed? Here's an explicit for w/ that change: Acked-by: Conor Dooley <conor.dooley@microchip.com> Thanks, Conor.
diff --git a/MAINTAINERS b/MAINTAINERS index 6b491ebcf790..b8eae18f0fb1 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -20523,7 +20523,7 @@ M: Conor Dooley <conor@kernel.org> S: Maintained T: git https://git.kernel.org/pub/scm/linux/kernel/git/conor/linux.git/ F: Documentation/devicetree/bindings/soc/starfive/ -F: drivers/soc/starfive/ +F: drivers/pmdomain/starfive/ STARFIVE TRNG DRIVER M: Jia Jie Ho <jiajie.ho@starfivetech.com> diff --git a/drivers/pmdomain/Kconfig b/drivers/pmdomain/Kconfig index cfe9ea754062..67049ebf7265 100644 --- a/drivers/pmdomain/Kconfig +++ b/drivers/pmdomain/Kconfig @@ -12,5 +12,6 @@ source "drivers/pmdomain/renesas/Kconfig" source "drivers/pmdomain/rockchip/Kconfig" source "drivers/pmdomain/samsung/Kconfig" source "drivers/pmdomain/st/Kconfig" +source "drivers/pmdomain/starfive/Kconfig" endmenu diff --git a/drivers/soc/starfive/Kconfig b/drivers/pmdomain/starfive/Kconfig similarity index 100% rename from drivers/soc/starfive/Kconfig rename to drivers/pmdomain/starfive/Kconfig diff --git a/drivers/soc/Kconfig b/drivers/soc/Kconfig index 8b46da40f107..10a9ff84ff41 100644 --- a/drivers/soc/Kconfig +++ b/drivers/soc/Kconfig @@ -23,7 +23,6 @@ source "drivers/soc/renesas/Kconfig" source "drivers/soc/rockchip/Kconfig" source "drivers/soc/samsung/Kconfig" source "drivers/soc/sifive/Kconfig" -source "drivers/soc/starfive/Kconfig" source "drivers/soc/sunxi/Kconfig" source "drivers/soc/tegra/Kconfig" source "drivers/soc/ti/Kconfig"
The Kconfig belongs closer to the corresponding implementation, hence let's move it from the soc subsystem to the pmdomain subsystem. Cc: Walker Chen <walker.chen@starfivetech.com> Cc: Conor Dooley <conor@kernel.org> Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org> --- MAINTAINERS | 2 +- drivers/pmdomain/Kconfig | 1 + drivers/{soc => pmdomain}/starfive/Kconfig | 0 drivers/soc/Kconfig | 1 - 4 files changed, 2 insertions(+), 2 deletions(-) rename drivers/{soc => pmdomain}/starfive/Kconfig (100%)