| Message ID | 20230921091057.3812-1-duminjie@vivo.com (mailing list archive) |
|---|---|
| State | New |
| Delegated to: | Daniel Lezcano |
| Headers | show |
| Series | [v1] thermal/drivers/mediatek/lvts_thermal: fix error check in lvts_debugfs_init() | expand |
Reviewed-by: Alexandre Mergnat <amergnat@baylibre.com> On 21/09/2023 11:10, Minjie Du wrote: > debugfs_create_dir() function returns an error value embedded in > the pointer (PTR_ERR). Evaluate the return value using IS_ERR > rather than checking for NULL.
On Thu, Sep 21, 2023 at 5:11 PM Minjie Du <duminjie@vivo.com> wrote: > > debugfs_create_dir() function returns an error value embedded in > the pointer (PTR_ERR). Evaluate the return value using IS_ERR > rather than checking for NULL. > > Signed-off-by: Minjie Du <duminjie@vivo.com> Reviewed-by: Chen-Yu Tsai <wenst@chromium.org>
On 21/09/2023 11:10, Minjie Du wrote: > debugfs_create_dir() function returns an error value embedded in > the pointer (PTR_ERR). Evaluate the return value using IS_ERR > rather than checking for NULL. > > Signed-off-by: Minjie Du <duminjie@vivo.com> > --- Applied, thanks
diff --git a/drivers/thermal/mediatek/lvts_thermal.c b/drivers/thermal/mediatek/lvts_thermal.c index effd9b00a424..88240600e6ce 100644 --- a/drivers/thermal/mediatek/lvts_thermal.c +++ b/drivers/thermal/mediatek/lvts_thermal.c @@ -213,7 +213,7 @@ static int lvts_debugfs_init(struct device *dev, struct lvts_domain *lvts_td) sprintf(name, "controller%d", i); dentry = debugfs_create_dir(name, lvts_td->dom_dentry); - if (!dentry) + if (IS_ERR(dentry)) continue; regset = devm_kzalloc(dev, sizeof(*regset), GFP_KERNEL);
debugfs_create_dir() function returns an error value embedded in the pointer (PTR_ERR). Evaluate the return value using IS_ERR rather than checking for NULL. Signed-off-by: Minjie Du <duminjie@vivo.com> --- drivers/thermal/mediatek/lvts_thermal.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)