From patchwork Tue Nov 7 16:31:36 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Christoph Niedermaier X-Patchwork-Id: 13449112 X-Patchwork-Delegate: viresh.linux@gmail.com Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 61807C4332F for ; Tue, 7 Nov 2023 16:42:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234598AbjKGQmm (ORCPT ); Tue, 7 Nov 2023 11:42:42 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43282 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229886AbjKGQml (ORCPT ); Tue, 7 Nov 2023 11:42:41 -0500 X-Greylist: delayed 432 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Tue, 07 Nov 2023 08:42:39 PST Received: from mx2.securetransport.de (mx2.securetransport.de [188.68.39.254]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 0FBB993 for ; Tue, 7 Nov 2023 08:42:38 -0800 (PST) Received: from mail.dh-electronics.com (unknown [77.24.89.57]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx2.securetransport.de (Postfix) with ESMTPSA id 8BF085E8E0; Tue, 7 Nov 2023 17:34:24 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dh-electronics.com; s=dhelectronicscom; t=1699374865; bh=/6rLoGMICSuiHaXxLKc1zcRf/OWuoJW4dmdquv6xRk4=; h=From:To:CC:Subject:Date:From; b=LD8dc0JJ1a40j0ROun3FsclkQle9pFlXJin4eADT7B+E48YA6mSPSVU3gKKgXB0dJ 0ykflkZc6+WnNU8wHCSuF/tuK3RL2gTLPHWc66h3kyZPzEcinGk1yFLk2WgW2t4Dlt D4rJhJcDA3U+EftfHS504rnrcVeYi/eZoyky8Du+x4KIsB1OhnSHHYSJj7bLmhqUXX 57Btwn7PsPhN9hNSLIx42zY+dPOJt+P56aVaSGWRL5KzY/mx3iLtQgP3tSmUpBWdYk gIzerZckpAx1dZnS0pwB5CXnGBoboyRfbBPgBoManNBiz/5Rx/IbFXHccAZEYSulXO 9MhweAkNDprkg== Received: from DHPWEX01.DH-ELECTRONICS.ORG (10.64.2.30) by DHPWEX01.DH-ELECTRONICS.ORG (10.64.2.30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1258.27; Tue, 7 Nov 2023 17:34:14 +0100 Received: from localhost.localdomain (172.16.51.3) by DHPWEX01.DH-ELECTRONICS.ORG (10.64.2.30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1258.27 via Frontend Transport; Tue, 7 Nov 2023 17:34:14 +0100 From: Christoph Niedermaier To: CC: Christoph Niedermaier , Viresh Kumar , "Rafael J. Wysocki" , =?utf-8?q?S=C3=A9bastien_Szymanski?= , Stefan Agner , Shawn Guo , Marek Vasut , Fabio Estevam , NXP Linux Team , , Subject: [PATCH] cpufreq: imx6q: Only disabling 792MHz OPP for i.MX6ULL types below 792MHz Date: Tue, 7 Nov 2023 17:31:36 +0100 Message-ID: <20231107163136.63440-1-cniedermaier@dh-electronics.com> X-Mailer: git-send-email 2.11.0 X-klartext: yes MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org For a 900MHz i.MX6ULL CPU the 792MHz OPP is disabled. There is no convincing reason to disable this OPP. If a CPU can run at 900MHz, it should also be able to cope with 792MHz. Looking at the voltage level of 792MHz in [1] (page 24, table 10. "Operating Ranges") the current defined OPP is above the minimum. So the voltage level shouldn't be a problem. Although in [2] (page 24, table 10. "Operating Ranges") 792MHz isn't mentioned there isn't note that 792MHz OPP isn't allowed. Change it to only disable 792MHz OPP for i.MX6ULL types below 792 MHz. [1] https://www.nxp.com/docs/en/data-sheet/IMX6ULLIEC.pdf [2] https://www.nxp.com/docs/en/data-sheet/IMX6ULLCEC.pdf Signed-off-by: Christoph Niedermaier Reviewed-by: Marek Vasut Reviewed-by: Fabio Estevam --- Cc: Viresh Kumar Cc: "Rafael J. Wysocki" Cc: Sébastien Szymanski Cc: Stefan Agner Cc: Shawn Guo Cc: Marek Vasut Cc: Fabio Estevam Cc: NXP Linux Team Cc: linux-pm@vger.kernel.org Cc: linux-kernel@vger.kernel.org To: linux-arm-kernel@lists.infradead.org --- drivers/cpufreq/imx6q-cpufreq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/cpufreq/imx6q-cpufreq.c b/drivers/cpufreq/imx6q-cpufreq.c index 494d044b9e72..33728c242f66 100644 --- a/drivers/cpufreq/imx6q-cpufreq.c +++ b/drivers/cpufreq/imx6q-cpufreq.c @@ -327,7 +327,7 @@ static int imx6ul_opp_check_speed_grading(struct device *dev) imx6x_disable_freq_in_opp(dev, 696000000); if (of_machine_is_compatible("fsl,imx6ull")) { - if (val != OCOTP_CFG3_6ULL_SPEED_792MHZ) + if (val < OCOTP_CFG3_6ULL_SPEED_792MHZ) imx6x_disable_freq_in_opp(dev, 792000000); if (val != OCOTP_CFG3_6ULL_SPEED_900MHZ)