From patchwork Fri Nov 24 08:06:33 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 13467145 Authentication-Results: smtp.subspace.kernel.org; dkim=none Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [IPv6:2a0a:edc0:2:b01:1d::104]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C91F61BD for ; Fri, 24 Nov 2023 00:10:45 -0800 (PST) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1r6RGq-0005Ot-H0; Fri, 24 Nov 2023 09:10:40 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1r6RGq-00BDan-1e; Fri, 24 Nov 2023 09:10:40 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1r6RGp-007Hi2-Ob; Fri, 24 Nov 2023 09:10:39 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Ulf Hansson , Michal Simek , Linus Walleij , Heiko Stuebner , Arnd Bergmann , "Rafael J. Wysocki" Cc: linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Pengutronix Kernel Team Subject: [PATCH 9/9] pmdomain: xilinx/zynqmp: Convert to platform remove callback returning void Date: Fri, 24 Nov 2023 09:06:33 +0100 Message-ID: <20231124080623.564924-10-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.42.0.586.gbc5204569f7d.dirty In-Reply-To: <20231124080623.564924-1-u.kleine-koenig@pengutronix.de> References: <20231124080623.564924-1-u.kleine-koenig@pengutronix.de> Precedence: bulk X-Mailing-List: linux-pm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1768; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=C8Pg2Nx+J98OmOxnB4V+j482CtteM/2CgjpQBglZCAU=; b=owGbwMvMwMXY3/A7olbonx/jabUkhtSEyE67lfUdNpIzRaQVM7MdueOOZMoW12vXii+v0l3qy Jwgo9PJaMzCwMjFICumyGLfuCbTqkousnPtv8swg1iZQKYwcHEKwEQ8znIwrJZpU23POnS9I1aA jzFi0bQWwdvn7zOvX3/w/OE/134yr57xVdfCwIvRbe7P1OZTO2es+Ln1jbCxQ7OT0uyG5v5Ve4L aN80ofSylso5zQpbzba/DIf/8Wio7Pi18+InVcY531GyfVG7Nbxbzf+0IX/GuaTOX5dq43NcOws 5zIpZ0ZorcEnEWY5K9WigmbB/uVOjbfU7KfHJqp9X/uV1yWpfCVoQfPjd3PedZXpmo99ku95v3O DxI8sub1ZTyTNYv+76vqd8NzrMdr7ZGKf/9Oc/O/lxdw9eZWzat7GJaFP/IsObH/H1mcmoxfKkC byXKo/YpBc78dNJ+wiGFori7GhM/OT9kirT3VF59bEIJAA== X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-pm@vger.kernel.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König Acked-by: Michal Simek --- drivers/pmdomain/xilinx/zynqmp-pm-domains.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/pmdomain/xilinx/zynqmp-pm-domains.c b/drivers/pmdomain/xilinx/zynqmp-pm-domains.c index 69d03ad4cf1e..6fd514286d82 100644 --- a/drivers/pmdomain/xilinx/zynqmp-pm-domains.c +++ b/drivers/pmdomain/xilinx/zynqmp-pm-domains.c @@ -293,11 +293,9 @@ static int zynqmp_gpd_probe(struct platform_device *pdev) return 0; } -static int zynqmp_gpd_remove(struct platform_device *pdev) +static void zynqmp_gpd_remove(struct platform_device *pdev) { of_genpd_del_provider(pdev->dev.parent->of_node); - - return 0; } static void zynqmp_gpd_sync_state(struct device *dev) @@ -315,7 +313,7 @@ static struct platform_driver zynqmp_power_domain_driver = { .sync_state = zynqmp_gpd_sync_state, }, .probe = zynqmp_gpd_probe, - .remove = zynqmp_gpd_remove, + .remove_new = zynqmp_gpd_remove, }; module_platform_driver(zynqmp_power_domain_driver);