| Message ID | 20231127212049.455008-1-schan@cloudflare.com (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | Shuah Khan |
| Headers | show |
| Series | [v2] tools cpupower bench: Override CFLAGS assignments | expand |
On 11/27/23 14:20, Stanley Chan wrote: > Allow user to specify outside CFLAGS values as make argument > > Corrects an issue where CFLAGS is passed as a make argument for > cpupower, but bench's makefile does not inherit and append to them. > > Fixes: dbc4ca339c8d ("tools cpupower: Override CFLAGS assignments") There is no need for this Fixes tag since this patch doesn't fix the problem introduced by dbc4ca339c8d This patch fixes the problem in bench/Makefile like dbc4ca339c8d did in cpupower/Makefile. In this case Fixes tag is incorrect. I removed the Fixes tag and applied it to https://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux.git/log/?h=cpupower thanks, -- Shuah
diff --git a/tools/power/cpupower/bench/Makefile b/tools/power/cpupower/bench/Makefile index d9d9923af85c..a4b902f9e1c4 100644 --- a/tools/power/cpupower/bench/Makefile +++ b/tools/power/cpupower/bench/Makefile @@ -15,7 +15,7 @@ LIBS = -L../ -L$(OUTPUT) -lm -lcpupower OBJS = $(OUTPUT)main.o $(OUTPUT)parse.o $(OUTPUT)system.o $(OUTPUT)benchmark.o endif -CFLAGS += -D_GNU_SOURCE -I../lib -DDEFAULT_CONFIG_FILE=\"$(confdir)/cpufreq-bench.conf\" +override CFLAGS += -D_GNU_SOURCE -I../lib -DDEFAULT_CONFIG_FILE=\"$(confdir)/cpufreq-bench.conf\" $(OUTPUT)%.o : %.c $(ECHO) " CC " $@
Allow user to specify outside CFLAGS values as make argument Corrects an issue where CFLAGS is passed as a make argument for cpupower, but bench's makefile does not inherit and append to them. Fixes: dbc4ca339c8d ("tools cpupower: Override CFLAGS assignments") Signed-off-by: Stanley Chan <schan@cloudflare.com> --- tools/power/cpupower/bench/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.34.1