| Message ID | 20240106133546.936261-2-bhavin.sharma@siliconsignals.io (mailing list archive) |
|---|---|
| State | Handled Elsewhere, archived |
| Headers | show |
| Series | [v2,1/2] power: supply: Add STC3117 fuel gauge unit driver | expand |
On Sat, 06 Jan 2024 19:05:44 +0530, Bhavin Sharma wrote: > Convert the binding to DT schema format. > > Changes in V2 resolved below errors: > 1. string value is redundantly quoted with any quotes (quoted-strings) > 2. found character '\t' that cannot start any token > > Signed-off-by: Bhavin Sharma <bhavin.sharma@siliconsignals.io> > --- > .../bindings/power/supply/stc3117-fg.yaml | 41 +++++++++++++++++++ > 1 file changed, 41 insertions(+) > create mode 100644 Documentation/devicetree/bindings/power/supply/stc3117-fg.yaml > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: dtschema/dtc warnings/errors: Error: Documentation/devicetree/bindings/power/supply/stc3117-fg.example.dts:18.9-14 syntax error FATAL ERROR: Unable to parse input tree make[2]: *** [scripts/Makefile.lib:419: Documentation/devicetree/bindings/power/supply/stc3117-fg.example.dtb] Error 1 make[2]: *** Waiting for unfinished jobs.... make[1]: *** [/builds/robherring/dt-review-ci/linux/Makefile:1424: dt_binding_check] Error 2 make: *** [Makefile:234: __sub-make] Error 2 doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240106133546.936261-2-bhavin.sharma@siliconsignals.io The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
On 06/01/2024 14:35, Bhavin Sharma wrote: > Convert the binding to DT schema format. Subject: It's totally wrong. There is no conversion. If you claim otherwise, please point me to removal of any file in this patch. > > Changes in V2 resolved below errors: Changelog goes under --- > 1. string value is redundantly quoted with any quotes (quoted-strings) > 2. found character '\t' that cannot start any token Heh, you still did not test it. > > Signed-off-by: Bhavin Sharma <bhavin.sharma@siliconsignals.io> > --- > .../bindings/power/supply/stc3117-fg.yaml | 41 +++++++++++++++++++ > 1 file changed, 41 insertions(+) > create mode 100644 Documentation/devicetree/bindings/power/supply/stc3117-fg.yaml > > diff --git a/Documentation/devicetree/bindings/power/supply/stc3117-fg.yaml b/Documentation/devicetree/bindings/power/supply/stc3117-fg.yaml > new file mode 100644 > index 000000000..d6607a5ea > --- /dev/null > +++ b/Documentation/devicetree/bindings/power/supply/stc3117-fg.yaml > @@ -0,0 +1,41 @@ > +# SPDX-License-Identifier: GPL-2.0-only > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/power/supply/stc3117-fg.yaml# Namke matching compatible. > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: STMicroelectronics STC3117 Fuel Gauge Unit Power Supply > + > +maintainers: > + - Bhavin Sharma <bhavin.sharma@siliconsignals.io> > + - Hardevsinh Palaniya <hardevsinh.palaniya@siliconsignals.io> > + > +allOf: > + - $ref: power-supply.yaml# > + > +properties: > + compatible: > + enum: > + - st,stc3117-fgu Can stc3117 be anything else? IOW, why "fgu" is needed? > + > + reg: > + maxItems: 1 No properties? No resources? > + > +required: > + - compatible > + - reg > + > +additionalProperties: false unevaluatedProperties instead > + > +examples: > + - | > + &i2c6 { Just i2c { > + #address-cells = <1>; > + #size-cells = <0>; > + > + st3117: stc3117@70 { Drop label. Node names should be generic. See also an explanation and list of examples (not exhaustive) in DT specification: https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation > + compatible = "st,stc3117-fgu"; > + reg = <0x70>; > + status = "okay"; Drop status. Add missing properties for this to be complete. > + }; > + }; Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/power/supply/stc3117-fg.yaml b/Documentation/devicetree/bindings/power/supply/stc3117-fg.yaml new file mode 100644 index 000000000..d6607a5ea --- /dev/null +++ b/Documentation/devicetree/bindings/power/supply/stc3117-fg.yaml @@ -0,0 +1,41 @@ +# SPDX-License-Identifier: GPL-2.0-only +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/power/supply/stc3117-fg.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: STMicroelectronics STC3117 Fuel Gauge Unit Power Supply + +maintainers: + - Bhavin Sharma <bhavin.sharma@siliconsignals.io> + - Hardevsinh Palaniya <hardevsinh.palaniya@siliconsignals.io> + +allOf: + - $ref: power-supply.yaml# + +properties: + compatible: + enum: + - st,stc3117-fgu + + reg: + maxItems: 1 + +required: + - compatible + - reg + +additionalProperties: false + +examples: + - | + &i2c6 { + #address-cells = <1>; + #size-cells = <0>; + + st3117: stc3117@70 { + compatible = "st,stc3117-fgu"; + reg = <0x70>; + status = "okay"; + }; + };
Convert the binding to DT schema format. Changes in V2 resolved below errors: 1. string value is redundantly quoted with any quotes (quoted-strings) 2. found character '\t' that cannot start any token Signed-off-by: Bhavin Sharma <bhavin.sharma@siliconsignals.io> --- .../bindings/power/supply/stc3117-fg.yaml | 41 +++++++++++++++++++ 1 file changed, 41 insertions(+) create mode 100644 Documentation/devicetree/bindings/power/supply/stc3117-fg.yaml