| Message ID | 20240308-topic-rb1_lmh-v2-2-bac3914b0fe3@linaro.org (mailing list archive) |
|---|---|
| State | New |
| Delegated to: | Daniel Lezcano |
| Headers | show |
| Series | QCM2290 LMH | expand |
On Sat, Mar 09, 2024 at 02:15:03PM +0100, Konrad Dybcio wrote: > Up until now, the necessary scm availability check has not been > performed, leading to possible null pointer dereferences (which did > happen for me on RB1). > > Fix that. > > Fixes: 53bca371cdf7 ("thermal/drivers/qcom: Add support for LMh driver") > Cc: <stable@vger.kernel.org> > Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org> Reviewed-by: Bjorn Andersson <andersson@kernel.org> Regards, Bjorn
On 09/03/2024 14:15, Konrad Dybcio wrote: > Up until now, the necessary scm availability check has not been > performed, leading to possible null pointer dereferences (which did > happen for me on RB1). > > Fix that. > > Fixes: 53bca371cdf7 ("thermal/drivers/qcom: Add support for LMh driver") > Cc: <stable@vger.kernel.org> > Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org> > --- Applied, thanks
diff --git a/drivers/thermal/qcom/lmh.c b/drivers/thermal/qcom/lmh.c index f6edb12ec004..5225b3621a56 100644 --- a/drivers/thermal/qcom/lmh.c +++ b/drivers/thermal/qcom/lmh.c @@ -95,6 +95,9 @@ static int lmh_probe(struct platform_device *pdev) unsigned int enable_alg; u32 node_id; + if (!qcom_scm_is_available()) + return -EPROBE_DEFER; + lmh_data = devm_kzalloc(dev, sizeof(*lmh_data), GFP_KERNEL); if (!lmh_data) return -ENOMEM;
Up until now, the necessary scm availability check has not been performed, leading to possible null pointer dereferences (which did happen for me on RB1). Fix that. Fixes: 53bca371cdf7 ("thermal/drivers/qcom: Add support for LMh driver") Cc: <stable@vger.kernel.org> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org> --- drivers/thermal/qcom/lmh.c | 3 +++ 1 file changed, 3 insertions(+)