| Message ID | 20240320-thermal-v3-1-700296694c4a@gmail.com (mailing list archive) |
|---|---|
| State | New |
| Delegated to: | Daniel Lezcano |
| Headers | show |
| Series | Update st,stih407-thermal device | expand |
On 20/03/2024 22:33, Raphael Gallais-Pou wrote: > 'st,passive_colling_temp' does not appear in the device-tree, 'reg' and > '#thermal-sensor-cells' are also missing in the device description. > > Convert st,stih407-thermal binding to DT schema format in order to clean > unused 'st,passive_cooling_temp' and add missing properties. > > Signed-off-by: Raphael Gallais-Pou <rgallaispou@gmail.com> > --- > Changes in v3: > - Specify const value for '#thermal-sensor-cells' > - Add 'maxItems' for 'interrupts' property > - Change commit log accordingly Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
On 20/03/2024 22:33, Raphael Gallais-Pou wrote: > 'st,passive_colling_temp' does not appear in the device-tree, 'reg' and > '#thermal-sensor-cells' are also missing in the device description. > > Convert st,stih407-thermal binding to DT schema format in order to clean > unused 'st,passive_cooling_temp' and add missing properties. > > Signed-off-by: Raphael Gallais-Pou <rgallaispou@gmail.com> > --- > Changes in v3: > - Specify const value for '#thermal-sensor-cells' > - Add 'maxItems' for 'interrupts' property > - Change commit log accordingly > > Changes in v2: > - Change commit log to use imperative > - Drop description > - Drop 'clocks' description > - Add 'reg' property > - Add '#thermal-sensor-cells' > - Make node name generic in example > - Fix YAML style > --- > .../bindings/thermal/st,stih407-thermal.yaml | 58 ++++++++++++++++++++++ > .../devicetree/bindings/thermal/st-thermal.txt | 32 ------------ > 2 files changed, 58 insertions(+), 32 deletions(-) > > diff --git a/Documentation/devicetree/bindings/thermal/st,stih407-thermal.yaml b/Documentation/devicetree/bindings/thermal/st,stih407-thermal.yaml > new file mode 100644 > index 000000000000..9f6fc5c95c55 > --- /dev/null Applied, thanks
diff --git a/Documentation/devicetree/bindings/thermal/st,stih407-thermal.yaml b/Documentation/devicetree/bindings/thermal/st,stih407-thermal.yaml new file mode 100644 index 000000000000..9f6fc5c95c55 --- /dev/null +++ b/Documentation/devicetree/bindings/thermal/st,stih407-thermal.yaml @@ -0,0 +1,58 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/thermal/st,stih407-thermal.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: STMicroelectronics STi digital thermal sensor (DTS) + +maintainers: + - Patrice Chotard <patrice.chotard@foss.st.com> + - Lee Jones <lee@kernel.org> + +allOf: + - $ref: thermal-sensor.yaml + +properties: + compatible: + const: st,stih407-thermal + + reg: + maxItems: 1 + + clocks: + maxItems: 1 + + clock-names: + items: + - const: thermal + + interrupts: + description: + For thermal sensors for which no interrupt has been defined, a polling + delay of 1000ms will be used to read the temperature from device. + maxItems: 1 + + '#thermal-sensor-cells': + const: 0 + +required: + - compatible + - reg + - clocks + - clock-names + +unevaluatedProperties: false + +examples: + - | + #include <dt-bindings/interrupt-controller/arm-gic.h> + temperature-sensor@91a0000 { + compatible = "st,stih407-thermal"; + reg = <0x91a0000 0x28>; + clock-names = "thermal"; + clocks = <&CLK_SYSIN>; + interrupts = <GIC_SPI 205 IRQ_TYPE_EDGE_RISING>; + #thermal-sensor-cells = <0>; + }; +... diff --git a/Documentation/devicetree/bindings/thermal/st-thermal.txt b/Documentation/devicetree/bindings/thermal/st-thermal.txt deleted file mode 100644 index a2f939137e35..000000000000 --- a/Documentation/devicetree/bindings/thermal/st-thermal.txt +++ /dev/null @@ -1,32 +0,0 @@ -Binding for Thermal Sensor driver for STMicroelectronics STi series of SoCs. - -Required parameters: -------------------- - -compatible : Should be "st,stih407-thermal" - -clock-names : Should be "thermal". - See: Documentation/devicetree/bindings/resource-names.txt -clocks : Phandle of the clock used by the thermal sensor. - See: Documentation/devicetree/bindings/clock/clock-bindings.txt - -Optional parameters: -------------------- - -reg : For non-sysconf based sensors, this should be the physical base - address and length of the sensor's registers. -interrupts : Standard way to define interrupt number. - NB: For thermal sensor's for which no interrupt has been - defined, a polling delay of 1000ms will be used to read the - temperature from device. - -Example: - - temp0@91a0000 { - compatible = "st,stih407-thermal"; - reg = <0x91a0000 0x28>; - clock-names = "thermal"; - clocks = <&CLK_SYSIN>; - interrupts = <GIC_SPI 205 IRQ_TYPE_EDGE_RISING>; - st,passive_cooling_temp = <110>; - };
'st,passive_colling_temp' does not appear in the device-tree, 'reg' and '#thermal-sensor-cells' are also missing in the device description. Convert st,stih407-thermal binding to DT schema format in order to clean unused 'st,passive_cooling_temp' and add missing properties. Signed-off-by: Raphael Gallais-Pou <rgallaispou@gmail.com> --- Changes in v3: - Specify const value for '#thermal-sensor-cells' - Add 'maxItems' for 'interrupts' property - Change commit log accordingly Changes in v2: - Change commit log to use imperative - Drop description - Drop 'clocks' description - Add 'reg' property - Add '#thermal-sensor-cells' - Make node name generic in example - Fix YAML style --- .../bindings/thermal/st,stih407-thermal.yaml | 58 ++++++++++++++++++++++ .../devicetree/bindings/thermal/st-thermal.txt | 32 ------------ 2 files changed, 58 insertions(+), 32 deletions(-)