diff mbox series

[1/2] dt-bindings: power: supply: max8903: specify flt-gpios as input

Message ID 20240415151645.1986014-1-github.com@herrie.org (mailing list archive)
State Handled Elsewhere, archived
Headers show
Series [1/2] dt-bindings: power: supply: max8903: specify flt-gpios as input | expand

Commit Message

Herman van Hazendonk April 15, 2024, 3:16 p.m. UTC
The FLT pin was incorrected documented as an output. The MAX8903 uses it to
signal to the processor that a charging fault has occurred.

Signed-off-by: Herman van Hazendonk <github.com@herrie.org>
---
 .../devicetree/bindings/power/supply/maxim,max8903.yaml         | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Conor Dooley April 15, 2024, 4:28 p.m. UTC | #1
On Mon, Apr 15, 2024 at 05:16:45PM +0200, Herman van Hazendonk wrote:
> The FLT pin was incorrected documented as an output. The MAX8903 uses it to
> signal to the processor that a charging fault has occurred.

I guess this is just a matter of framing? Input to the hardware running
the OS but an output from the max8903?

I'm okay with whatever wording causing less confusion, which may mean
something that specifics what this is relative to?

> 
> Signed-off-by: Herman van Hazendonk <github.com@herrie.org>

The SoB email should match the from email fyi.
Cheers,
Conor.

> ---
>  .../devicetree/bindings/power/supply/maxim,max8903.yaml         | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/power/supply/maxim,max8903.yaml b/Documentation/devicetree/bindings/power/supply/maxim,max8903.yaml
> index a8d625f285f1..86af38378999 100644
> --- a/Documentation/devicetree/bindings/power/supply/maxim,max8903.yaml
> +++ b/Documentation/devicetree/bindings/power/supply/maxim,max8903.yaml
> @@ -34,7 +34,7 @@ properties:
>  
>    flt-gpios:
>      maxItems: 1
> -    description: Fault pin (active low, output)
> +    description: Fault pin (active low, input)
>  
>    dcm-gpios:
>      maxItems: 1
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/power/supply/maxim,max8903.yaml b/Documentation/devicetree/bindings/power/supply/maxim,max8903.yaml
index a8d625f285f1..86af38378999 100644
--- a/Documentation/devicetree/bindings/power/supply/maxim,max8903.yaml
+++ b/Documentation/devicetree/bindings/power/supply/maxim,max8903.yaml
@@ -34,7 +34,7 @@  properties:
 
   flt-gpios:
     maxItems: 1
-    description: Fault pin (active low, output)
+    description: Fault pin (active low, input)
 
   dcm-gpios:
     maxItems: 1