| Message ID | 20240508034352.18414-5-ricardo.neri-calderon@linux.intel.com (mailing list archive) |
|---|---|
| State | In Next |
| Delegated to: | Rafael Wysocki |
| Headers | show |
| Series | thermal: intel: hfi: Update thermal netlink parameters | expand |
On Tue, 2024-05-07 at 20:43 -0700, Ricardo Neri wrote: > The number of updated CPU capabilities per netlink event is hard- > coded to > 16. On systems with more than 16 CPUs (a common case), it takes more > than > one thermal netlink event to relay all the new capabilities after an > HFI > interrupt. This adds unnecessary overhead to both the kernel and user > space > entities. > > Increase the number of CPU capabilities updated per event to 64. Any > system > with 64 CPUs or less can now update all the capabilities in a single > thermal netlink event. > > Signed-off-by: Ricardo Neri <ricardo.neri-calderon@linux.intel.com> Acked-by: Zhang Rui <rui.zhang@intel.com> -rui > --- > Cc: Len Brown <len.brown@intel.com> > Cc: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com> > Cc: Stanislaw Gruszka <stanislaw.gruszka@linux.intel.com> > Cc: Zhang Rui <rui.zhang@intel.com> > Cc: linux-pm@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > --- > Changes since v2: > * Dropped the debugfs interface. Instead, increased the size of the > thermal netlink message size to 64 CPU capabilities. > --- > drivers/thermal/intel/intel_hfi.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/thermal/intel/intel_hfi.c > b/drivers/thermal/intel/intel_hfi.c > index c6658f8c5cca..a180a98bb9f1 100644 > --- a/drivers/thermal/intel/intel_hfi.c > +++ b/drivers/thermal/intel/intel_hfi.c > @@ -167,7 +167,7 @@ static DEFINE_MUTEX(hfi_instance_lock); > > static struct workqueue_struct *hfi_updates_wq; > #define HFI_UPDATE_DELAY_MS 100 > -#define HFI_THERMNL_CAPS_PER_EVENT 16 > +#define HFI_THERMNL_CAPS_PER_EVENT 64 > > static void get_hfi_caps(struct hfi_instance *hfi_instance, > struct thermal_genl_cpu_caps *cpu_caps)
diff --git a/drivers/thermal/intel/intel_hfi.c b/drivers/thermal/intel/intel_hfi.c index c6658f8c5cca..a180a98bb9f1 100644 --- a/drivers/thermal/intel/intel_hfi.c +++ b/drivers/thermal/intel/intel_hfi.c @@ -167,7 +167,7 @@ static DEFINE_MUTEX(hfi_instance_lock); static struct workqueue_struct *hfi_updates_wq; #define HFI_UPDATE_DELAY_MS 100 -#define HFI_THERMNL_CAPS_PER_EVENT 16 +#define HFI_THERMNL_CAPS_PER_EVENT 64 static void get_hfi_caps(struct hfi_instance *hfi_instance, struct thermal_genl_cpu_caps *cpu_caps)
The number of updated CPU capabilities per netlink event is hard-coded to 16. On systems with more than 16 CPUs (a common case), it takes more than one thermal netlink event to relay all the new capabilities after an HFI interrupt. This adds unnecessary overhead to both the kernel and user space entities. Increase the number of CPU capabilities updated per event to 64. Any system with 64 CPUs or less can now update all the capabilities in a single thermal netlink event. Signed-off-by: Ricardo Neri <ricardo.neri-calderon@linux.intel.com> --- Cc: Len Brown <len.brown@intel.com> Cc: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com> Cc: Stanislaw Gruszka <stanislaw.gruszka@linux.intel.com> Cc: Zhang Rui <rui.zhang@intel.com> Cc: linux-pm@vger.kernel.org Cc: linux-kernel@vger.kernel.org --- Changes since v2: * Dropped the debugfs interface. Instead, increased the size of the thermal netlink message size to 64 CPU capabilities. --- drivers/thermal/intel/intel_hfi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)