diff mbox series

[1/2] x86/cpufeatures: Add HWP highest perf change feature flag

Message ID 20240618035122.438822-2-srinivas.pandruvada@linux.intel.com (mailing list archive)
State Changes Requested, archived
Headers show
Series Update highest frequency of a CPU after boot | expand

Commit Message

Srinivas Pandruvada June 18, 2024, 3:51 a.m. UTC
When CPUID[6].EAX[15] is set to 1, this CPU supports notification for
HWP (Hardware P-states) highest performance change.

Add a feature flag to check if the CPU supports HWP highest performance
change.

Signed-off-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
---
 arch/x86/include/asm/cpufeatures.h | 1 +
 1 file changed, 1 insertion(+)

Comments

Borislav Petkov June 18, 2024, 9:07 a.m. UTC | #1
On Mon, Jun 17, 2024 at 08:51:20PM -0700, Srinivas Pandruvada wrote:
> When CPUID[6].EAX[15] is set to 1, this CPU supports notification for
> HWP (Hardware P-states) highest performance change.
> 
> Add a feature flag to check if the CPU supports HWP highest performance
> change.
> 
> Signed-off-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
> ---
>  arch/x86/include/asm/cpufeatures.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/x86/include/asm/cpufeatures.h b/arch/x86/include/asm/cpufeatures.h
> index 3c7434329661..4674ba5310b2 100644
> --- a/arch/x86/include/asm/cpufeatures.h
> +++ b/arch/x86/include/asm/cpufeatures.h
> @@ -361,6 +361,7 @@
>  #define X86_FEATURE_HWP_ACT_WINDOW	(14*32+ 9) /* HWP Activity Window */
>  #define X86_FEATURE_HWP_EPP		(14*32+10) /* HWP Energy Perf. Preference */
>  #define X86_FEATURE_HWP_PKG_REQ		(14*32+11) /* HWP Package Level Request */
> +#define X86_FEATURE_HWP_HIGHEST_PERF_CHANGE (14*32+15) /* HWP Highest perf change */

Doesn't belong in /proc/cpuinfo:

#define X86_FEATURE_HWP_HIGHEST_PERF_CHANGE (14*32+15) /* "" HWP Highest perf change */

							^^^^^
Srinivas Pandruvada June 18, 2024, 10:25 a.m. UTC | #2
On Tue, 2024-06-18 at 11:07 +0200, Borislav Petkov wrote:
> On Mon, Jun 17, 2024 at 08:51:20PM -0700, Srinivas Pandruvada wrote:
> > When CPUID[6].EAX[15] is set to 1, this CPU supports notification
> > for
> > HWP (Hardware P-states) highest performance change.
> > 
> > Add a feature flag to check if the CPU supports HWP highest
> > performance
> > change.
> > 
> > 

[...]

> > +#define X86_FEATURE_HWP_HIGHEST_PERF_CHANGE (14*32+15) /* HWP
> > Highest perf change */
> 
> Doesn't belong in /proc/cpuinfo:
> 
> #define X86_FEATURE_HWP_HIGHEST_PERF_CHANGE (14*32+15) /* "" HWP
> Highest perf change */
> 
>                                                         ^^^^^

Thanks for pointing this out. Will update in v2.

-Srinivas

> 
>
diff mbox series

Patch

diff --git a/arch/x86/include/asm/cpufeatures.h b/arch/x86/include/asm/cpufeatures.h
index 3c7434329661..4674ba5310b2 100644
--- a/arch/x86/include/asm/cpufeatures.h
+++ b/arch/x86/include/asm/cpufeatures.h
@@ -361,6 +361,7 @@ 
 #define X86_FEATURE_HWP_ACT_WINDOW	(14*32+ 9) /* HWP Activity Window */
 #define X86_FEATURE_HWP_EPP		(14*32+10) /* HWP Energy Perf. Preference */
 #define X86_FEATURE_HWP_PKG_REQ		(14*32+11) /* HWP Package Level Request */
+#define X86_FEATURE_HWP_HIGHEST_PERF_CHANGE (14*32+15) /* HWP Highest perf change */
 #define X86_FEATURE_HFI			(14*32+19) /* Hardware Feedback Interface */
 
 /* AMD SVM Feature Identification, CPUID level 0x8000000a (EDX), word 15 */