| Message ID | 20240621-x1e80100-power-supply-qcom-battmgr-v1-1-40cb89a0c144@linaro.org (mailing list archive) |
|---|---|
| State | Handled Elsewhere, archived |
| Headers | show |
| Series | power: supply: qcom_battmgr: Enable battery support on x1e80100 | expand |
On Fri, Jun 21, 2024 at 10:16:35AM +0300, Abel Vesa wrote: > The x1e80100, being a compute platform, provides functionality for the > exact same power supplies as sc8280xp. Add the compatible and assign > the sc8280xp match data. > > Signed-off-by: Abel Vesa <abel.vesa@linaro.org> I'm running with the battery disconnected but the reported values look correct: Reviewed-by: Johan Hovold <johan+linaro@kernel.org> Tested-by: Johan Hovold <johan+linaro@kernel.org> Johan
On Fri, Jun 21, 2024 at 10:16:35AM GMT, Abel Vesa wrote: > The x1e80100, being a compute platform, provides functionality for the > exact same power supplies as sc8280xp. Add the compatible and assign > the sc8280xp match data. > > Signed-off-by: Abel Vesa <abel.vesa@linaro.org> > --- > drivers/power/supply/qcom_battmgr.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/power/supply/qcom_battmgr.c b/drivers/power/supply/qcom_battmgr.c > index ec163d1bcd18..46f36dcb185c 100644 > --- a/drivers/power/supply/qcom_battmgr.c > +++ b/drivers/power/supply/qcom_battmgr.c > @@ -1308,6 +1308,7 @@ static void qcom_battmgr_pdr_notify(void *priv, int state) > static const struct of_device_id qcom_battmgr_of_variants[] = { > { .compatible = "qcom,sc8180x-pmic-glink", .data = (void *)QCOM_BATTMGR_SC8280XP }, > { .compatible = "qcom,sc8280xp-pmic-glink", .data = (void *)QCOM_BATTMGR_SC8280XP }, > + { .compatible = "qcom,x1e80100-pmic-glink", .data = (void *)QCOM_BATTMGR_SC8280XP }, Do we have a bindings patch somewhere? If these devices are compatible, what about using a fallback entry instead? > /* Unmatched devices falls back to QCOM_BATTMGR_SM8350 */ > {} > }; > > --- > base-commit: 2102cb0d050d34d50b9642a3a50861787527e922 > change-id: 20240522-x1e80100-power-supply-qcom-battmgr-83442b7cce60 > > Best regards, > -- > Abel Vesa <abel.vesa@linaro.org> >
On Fri, 21 Jun 2024 10:16:35 +0300, Abel Vesa wrote: > The x1e80100, being a compute platform, provides functionality for the > exact same power supplies as sc8280xp. Add the compatible and assign > the sc8280xp match data. > > Applied, thanks! [1/1] power: supply: qcom_battmgr: Enable battery support on x1e80100 commit: 29832adac01a1057e89579c977ef4776623ee463 Best regards,
diff --git a/drivers/power/supply/qcom_battmgr.c b/drivers/power/supply/qcom_battmgr.c index ec163d1bcd18..46f36dcb185c 100644 --- a/drivers/power/supply/qcom_battmgr.c +++ b/drivers/power/supply/qcom_battmgr.c @@ -1308,6 +1308,7 @@ static void qcom_battmgr_pdr_notify(void *priv, int state) static const struct of_device_id qcom_battmgr_of_variants[] = { { .compatible = "qcom,sc8180x-pmic-glink", .data = (void *)QCOM_BATTMGR_SC8280XP }, { .compatible = "qcom,sc8280xp-pmic-glink", .data = (void *)QCOM_BATTMGR_SC8280XP }, + { .compatible = "qcom,x1e80100-pmic-glink", .data = (void *)QCOM_BATTMGR_SC8280XP }, /* Unmatched devices falls back to QCOM_BATTMGR_SM8350 */ {} };
The x1e80100, being a compute platform, provides functionality for the exact same power supplies as sc8280xp. Add the compatible and assign the sc8280xp match data. Signed-off-by: Abel Vesa <abel.vesa@linaro.org> --- drivers/power/supply/qcom_battmgr.c | 1 + 1 file changed, 1 insertion(+) --- base-commit: 2102cb0d050d34d50b9642a3a50861787527e922 change-id: 20240522-x1e80100-power-supply-qcom-battmgr-83442b7cce60 Best regards,