| Message ID | 20240622215219.47911-1-mario.limonciello@amd.com (mailing list archive) |
|---|---|
| State | Queued |
| Delegated to: | Mario Limonciello |
| Headers | show |
| Series | cpufreq: amd-pstate: Make amd-pstate unit tests depend on amd-pstate | expand |
[Public] Hi Mario, > -----Original Message----- > From: Limonciello, Mario <Mario.Limonciello@amd.com> > Sent: Sunday, June 23, 2024 5:52 AM > To: Yuan, Perry <Perry.Yuan@amd.com>; Shenoy, Gautham Ranjal > <gautham.shenoy@amd.com> > Cc: Linux PM <linux-pm@vger.kernel.org>; Limonciello, Mario > <Mario.Limonciello@amd.com>; kernel test robot <lkp@intel.com> > Subject: [PATCH] cpufreq: amd-pstate: Make amd-pstate unit tests depend > on amd-pstate > > As the unit tests use a symbol from the driver an explicit dependency is > required. > > Reported-by: kernel test robot <lkp@intel.com> > Closes: https://lore.kernel.org/oe-kbuild-all/202406222016.R4A2TMs8- > lkp@intel.com/ > Signed-off-by: Mario Limonciello <mario.limonciello@amd.com> > --- > drivers/cpufreq/Kconfig.x86 | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/cpufreq/Kconfig.x86 b/drivers/cpufreq/Kconfig.x86 index > 438c9e75a04d..97c2d4f15d76 100644 > --- a/drivers/cpufreq/Kconfig.x86 > +++ b/drivers/cpufreq/Kconfig.x86 > @@ -71,6 +71,7 @@ config X86_AMD_PSTATE_DEFAULT_MODE config > X86_AMD_PSTATE_UT > tristate "selftest for AMD Processor P-State driver" > depends on X86 && ACPI_PROCESSOR > + depends on X86_AMD_PSTATE > default n > help > This kernel module is used for testing. It's safe to say M here. > -- > 2.43.0 LGTM, thanks for the quick fix. Reviewed-by: Perry Yuan <Perry.Yuan@amd.com>
Mario Limonciello <mario.limonciello@amd.com> writes: > As the unit tests use a symbol from the driver an explicit dependency > is required. > > Reported-by: kernel test robot <lkp@intel.com> > Closes: https://lore.kernel.org/oe-kbuild-all/202406222016.R4A2TMs8-lkp@intel.com/ > Signed-off-by: Mario Limonciello <mario.limonciello@amd.com> Reviewed-by: Gautham R. Shenoy <gautham.shenoy@amd.com> > --- > drivers/cpufreq/Kconfig.x86 | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/cpufreq/Kconfig.x86 b/drivers/cpufreq/Kconfig.x86 > index 438c9e75a04d..97c2d4f15d76 100644 > --- a/drivers/cpufreq/Kconfig.x86 > +++ b/drivers/cpufreq/Kconfig.x86 > @@ -71,6 +71,7 @@ config X86_AMD_PSTATE_DEFAULT_MODE > config X86_AMD_PSTATE_UT > tristate "selftest for AMD Processor P-State driver" > depends on X86 && ACPI_PROCESSOR > + depends on X86_AMD_PSTATE > default n > help > This kernel module is used for testing. It's safe to say M here. > -- > 2.43.0
diff --git a/drivers/cpufreq/Kconfig.x86 b/drivers/cpufreq/Kconfig.x86 index 438c9e75a04d..97c2d4f15d76 100644 --- a/drivers/cpufreq/Kconfig.x86 +++ b/drivers/cpufreq/Kconfig.x86 @@ -71,6 +71,7 @@ config X86_AMD_PSTATE_DEFAULT_MODE config X86_AMD_PSTATE_UT tristate "selftest for AMD Processor P-State driver" depends on X86 && ACPI_PROCESSOR + depends on X86_AMD_PSTATE default n help This kernel module is used for testing. It's safe to say M here.
As the unit tests use a symbol from the driver an explicit dependency is required. Reported-by: kernel test robot <lkp@intel.com> Closes: https://lore.kernel.org/oe-kbuild-all/202406222016.R4A2TMs8-lkp@intel.com/ Signed-off-by: Mario Limonciello <mario.limonciello@amd.com> --- drivers/cpufreq/Kconfig.x86 | 1 + 1 file changed, 1 insertion(+)