| Message ID | 20240704200327.8583-8-a39.skl@gmail.com (mailing list archive) |
|---|---|
| State | Handled Elsewhere, archived |
| Headers | show |
| Series | msm8937/msm8976/qcs404 icc patches | expand |
On 04/07/2024 22:02, Adam Skladowski wrote: > For now example list snoc_mm as children of bimc which is obviously > not valid, drop snoc and snoc_mm and leave bimc alone. > > Signed-off-by: Adam Skladowski <a39.skl@gmail.com> > --- > .../bindings/interconnect/qcom,msm8939.yaml | 13 +------------ > 1 file changed, 1 insertion(+), 12 deletions(-) > > diff --git a/Documentation/devicetree/bindings/interconnect/qcom,msm8939.yaml b/Documentation/devicetree/bindings/interconnect/qcom,msm8939.yaml > index fd15ab5014fb..3aed8b77f35d 100644 > --- a/Documentation/devicetree/bindings/interconnect/qcom,msm8939.yaml > +++ b/Documentation/devicetree/bindings/interconnect/qcom,msm8939.yaml > @@ -56,19 +56,8 @@ examples: > - | > #include <dt-bindings/clock/qcom,rpmcc.h> > > - snoc: interconnect@580000 { > - compatible = "qcom,msm8939-snoc"; The one correct example would be the snoc, because it is the most complete, but well... Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
On 7/5/24 08:57, Krzysztof Kozlowski wrote: > On 04/07/2024 22:02, Adam Skladowski wrote: >> For now example list snoc_mm as children of bimc which is obviously >> not valid, drop snoc and snoc_mm and leave bimc alone. >> >> Signed-off-by: Adam Skladowski <a39.skl@gmail.com> >> --- >> .../bindings/interconnect/qcom,msm8939.yaml | 13 +------------ >> 1 file changed, 1 insertion(+), 12 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/interconnect/qcom,msm8939.yaml b/Documentation/devicetree/bindings/interconnect/qcom,msm8939.yaml >> index fd15ab5014fb..3aed8b77f35d 100644 >> --- a/Documentation/devicetree/bindings/interconnect/qcom,msm8939.yaml >> +++ b/Documentation/devicetree/bindings/interconnect/qcom,msm8939.yaml >> @@ -56,19 +56,8 @@ examples: >> - | >> #include <dt-bindings/clock/qcom,rpmcc.h> >> >> - snoc: interconnect@580000 { >> - compatible = "qcom,msm8939-snoc"; > The one correct example would be the snoc, because it is the most > complete, but well... > > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > > Best regards, > Krzysztof > Will do it for v3 so this r-b ain't going to be carried.
diff --git a/Documentation/devicetree/bindings/interconnect/qcom,msm8939.yaml b/Documentation/devicetree/bindings/interconnect/qcom,msm8939.yaml index fd15ab5014fb..3aed8b77f35d 100644 --- a/Documentation/devicetree/bindings/interconnect/qcom,msm8939.yaml +++ b/Documentation/devicetree/bindings/interconnect/qcom,msm8939.yaml @@ -56,19 +56,8 @@ examples: - | #include <dt-bindings/clock/qcom,rpmcc.h> - snoc: interconnect@580000 { - compatible = "qcom,msm8939-snoc"; - reg = <0x00580000 0x14000>; - #interconnect-cells = <1>; - }; - bimc: interconnect@400000 { compatible = "qcom,msm8939-bimc"; reg = <0x00400000 0x62000>; - #interconnect-cells = <1>; - - snoc_mm: interconnect-snoc { - compatible = "qcom,msm8939-snoc-mm"; - #interconnect-cells = <1>; - }; + #interconnect-cells = <2>; };
For now example list snoc_mm as children of bimc which is obviously not valid, drop snoc and snoc_mm and leave bimc alone. Signed-off-by: Adam Skladowski <a39.skl@gmail.com> --- .../bindings/interconnect/qcom,msm8939.yaml | 13 +------------ 1 file changed, 1 insertion(+), 12 deletions(-)