| Message ID | 20240729201843.142918-7-danila@jiaxyga.com (mailing list archive) |
|---|---|
| State | Handled Elsewhere, archived |
| Headers | show |
| Series | Add Nothing Phone (1) support | expand |
On Mon, Jul 29, 2024 at 11:18:13PM GMT, Danila Tikhonov wrote: > The SM7325 Linux Android firmware needs this workaround as well. Add it > to the list. Which one? quirk_sc8280xp enables two workardounds: one for the firmware crash on GET_PDOS command and another one for the empty PDOs being returned unless there is PD-enabled partner. > > Signed-off-by: Danila Tikhonov <danila@jiaxyga.com> > --- > drivers/usb/typec/ucsi/ucsi_glink.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/usb/typec/ucsi/ucsi_glink.c b/drivers/usb/typec/ucsi/ucsi_glink.c > index 16c328497e0b..80fb04473617 100644 > --- a/drivers/usb/typec/ucsi/ucsi_glink.c > +++ b/drivers/usb/typec/ucsi/ucsi_glink.c > @@ -294,6 +294,7 @@ static const struct of_device_id pmic_glink_ucsi_of_quirks[] = { > { .compatible = "qcom,qcm6490-pmic-glink", .data = &quirk_sc8280xp, }, > { .compatible = "qcom,sc8180x-pmic-glink", .data = &quirk_sc8180x, }, > { .compatible = "qcom,sc8280xp-pmic-glink", .data = &quirk_sc8280xp, }, > + { .compatible = "qcom,sm7325-pmic-glink", .data = &quirk_sc8280xp, }, > { .compatible = "qcom,sm8350-pmic-glink", .data = &quirk_sc8180x, }, > { .compatible = "qcom,sm8450-pmic-glink", .data = &quirk_sm8450, }, > { .compatible = "qcom,sm8550-pmic-glink", .data = &quirk_sm8450, }, > -- > 2.45.2 >
On 29/07/2024 22:18, Danila Tikhonov wrote: > The SM7325 Linux Android firmware needs this workaround as well. Add it > to the list. > > Signed-off-by: Danila Tikhonov <danila@jiaxyga.com> > --- > drivers/usb/typec/ucsi/ucsi_glink.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/usb/typec/ucsi/ucsi_glink.c b/drivers/usb/typec/ucsi/ucsi_glink.c > index 16c328497e0b..80fb04473617 100644 > --- a/drivers/usb/typec/ucsi/ucsi_glink.c > +++ b/drivers/usb/typec/ucsi/ucsi_glink.c > @@ -294,6 +294,7 @@ static const struct of_device_id pmic_glink_ucsi_of_quirks[] = { > { .compatible = "qcom,qcm6490-pmic-glink", .data = &quirk_sc8280xp, }, > { .compatible = "qcom,sc8180x-pmic-glink", .data = &quirk_sc8180x, }, > { .compatible = "qcom,sc8280xp-pmic-glink", .data = &quirk_sc8280xp, }, > + { .compatible = "qcom,sm7325-pmic-glink", .data = &quirk_sc8280xp, }, Let's don't grow any of such lists without need. Use proper fallbacks, if that's applicable. Best regards, Krzysztof
diff --git a/drivers/usb/typec/ucsi/ucsi_glink.c b/drivers/usb/typec/ucsi/ucsi_glink.c index 16c328497e0b..80fb04473617 100644 --- a/drivers/usb/typec/ucsi/ucsi_glink.c +++ b/drivers/usb/typec/ucsi/ucsi_glink.c @@ -294,6 +294,7 @@ static const struct of_device_id pmic_glink_ucsi_of_quirks[] = { { .compatible = "qcom,qcm6490-pmic-glink", .data = &quirk_sc8280xp, }, { .compatible = "qcom,sc8180x-pmic-glink", .data = &quirk_sc8180x, }, { .compatible = "qcom,sc8280xp-pmic-glink", .data = &quirk_sc8280xp, }, + { .compatible = "qcom,sm7325-pmic-glink", .data = &quirk_sc8280xp, }, { .compatible = "qcom,sm8350-pmic-glink", .data = &quirk_sc8180x, }, { .compatible = "qcom,sm8450-pmic-glink", .data = &quirk_sm8450, }, { .compatible = "qcom,sm8550-pmic-glink", .data = &quirk_sm8450, },
The SM7325 Linux Android firmware needs this workaround as well. Add it to the list. Signed-off-by: Danila Tikhonov <danila@jiaxyga.com> --- drivers/usb/typec/ucsi/ucsi_glink.c | 1 + 1 file changed, 1 insertion(+)