| Message ID | 20240731191312.1710417-11-robh@kernel.org (mailing list archive) |
|---|---|
| State | New |
| Delegated to: | Chanwoo Choi |
| Headers | show |
| Series | devfreq: imx-bus: Use of_property_present() | expand |
> Subject: [PATCH] devfreq: imx-bus: Use of_property_present() > > Use of_property_present() to test for property presence rather than > of_get_property(). This is part of a larger effort to remove callers of > of_get_property() and similar functions. of_get_property() leaks the DT > property data pointer which is a problem for dynamically allocated > nodes which may be freed. > > Signed-off-by: Rob Herring (Arm) <robh@kernel.org> Acked-by: Peng Fan <peng.fan@nxp.com>
On Wed, Jul 31, 2024 at 2:13 PM Rob Herring (Arm) <robh@kernel.org> wrote: > > Use of_property_present() to test for property presence rather than > of_get_property(). This is part of a larger effort to remove callers > of of_get_property() and similar functions. of_get_property() leaks > the DT property data pointer which is a problem for dynamically > allocated nodes which may be freed. > > Signed-off-by: Rob Herring (Arm) <robh@kernel.org> > --- > drivers/devfreq/imx-bus.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Ping! > > diff --git a/drivers/devfreq/imx-bus.c b/drivers/devfreq/imx-bus.c > index 86850b7dea09..49798f542d68 100644 > --- a/drivers/devfreq/imx-bus.c > +++ b/drivers/devfreq/imx-bus.c > @@ -59,7 +59,7 @@ static int imx_bus_init_icc(struct device *dev) > struct imx_bus *priv = dev_get_drvdata(dev); > const char *icc_driver_name; > > - if (!of_get_property(dev->of_node, "#interconnect-cells", NULL)) > + if (!of_property_present(dev->of_node, "#interconnect-cells")) > return 0; > if (!IS_ENABLED(CONFIG_INTERCONNECT_IMX)) { > dev_warn(dev, "imx interconnect drivers disabled\n"); > -- > 2.43.0 >
24. 8. 1. 04:12에 Rob Herring (Arm) 이(가) 쓴 글: > Use of_property_present() to test for property presence rather than > of_get_property(). This is part of a larger effort to remove callers > of of_get_property() and similar functions. of_get_property() leaks > the DT property data pointer which is a problem for dynamically > allocated nodes which may be freed. > > Signed-off-by: Rob Herring (Arm) <robh@kernel.org> > --- > drivers/devfreq/imx-bus.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/devfreq/imx-bus.c b/drivers/devfreq/imx-bus.c > index 86850b7dea09..49798f542d68 100644 > --- a/drivers/devfreq/imx-bus.c > +++ b/drivers/devfreq/imx-bus.c > @@ -59,7 +59,7 @@ static int imx_bus_init_icc(struct device *dev) > struct imx_bus *priv = dev_get_drvdata(dev); > const char *icc_driver_name; > > - if (!of_get_property(dev->of_node, "#interconnect-cells", NULL)) > + if (!of_property_present(dev->of_node, "#interconnect-cells")) > return 0; > if (!IS_ENABLED(CONFIG_INTERCONNECT_IMX)) { > dev_warn(dev, "imx interconnect drivers disabled\n"); I'm sorry for late reply. Applied it.
diff --git a/drivers/devfreq/imx-bus.c b/drivers/devfreq/imx-bus.c index 86850b7dea09..49798f542d68 100644 --- a/drivers/devfreq/imx-bus.c +++ b/drivers/devfreq/imx-bus.c @@ -59,7 +59,7 @@ static int imx_bus_init_icc(struct device *dev) struct imx_bus *priv = dev_get_drvdata(dev); const char *icc_driver_name; - if (!of_get_property(dev->of_node, "#interconnect-cells", NULL)) + if (!of_property_present(dev->of_node, "#interconnect-cells")) return 0; if (!IS_ENABLED(CONFIG_INTERCONNECT_IMX)) { dev_warn(dev, "imx interconnect drivers disabled\n");
Use of_property_present() to test for property presence rather than of_get_property(). This is part of a larger effort to remove callers of of_get_property() and similar functions. of_get_property() leaks the DT property data pointer which is a problem for dynamically allocated nodes which may be freed. Signed-off-by: Rob Herring (Arm) <robh@kernel.org> --- drivers/devfreq/imx-bus.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)