| Message ID | 20240808123651.3741-1-Dhananjay.Ugwekar@amd.com (mailing list archive) |
|---|---|
| State | Superseded, archived |
| Headers | show |
| Series | [v2] cpufreq/amd-pstate: Add the missing cpufreq_cpu_put() | expand |
On 08-08-24, 12:36, Dhananjay Ugwekar wrote: > Fix the reference counting of cpufreq_policy object in amd_pstate_update() > function by adding the missing cpufreq_cpu_put(). > > Fixes: e8f555daacd3 ("cpufreq/amd-pstate: fix setting policy current frequency value") > Signed-off-by: Dhananjay Ugwekar <Dhananjay.Ugwekar@amd.com> > Reviewed-by: Perry Yuan <perry.yuan@amd.com> > --- > drivers/cpufreq/amd-pstate.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c > index 804fab4ebb26..36edae40db1a 100644 > --- a/drivers/cpufreq/amd-pstate.c > +++ b/drivers/cpufreq/amd-pstate.c > @@ -560,6 +560,8 @@ static void amd_pstate_update(struct amd_cpudata *cpudata, u32 min_perf, > > amd_pstate_update_perf(cpudata, min_perf, des_perf, > max_perf, fast_switch); > + > + cpufreq_cpu_put(policy); There is an early return path in this routine, which still doesn't perform this action.
On 8/9/2024 10:44 AM, Viresh Kumar wrote: > On 08-08-24, 12:36, Dhananjay Ugwekar wrote: >> Fix the reference counting of cpufreq_policy object in amd_pstate_update() >> function by adding the missing cpufreq_cpu_put(). >> >> Fixes: e8f555daacd3 ("cpufreq/amd-pstate: fix setting policy current frequency value") >> Signed-off-by: Dhananjay Ugwekar <Dhananjay.Ugwekar@amd.com> >> Reviewed-by: Perry Yuan <perry.yuan@amd.com> >> --- >> drivers/cpufreq/amd-pstate.c | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c >> index 804fab4ebb26..36edae40db1a 100644 >> --- a/drivers/cpufreq/amd-pstate.c >> +++ b/drivers/cpufreq/amd-pstate.c >> @@ -560,6 +560,8 @@ static void amd_pstate_update(struct amd_cpudata *cpudata, u32 min_perf, >> >> amd_pstate_update_perf(cpudata, min_perf, des_perf, >> max_perf, fast_switch); >> + >> + cpufreq_cpu_put(policy); > > There is an early return path in this routine, which still doesn't > perform this action. Thanks for catching this, will fix in next version Regards, Dhananjay >
diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c index 804fab4ebb26..36edae40db1a 100644 --- a/drivers/cpufreq/amd-pstate.c +++ b/drivers/cpufreq/amd-pstate.c @@ -560,6 +560,8 @@ static void amd_pstate_update(struct amd_cpudata *cpudata, u32 min_perf, amd_pstate_update_perf(cpudata, min_perf, des_perf, max_perf, fast_switch); + + cpufreq_cpu_put(policy); } static int amd_pstate_verify(struct cpufreq_policy_data *policy)
Fix the reference counting of cpufreq_policy object in amd_pstate_update() function by adding the missing cpufreq_cpu_put(). Fixes: e8f555daacd3 ("cpufreq/amd-pstate: fix setting policy current frequency value") Signed-off-by: Dhananjay Ugwekar <Dhananjay.Ugwekar@amd.com> Reviewed-by: Perry Yuan <perry.yuan@amd.com> --- drivers/cpufreq/amd-pstate.c | 2 ++ 1 file changed, 2 insertions(+)