diff mbox series

[4/4] sched/cpufreq: Use NSEC_PER_MSEC for deadline task

Message ID 20240813144348.1180344-5-christian.loehle@arm.com (mailing list archive)
State Handled Elsewhere, archived
Headers show
Series sched/deadline: nanoseconds clarifications | expand

Commit Message

Christian Loehle Aug. 13, 2024, 2:43 p.m. UTC 
Convert the sugov deadline task attributes to use the available
definitions to make them more readable.
No functional change.

Signed-off-by: Christian Loehle <christian.loehle@arm.com>
---
 kernel/sched/cpufreq_schedutil.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Comments

Vincent Guittot Sept. 9, 2024, 1:38 p.m. UTC | #1 
On Tue, 13 Aug 2024 at 16:44, Christian Loehle <christian.loehle@arm.com> wrote:
>
> Convert the sugov deadline task attributes to use the available
> definitions to make them more readable.
> No functional change.
>
> Signed-off-by: Christian Loehle <christian.loehle@arm.com>

I missed this new version and your ping to Peter brought it back to visibility

Reviewed-by Vincent Guittot <vincent.guittot@linaro.org>

> ---
>  kernel/sched/cpufreq_schedutil.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/kernel/sched/cpufreq_schedutil.c b/kernel/sched/cpufreq_schedutil.c
> index eece6244f9d2..43111a515a28 100644
> --- a/kernel/sched/cpufreq_schedutil.c
> +++ b/kernel/sched/cpufreq_schedutil.c
> @@ -654,9 +654,9 @@ static int sugov_kthread_create(struct sugov_policy *sg_policy)
>                  * Fake (unused) bandwidth; workaround to "fix"
>                  * priority inheritance.
>                  */
> -               .sched_runtime  =  1000000,
> -               .sched_deadline = 10000000,
> -               .sched_period   = 10000000,
> +               .sched_runtime  = NSEC_PER_MSEC,
> +               .sched_deadline = 10 * NSEC_PER_MSEC,
> +               .sched_period   = 10 * NSEC_PER_MSEC,
>         };
>         struct cpufreq_policy *policy = sg_policy->policy;
>         int ret;
> --
> 2.34.1
>
diff mbox series

Patch

diff --git a/kernel/sched/cpufreq_schedutil.c b/kernel/sched/cpufreq_schedutil.c
index eece6244f9d2..43111a515a28 100644
--- a/kernel/sched/cpufreq_schedutil.c
+++ b/kernel/sched/cpufreq_schedutil.c
@@ -654,9 +654,9 @@  static int sugov_kthread_create(struct sugov_policy *sg_policy)
 		 * Fake (unused) bandwidth; workaround to "fix"
 		 * priority inheritance.
 		 */
-		.sched_runtime	=  1000000,
-		.sched_deadline = 10000000,
-		.sched_period	= 10000000,
+		.sched_runtime	= NSEC_PER_MSEC,
+		.sched_deadline = 10 * NSEC_PER_MSEC,
+		.sched_period	= 10 * NSEC_PER_MSEC,
 	};
 	struct cpufreq_policy *policy = sg_policy->policy;
 	int ret;