| Message ID | 20240830113206.5427-1-shenlichuan@vivo.com (mailing list archive) |
|---|---|
| State | Handled Elsewhere, archived |
| Headers | show |
| Series | [v1] pmdomain: bcm: Convert to use dev_err_probe() | expand |
On 30/08/2024 13:32, Shen Lichuan wrote: > Use dev_err_probe() to simplify the error path and unify a message > template. > > Using this helper is totally fine even if err is known to never > be -EPROBE_DEFER. > > The benefit compared to a normal dev_err() is the standardized format > of the error code, it being emitted symbolically and the fact that > the error code is returned which allows more compact error paths. > > Signed-off-by: Shen Lichuan <shenlichuan@vivo.com> > --- > drivers/pmdomain/bcm/bcm-pmb.c | 6 ++---- Ulf, Since ~2 weeks there is tremendous amount of trivial patches coming from vivo.com. I identified at least 6 buggy, where the contributor did not understand the code. Not sure about intention, but I advise extra carefulness when dealing with these "trivial" improvements (because we tend to apply things which look trivial). Best regards, Krzysztof
diff --git a/drivers/pmdomain/bcm/bcm-pmb.c b/drivers/pmdomain/bcm/bcm-pmb.c index a72ba26ecf9d..ffd08f13d9ef 100644 --- a/drivers/pmdomain/bcm/bcm-pmb.c +++ b/drivers/pmdomain/bcm/bcm-pmb.c @@ -325,10 +325,8 @@ static int bcm_pmb_probe(struct platform_device *pdev) } err = of_genpd_add_provider_onecell(dev->of_node, &pmb->genpd_onecell_data); - if (err) { - dev_err(dev, "failed to add genpd provider: %d\n", err); - return err; - } + if (err) + return dev_err_probe(dev, err, "failed to add genpd provider\n"); return 0; }
Use dev_err_probe() to simplify the error path and unify a message template. Using this helper is totally fine even if err is known to never be -EPROBE_DEFER. The benefit compared to a normal dev_err() is the standardized format of the error code, it being emitted symbolically and the fact that the error code is returned which allows more compact error paths. Signed-off-by: Shen Lichuan <shenlichuan@vivo.com> --- drivers/pmdomain/bcm/bcm-pmb.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)