From patchwork Thu Sep 19 12:08:11 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Peng Fan (OSS)" X-Patchwork-Id: 13807665 X-Patchwork-Delegate: shuah@kernel.org Received: from AS8PR04CU009.outbound.protection.outlook.com (mail-westeuropeazon11011063.outbound.protection.outlook.com [52.101.70.63]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 18E0019D09D; Thu, 19 Sep 2024 11:59:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.70.63 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726747174; cv=fail; b=YATdJou7lke1/BP66rU9LNuNmN8BpzpvFZe5UvLzHdejwiMLFYjKRR0BmbdqFhpUjDfKkgHSBh3VENUt6oT5ryGWMwYxpXQz2ODMdVIHXOABZc24Vd7ZdUH4qoRlYKpIMamKSQgoxTbgHLZKj+ObOzQF47Nx3bi+Vb4NObHskfg= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726747174; c=relaxed/simple; bh=3VRxKJ9AMVkG43bNRts67mg0uY8nlScY7CMHWgVbMXA=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=uBtIqlk5nmnarRZL+9xdkin677H1Z7zVz+MAtQurgnXCKErGNVDEY16VX7D/CKcvym1/MhhYTOowUPomuma6MEG67y5vD51nPfo3381w37n3To+i/A/ZvJM/F5kdLD/fF8pW1mVg43jIQwSMK5DG5dtu9YgWbgVnwWhTXh3tXqA= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com; spf=pass smtp.mailfrom=oss.nxp.com; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b=pM9g5HgT; arc=fail smtp.client-ip=52.101.70.63 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b="pM9g5HgT" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=yum9+6JNBxBb5Nq0f3ZLTuCrSkYyutVViRuyPDHOisoUlppF0TEdy6VqGZgBBnBCK5pfeyen1n8ZZwoKB0cH63RtqkU/VZqCjOLini1GK+iHUe4vdmMxnaU/aEHNmINdYYN19KmzNJImPtVA4ndDCDDZuf+Ha1tyVqJ908zt7oaqgB0HPKgF4IpxUBVtWb51V2sA6zOmupCTjakoJVM4SzdU2TetKCtI/nW8SAu+yx8zSgN3XyjqC9JtgznuC6SChFWm/Ru0DrblGpfnyiGMtgoDhx8awGVt1TKxV8SjK5ysaF0OjXsFNTbW8LnaHR6d4ot27H2JoPVERR2gsPSzfQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tBG1dMtRDe83S2s/baUmpREnYT11PE2POSs8F04B+2A=; b=tvVqGeG0gCTHbNLNH1gA4oVLMxqM/Fm7xjnWIumkbo2mWwJVWzIZhIGT1wz/9euMFVN6cc/R10KcwhZyDfqLhJH3ZA90h7YBv4lmfZn7u20MTHcxp3F6T9DxfSeXbOGD7VSPZfVF5AVqB3MlSV8rP1oKzOO4ONF2r8vPaQRUTX6UOFpKxpO5WGY+9H+wcpcIOj2hiZpem45tlGoIPFji0E5k31fq72hWx8TEWFdXQG2QQnFmbNBnUY2johj8LqVqM5gP9tJm5opcpw0HJ6uZJ8DoXAbDO/uFOG+/PMxgSMY4pxR2c85PKCUInR2TbrRhEH1FCfPX1ziNYWLx33VHYA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector1-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tBG1dMtRDe83S2s/baUmpREnYT11PE2POSs8F04B+2A=; b=pM9g5HgTk1JN2cU9VidK0uCmuffUbm9O6OsWv+laQcozM4Np6lkScH0Pf7qCQJ9Ww8S8XxjdNJFlkMKwJR9AAlGyehp4cEmZOFhNEYf9GU8trtJknZ8/6VYC9F1uAjV1l6c8/HqDZN1985DNfkJY6tzS4/OBpLBpCUWgsqFyEimGhurh4ZE/qtVUiXsnYSglWdEbOKDWi5UGV0xQiYIKKegz5a87/ThJnMkUA4oD9ZThPiB/h3JGC8UMgjNuNnOvMjqxjKMLzM492uuxYXj9m468eNtvenqM/vj6vmsfJ2k+GaKORpLaD4NNtgO8B384OaQNzLC6KfRV7OVMoFAkHQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) by DBBPR04MB8041.eurprd04.prod.outlook.com (2603:10a6:10:1e2::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7982.21; Thu, 19 Sep 2024 11:59:29 +0000 Received: from PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630]) by PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630%6]) with mapi id 15.20.7982.018; Thu, 19 Sep 2024 11:59:29 +0000 From: "Peng Fan (OSS)" Date: Thu, 19 Sep 2024 20:08:11 +0800 Subject: [PATCH v2 1/2] pm: cpupower: bench: print config file path when open cpufreq-bench.conf fails Message-Id: <20240919-pm-v2-1-0f25686556b5@nxp.com> References: <20240919-pm-v2-0-0f25686556b5@nxp.com> In-Reply-To: <20240919-pm-v2-0-0f25686556b5@nxp.com> To: Thomas Renninger , Shuah Khan , "John B. Wyatt IV" , John Kacur Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Peng Fan X-Mailer: b4 0.14.1 X-Developer-Signature: v=1; a=ed25519-sha256; t=1726747701; l=1089; i=peng.fan@nxp.com; s=20230812; h=from:subject:message-id; bh=2pxOMW3LybW9Th81wVWF0biaYjFBiO8zFnKPhpofG5A=; b=PIgXQ4U9bYymafhhVsi5sj9lSnPebIElhegRrkKDh79RrUg8YrY9jfCzgFqEOauX4IroZPrnE TUQWr7Pv6J6Aes823l/CIBUWxWoHIab9AvnO7iWjHLO4Wco8mRvvzVi X-Developer-Key: i=peng.fan@nxp.com; a=ed25519; pk=I4sJg7atIT1g63H7bb5lDRGR2gJW14RKDD0wFL8TT1g= X-ClientProxiedBy: SI1PR02CA0019.apcprd02.prod.outlook.com (2603:1096:4:1f4::15) To PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) Precedence: bulk X-Mailing-List: linux-pm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB8459:EE_|DBBPR04MB8041:EE_ X-MS-Office365-Filtering-Correlation-Id: 5edb2788-5a48-426a-4c08-08dcd8a28433 X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|52116014|1800799024|376014|38350700014; X-Microsoft-Antispam-Message-Info: =?utf-8?q?h8WZ0SkEm5gPvNRyzE3u7/1Jqpm5Yg9?= =?utf-8?q?c0kf+nUJCbLkOZI48szjv3Ku0t2RBIuGCJBHZdKct8PlAuQpOTUIlYInRZbNteXTs?= =?utf-8?q?LkU5P/yWW0Ucntv4AFLNLWjLIvRF2P4a9amZcOLR+L1nc/byEJCs2FIhHcRZiCVzn?= =?utf-8?q?u8nEFB6lp863OWjGccmyh6QH/l7YFymsh610Azkz7T0fIxSRHh2QhIYib75NpGHj4?= =?utf-8?q?u410J2L2n6Ma4nTczyGHfuPoJQOgLi25PYbd4j8OZIEa9aJu2uHgEi1D009edhZDR?= =?utf-8?q?cgkWn1+ANQEgNFXgcoKi+LXYMofAHllG8+BtrIOcazSyjE59+UQmWLZLTrbKGoTQ5?= =?utf-8?q?csS2p3lXkH2eoAYG0SYX9i1Y3Svj+W0ZX05FaI0GbgsAHpNCRFP/uu9GzRXD9MeZD?= =?utf-8?q?HFrz4N21eSyEL1uDzUkE3S3pYdHsfeVVAarC4JSVdzrvB4JFKtXrSCQNQFos3yTvf?= =?utf-8?q?c+7JaXLihApuAb/oEwzezGXuhHL2vIPSaq+Q4RiId1lW/mICCjw3n4ru/BJ4Ax9kC?= =?utf-8?q?27Lq74MgZlF6euFVdtDy6ZtrfSzW0XapUaxoolA4nZlMFrduLv+Qp2x0PQfJ8EsAN?= =?utf-8?q?HilpM7tv/JesXoVVqSgP/gnPMkXJYoxr6w2VVPg/11TNrFC4fgJxqC35VfXjyCBgP?= =?utf-8?q?V35gu6iMYlRTX3NMXegaGvmu28522VcOaiENEGKEQMyZMo/igxTInTIPfnhf1WY4+?= =?utf-8?q?O+aApVmuqt7kKjm+mG23qBtF7EjyGvIWurhLEq6nWhawGMTa2Ppf3oVFlVLMPbwDF?= =?utf-8?q?GLM3ZSGQN5iTmV1nRyTps2bBwyhE2aBzhdLuIodHgVSIRAUdu8jcdvrZVEBkEjLMx?= =?utf-8?q?SQtPT9mI5hLnchigY2gy+6B/LriSHPNh6P3GWzwWIYxkKlz0Pg6UAa8mxcUqbvFOS?= =?utf-8?q?BNXSX1lcq2F2ADbMPie8whTcaAASPugnRtCXq+dwZUtFMV1cUiLLZw0IIr1FfVKe9?= =?utf-8?q?dPFqn354HcNJAEjFOromMaxRKScUWTxD5qOULCAEf1XZZxbIbFIbhx8ttHxON96CF?= =?utf-8?q?P1WRF0O7GsiDEzxv/hnUw+LJ6HYPsCQYnt9gYrMi2/GbeaZ3eStH2M3g7dcGrPT7v?= =?utf-8?q?T3DJX0UC7URDkUa//Lly6Moq9fI5OtbwfxrL1ovb8Wu00DJ821OqX6zuijLQpkFUx?= =?utf-8?q?g5d+cCCL0MZrJS6OMDdfeXucojhdOODd3v6ye9dOhSXzzV5+otN3Z8UrQwB2MYqNb?= =?utf-8?q?/yf7SrNcTu1cNQobmWOTYzb0GjxK+bCk4pJM+migCWCZtq6vjeIKO3HOjK6ouMh/L?= =?utf-8?q?aIZr2Varanv2c83f6in8rIFIOTSkQJPnsQ2CMwVmTtPlIKC/XaDRHVPTi5zgM6qR+?= =?utf-8?q?lKEVBd46XVSu46UX80VeSqYqX0q7iPTS6A=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB8459.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(52116014)(1800799024)(376014)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?1tY9/TNXI4Hyxyu9oUPLVLNNBzY3?= =?utf-8?q?MvrNFkS36CkGorIcoaVNm3F30Gh8aEWjb3v/iu2gfefcyKiiyHMyDqhUvHD+AEdOs?= =?utf-8?q?V1GXxOZv3T952l+0CglxnKuy7i9j4DYBJwOqqle7nDlbE1opVOqrqJ7vdSSlfb9sU?= =?utf-8?q?nhESMMmJJIE/6fvMW3+O+iZedIWxWiZi3aibLgZkZeGgHWo+oPVSm18lJhnWoyuIX?= =?utf-8?q?/H6KA50b4u+cJgkEQrm5lUg1NK0mp46+nAlKwd0MNMEK44ihwB0Hhf5EJblgpKriN?= =?utf-8?q?BP0DkoVnWtnncW+B/xw8NDcdmyacrlMQv/aij/H5yxA1oMTqxZRPiaihjhHn7CQ2x?= =?utf-8?q?rCNVpI+qNmvXMnRgPNktc9PIPABEiIoxV5iGQJVrBWJVVHfFsZDnHrLgw02gsX1J2?= =?utf-8?q?asa8ZUDeuIr3n6DnBuEf1lr1ffclTksyFGFCGchFwrSmI7S+V/CM/4kqT2l2EgDgT?= =?utf-8?q?wU+plkgoL0J4oob7r649zWn59Wju3qPEXl/bVCeKos/l0DptDp50jvLhpRavavRnw?= =?utf-8?q?QtHR+vtlglmQj7N5cK6DvniMij6LzdokQvUta64UiGUK0zXuXWfEtQ3yhbRiMg0O+?= =?utf-8?q?JCPoyzKXpg1WBqI2Ite25KA8t4AZaivo3nRXufjRWM7qgir8/KRZdTX8okD5nCCFH?= =?utf-8?q?Dg0oOFbq2N0rixY6dbntpuqFgrYqZOZGBmXrbW2H2FoodmDOHe+pO+4In2VqPxSU4?= =?utf-8?q?I+fEjdsnfguFg20xRE88jNTIF0VcaBy/yVVQSp2W7r5i/YpPIUaY8uPypAJM/Tw3z?= =?utf-8?q?Zr+Iwx+v+of28YiZmhaSuOm0FLuQgAIaSGkMgDt2KPa8HI5nepNEQZBzMxqvkaXOE?= =?utf-8?q?nYYOTt4eFo6+9deXQVEmcOTSThNVTHFdZsvRMESZ/jH81VXA8n0GDf7dvnQj+tYPm?= =?utf-8?q?bLdFj48w6lvFhISFDbi8c9bTsYSv1Bcx1o0pegiLaoHv3+dnJYjsKlhZQarGGI69d?= =?utf-8?q?/BQNQCkR6WXjl7BzQhVCjy/KhYYvlaFjzhfF2TwVVEtDSkHFELKSgvGt7lm80GXkJ?= =?utf-8?q?hPuFbTwphwhzo67m3aXOhMY6h0EdnloJV/TsKB+tklDnbuhE44HlmxwoJGOTK+jE/?= =?utf-8?q?kwYm9w7N8mIU5Bqx71d4Ys7lLdt3QeMEeYoi3lbbz/CsSHjxIxi1Zx8DNusa2FNbY?= =?utf-8?q?E/8FmPHoIp951kasFzHvLAh0ainOvpIq/vKJBdlIUwK45Rnkp8KH99u2vcwsYOREg?= =?utf-8?q?d4qIxIG11LETl5BSMUvBEvmdcuNXnXZ/bmlqEPWD7VxTk20XI9DQlw8SfmE6SYlR5?= =?utf-8?q?RcpJMUkXkZPcrl7GjeBOvp7eRJewYCX/F8nuDJklTesPzDgKo7q01Yi/6RTVM0kJO?= =?utf-8?q?pBcAg2IYuU3ExwEwapdJ3yszQnIJCS8kg1ffqSev741Tn4ZAdRS7YJ/mtrGO5QvW2?= =?utf-8?q?o9x6H1BVzEx4u8mLzo6Sr6mEzd5G2A94oYuVtPXnldLqC0KHOF06V18k3Pa3u1mI3?= =?utf-8?q?PyDH2o9TnjfB1JYQcXHuuNK7uSBxHI5+64A/jwX8vZ/ekDkxHJLyW4DEqWy6YO1tK?= =?utf-8?q?+V9F5UI4t1Xx?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5edb2788-5a48-426a-4c08-08dcd8a28433 X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB8459.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Sep 2024 11:59:29.5526 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: fvVd+1P0g2d60TgweuP24oUvSqrg+0MH/cUC4soymrWujwwzLdENe0SDiVnWFAuw4vzhgeSDxq4HdYILG3zF/w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR04MB8041 From: Peng Fan Print out the config file path when fopen failed. It will be easy for users to know where to create the file. Since we are here, use strerror to drop the usage of perror. Signed-off-by: Peng Fan --- tools/power/cpupower/bench/parse.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/tools/power/cpupower/bench/parse.c b/tools/power/cpupower/bench/parse.c index e63dc11fa3a5..080678d9d74e 100644 --- a/tools/power/cpupower/bench/parse.c +++ b/tools/power/cpupower/bench/parse.c @@ -4,6 +4,7 @@ * Copyright (C) 2008 Christian Kornacker */ +#include #include #include #include @@ -165,8 +166,8 @@ int prepare_config(const char *path, struct config *config) configfile = fopen(path, "r"); if (configfile == NULL) { - perror("fopen"); - fprintf(stderr, "error: unable to read configfile\n"); + fprintf(stderr, "error: unable to read configfile: %s, %s\n", + path, strerror(errno)); free(config); return 1; }