| Message ID | 20240919082809.174589-6-d-gole@ti.com (mailing list archive) |
|---|---|
| State | Handled Elsewhere, archived |
| Headers | show |
| Series | ti: k3-am62{a,p}x-sk: add opp frequencies | expand |
On 9/19/24 3:28 AM, Dhruva Gole wrote: > Add another entry in the wkup_conf for the syscon node, and then use > that for the syscon in opp-table. > > Marking entire wkup_conf as "syscon", "simple-mfd" is wrong and needs to > be addressed similar to how other child-nodes in wkup_conf are implemented > in the same file. > > Signed-off-by: Dhruva Gole <d-gole@ti.com> > --- > > **DEPENDS ON:** PATCH 6/6: cpufreq: ti-cpufreq: Update the efuse/rev offsets > > Link to v1: https://lore.kernel.org/all/20240902093222.2828345-2-d-gole@ti.com/ > No changes, just combined it as part of Bryan's AM62A and AM62P series > and sending it all together. > > --- > arch/arm64/boot/dts/ti/k3-am62-wakeup.dtsi | 7 ++++++- > arch/arm64/boot/dts/ti/k3-am625.dtsi | 2 +- > 2 files changed, 7 insertions(+), 2 deletions(-) > > diff --git a/arch/arm64/boot/dts/ti/k3-am62-wakeup.dtsi b/arch/arm64/boot/dts/ti/k3-am62-wakeup.dtsi > index e0afafd532a5..b2b65e31c7cf 100644 > --- a/arch/arm64/boot/dts/ti/k3-am62-wakeup.dtsi > +++ b/arch/arm64/boot/dts/ti/k3-am62-wakeup.dtsi > @@ -10,7 +10,7 @@ > &cbass_wakeup { > wkup_conf: syscon@43000000 { > bootph-all; > - compatible = "syscon", "simple-mfd"; > + compatible = "simple-bus"; This can be done in a separate patch after this one. You'll also want to change the syscon@43000000 to bus@43000000, and drop the "reg = <>;" line at the same time. Andrew > reg = <0x00 0x43000000 0x00 0x20000>; > #address-cells = <1>; > #size-cells = <1>; > @@ -22,6 +22,11 @@ chipid: chipid@14 { > reg = <0x14 0x4>; > }; > > + opp_efuse_table: syscon@18 { > + compatible = "ti,am62-opp-efuse-table", "syscon"; > + reg = <0x18 0x4>; > + }; > + > cpsw_mac_syscon: ethernet-mac-syscon@200 { > compatible = "ti,am62p-cpsw-mac-efuse", "syscon"; > reg = <0x200 0x8>; > diff --git a/arch/arm64/boot/dts/ti/k3-am625.dtsi b/arch/arm64/boot/dts/ti/k3-am625.dtsi > index c3d1db47dc9f..c249883a8a8d 100644 > --- a/arch/arm64/boot/dts/ti/k3-am625.dtsi > +++ b/arch/arm64/boot/dts/ti/k3-am625.dtsi > @@ -108,7 +108,7 @@ cpu3: cpu@3 { > a53_opp_table: opp-table { > compatible = "operating-points-v2-ti-cpu"; > opp-shared; > - syscon = <&wkup_conf>; > + syscon = <&opp_efuse_table>; > > opp-200000000 { > opp-hz = /bits/ 64 <200000000>;
On Sep 19, 2024 at 11:40:31 -0500, Andrew Davis wrote: > On 9/19/24 3:28 AM, Dhruva Gole wrote: > > Add another entry in the wkup_conf for the syscon node, and then use > > that for the syscon in opp-table. > > > > Marking entire wkup_conf as "syscon", "simple-mfd" is wrong and needs to > > be addressed similar to how other child-nodes in wkup_conf are implemented > > in the same file. > > > > Signed-off-by: Dhruva Gole <d-gole@ti.com> > > --- > > > > **DEPENDS ON:** PATCH 6/6: cpufreq: ti-cpufreq: Update the efuse/rev offsets > > > > Link to v1: https://lore.kernel.org/all/20240902093222.2828345-2-d-gole@ti.com/ > > No changes, just combined it as part of Bryan's AM62A and AM62P series > > and sending it all together. > > > > --- > > arch/arm64/boot/dts/ti/k3-am62-wakeup.dtsi | 7 ++++++- > > arch/arm64/boot/dts/ti/k3-am625.dtsi | 2 +- > > 2 files changed, 7 insertions(+), 2 deletions(-) > > > > diff --git a/arch/arm64/boot/dts/ti/k3-am62-wakeup.dtsi b/arch/arm64/boot/dts/ti/k3-am62-wakeup.dtsi > > index e0afafd532a5..b2b65e31c7cf 100644 > > --- a/arch/arm64/boot/dts/ti/k3-am62-wakeup.dtsi > > +++ b/arch/arm64/boot/dts/ti/k3-am62-wakeup.dtsi > > @@ -10,7 +10,7 @@ > > &cbass_wakeup { > > wkup_conf: syscon@43000000 { > > bootph-all; > > - compatible = "syscon", "simple-mfd"; > > + compatible = "simple-bus"; > > This can be done in a separate patch after this one. You'll also > want to change the syscon@43000000 to bus@43000000, and drop the > "reg = <>;" line at the same time. > > Andrew > Sure Andrew, thanks for pointing this out. I will do this in a separate patch.
diff --git a/arch/arm64/boot/dts/ti/k3-am62-wakeup.dtsi b/arch/arm64/boot/dts/ti/k3-am62-wakeup.dtsi index e0afafd532a5..b2b65e31c7cf 100644 --- a/arch/arm64/boot/dts/ti/k3-am62-wakeup.dtsi +++ b/arch/arm64/boot/dts/ti/k3-am62-wakeup.dtsi @@ -10,7 +10,7 @@ &cbass_wakeup { wkup_conf: syscon@43000000 { bootph-all; - compatible = "syscon", "simple-mfd"; + compatible = "simple-bus"; reg = <0x00 0x43000000 0x00 0x20000>; #address-cells = <1>; #size-cells = <1>; @@ -22,6 +22,11 @@ chipid: chipid@14 { reg = <0x14 0x4>; }; + opp_efuse_table: syscon@18 { + compatible = "ti,am62-opp-efuse-table", "syscon"; + reg = <0x18 0x4>; + }; + cpsw_mac_syscon: ethernet-mac-syscon@200 { compatible = "ti,am62p-cpsw-mac-efuse", "syscon"; reg = <0x200 0x8>; diff --git a/arch/arm64/boot/dts/ti/k3-am625.dtsi b/arch/arm64/boot/dts/ti/k3-am625.dtsi index c3d1db47dc9f..c249883a8a8d 100644 --- a/arch/arm64/boot/dts/ti/k3-am625.dtsi +++ b/arch/arm64/boot/dts/ti/k3-am625.dtsi @@ -108,7 +108,7 @@ cpu3: cpu@3 { a53_opp_table: opp-table { compatible = "operating-points-v2-ti-cpu"; opp-shared; - syscon = <&wkup_conf>; + syscon = <&opp_efuse_table>; opp-200000000 { opp-hz = /bits/ 64 <200000000>;
Add another entry in the wkup_conf for the syscon node, and then use that for the syscon in opp-table. Marking entire wkup_conf as "syscon", "simple-mfd" is wrong and needs to be addressed similar to how other child-nodes in wkup_conf are implemented in the same file. Signed-off-by: Dhruva Gole <d-gole@ti.com> --- **DEPENDS ON:** PATCH 6/6: cpufreq: ti-cpufreq: Update the efuse/rev offsets Link to v1: https://lore.kernel.org/all/20240902093222.2828345-2-d-gole@ti.com/ No changes, just combined it as part of Bryan's AM62A and AM62P series and sending it all together. --- arch/arm64/boot/dts/ti/k3-am62-wakeup.dtsi | 7 ++++++- arch/arm64/boot/dts/ti/k3-am625.dtsi | 2 +- 2 files changed, 7 insertions(+), 2 deletions(-)