| Message ID | 20250120172111.3492708-4-m.wilczynski@samsung.com (mailing list archive) |
|---|---|
| State | Handled Elsewhere, archived |
| Headers | show |
| Series | [RFC,v3,01/18] dt-bindings: clock: Add VO subsystem clock controller support | expand |
On Mon, Jan 20, 2025 at 06:20:56PM +0100, Michal Wilczynski wrote: > diff --git a/MAINTAINERS b/MAINTAINERS > index 0fa7c5728f1e..c56a1fb6e02a 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -20184,6 +20184,7 @@ M: Fu Wei <wefu@redhat.com> > L: linux-riscv@lists.infradead.org > S: Maintained > T: git https://github.com/pdp7/linux.git > +F: Documentation/devicetree/bindings/firmware/thead,th1520-aon.yaml > F: Documentation/devicetree/bindings/clock/thead,th1520-clk-ap.yaml Misordered. > F: Documentation/devicetree/bindings/mailbox/thead,th1520-mbox.yaml > F: Documentation/devicetree/bindings/net/thead,th1520-gmac.yaml > @@ -20194,6 +20195,7 @@ F: drivers/mailbox/mailbox-th1520.c > F: drivers/net/ethernet/stmicro/stmmac/dwmac-thead.c > F: drivers/pinctrl/pinctrl-th1520.c > F: include/dt-bindings/clock/thead,th1520-clk-ap.h > +F: include/dt-bindings/firmware/thead,th1520-aon.h > > RNBD BLOCK DRIVERS > M: Md. Haris Iqbal <haris.iqbal@ionos.com> > diff --git a/include/dt-bindings/firmware/thead,th1520-aon.h b/include/dt-bindings/firmware/thead,th1520-aon.h > new file mode 100644 > index 000000000000..7607522289f7 > --- /dev/null > +++ b/include/dt-bindings/firmware/thead,th1520-aon.h > @@ -0,0 +1,18 @@ > +/* SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) */ > +/* > + * Copyright (C) 2022 Alibaba Group Holding Limited. > + * Copyright (c) 2024 Samsung Electronics Co., Ltd. > + * Author: Michal Wilczynski <m.wilczynski@samsung.com> > + */ > + > +#ifndef __DT_BINDINGS_AON_TH1520_H > +#define __DT_BINDINGS_AON_TH1520_H > + > +#define TH1520_AON_VDEC_PD 1 > +#define TH1520_AON_NPU_PD 2 > +#define TH1520_AON_VENC_PD 3 > +#define TH1520_AON_GPU_PD 4 > +#define TH1520_AON_DSP0_PD 5 > +#define TH1520_AON_DSP1_PD 6 I don't see these being used in the driver. Can you point me? Best regards, Krzysztof
On 1/21/25 10:52, Krzysztof Kozlowski wrote: > On Mon, Jan 20, 2025 at 06:20:56PM +0100, Michal Wilczynski wrote: >> diff --git a/MAINTAINERS b/MAINTAINERS >> index 0fa7c5728f1e..c56a1fb6e02a 100644 >> --- a/MAINTAINERS >> +++ b/MAINTAINERS >> @@ -20184,6 +20184,7 @@ M: Fu Wei <wefu@redhat.com> >> L: linux-riscv@lists.infradead.org >> S: Maintained >> T: git https://protect2.fireeye.com/v1/url?k=ea660594-8a8498c9-ea678edb-000babd9f1ba-8d70d4b62a370592&q=1&e=48951848-cf32-4505-a50e-0bcb822a20b7&u=https%3A%2F%2Fgithub.com%2Fpdp7%2Flinux.git >> +F: Documentation/devicetree/bindings/firmware/thead,th1520-aon.yaml >> F: Documentation/devicetree/bindings/clock/thead,th1520-clk-ap.yaml > > Misordered. > >> F: Documentation/devicetree/bindings/mailbox/thead,th1520-mbox.yaml >> F: Documentation/devicetree/bindings/net/thead,th1520-gmac.yaml >> @@ -20194,6 +20195,7 @@ F: drivers/mailbox/mailbox-th1520.c >> F: drivers/net/ethernet/stmicro/stmmac/dwmac-thead.c >> F: drivers/pinctrl/pinctrl-th1520.c >> F: include/dt-bindings/clock/thead,th1520-clk-ap.h >> +F: include/dt-bindings/firmware/thead,th1520-aon.h >> >> RNBD BLOCK DRIVERS >> M: Md. Haris Iqbal <haris.iqbal@ionos.com> >> diff --git a/include/dt-bindings/firmware/thead,th1520-aon.h b/include/dt-bindings/firmware/thead,th1520-aon.h >> new file mode 100644 >> index 000000000000..7607522289f7 >> --- /dev/null >> +++ b/include/dt-bindings/firmware/thead,th1520-aon.h >> @@ -0,0 +1,18 @@ >> +/* SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) */ >> +/* >> + * Copyright (C) 2022 Alibaba Group Holding Limited. >> + * Copyright (c) 2024 Samsung Electronics Co., Ltd. >> + * Author: Michal Wilczynski <m.wilczynski@samsung.com> >> + */ >> + >> +#ifndef __DT_BINDINGS_AON_TH1520_H >> +#define __DT_BINDINGS_AON_TH1520_H >> + >> +#define TH1520_AON_VDEC_PD 1 >> +#define TH1520_AON_NPU_PD 2 >> +#define TH1520_AON_VENC_PD 3 >> +#define TH1520_AON_GPU_PD 4 >> +#define TH1520_AON_DSP0_PD 5 >> +#define TH1520_AON_DSP1_PD 6 > > I don't see these being used in the driver. Can you point me? Those are used in the power-domain driver [RFC v3 05/18] pmdomain: thead: Add power-domain driver for TH1520: https://lore.kernel.org/all/20250120172111.3492708-6-m.wilczynski@samsung.com/ > > Best regards, > Krzysztof > >
On 21/01/2025 22:31, Michal Wilczynski wrote: >>> +#define TH1520_AON_VDEC_PD 1 >>> +#define TH1520_AON_NPU_PD 2 >>> +#define TH1520_AON_VENC_PD 3 >>> +#define TH1520_AON_GPU_PD 4 >>> +#define TH1520_AON_DSP0_PD 5 >>> +#define TH1520_AON_DSP1_PD 6 >> >> I don't see these being used in the driver. Can you point me? > > Those are used in the power-domain driver > [RFC v3 05/18] pmdomain: thead: Add power-domain driver for TH1520: > https://lore.kernel.org/all/20250120172111.3492708-6-m.wilczynski@samsung.com/ Then this is wrong patch and wrong filename. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/firmware/thead,th1520-aon.yaml b/Documentation/devicetree/bindings/firmware/thead,th1520-aon.yaml new file mode 100644 index 000000000000..bbc183200400 --- /dev/null +++ b/Documentation/devicetree/bindings/firmware/thead,th1520-aon.yaml @@ -0,0 +1,53 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/firmware/thead,th1520-aon.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: T-HEAD TH1520 AON (Always-On) Firmware + +description: | + The Always-On (AON) subsystem in the TH1520 SoC is responsible for managing + low-power states, system wakeup events, and power management tasks. It is + designed to operate independently in a dedicated power domain, allowing it to + remain functional even during the SoC's deep sleep states. + + At the heart of the AON subsystem is the E902, a low-power core that executes + firmware responsible for coordinating tasks such as power domain control, + clock management, and system wakeup signaling. Communication between the main + SoC and the AON subsystem is handled through a mailbox interface, which + enables message-based interactions with the AON firmware. + +maintainers: + - Michal Wilczynski <m.wilczynski@samsung.com> + +properties: + compatible: + const: thead,th1520-aon + + mboxes: + maxItems: 1 + + mbox-names: + items: + - const: aon + + "#power-domain-cells": + const: 1 + +required: + - compatible + - mboxes + - mbox-names + - "#power-domain-cells" + +additionalProperties: false + +examples: + - | + aon: aon { + compatible = "thead,th1520-aon"; + mboxes = <&mbox_910t 1>; + mbox-names = "aon"; + #power-domain-cells = <1>; + }; diff --git a/MAINTAINERS b/MAINTAINERS index 0fa7c5728f1e..c56a1fb6e02a 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -20184,6 +20184,7 @@ M: Fu Wei <wefu@redhat.com> L: linux-riscv@lists.infradead.org S: Maintained T: git https://github.com/pdp7/linux.git +F: Documentation/devicetree/bindings/firmware/thead,th1520-aon.yaml F: Documentation/devicetree/bindings/clock/thead,th1520-clk-ap.yaml F: Documentation/devicetree/bindings/mailbox/thead,th1520-mbox.yaml F: Documentation/devicetree/bindings/net/thead,th1520-gmac.yaml @@ -20194,6 +20195,7 @@ F: drivers/mailbox/mailbox-th1520.c F: drivers/net/ethernet/stmicro/stmmac/dwmac-thead.c F: drivers/pinctrl/pinctrl-th1520.c F: include/dt-bindings/clock/thead,th1520-clk-ap.h +F: include/dt-bindings/firmware/thead,th1520-aon.h RNBD BLOCK DRIVERS M: Md. Haris Iqbal <haris.iqbal@ionos.com> diff --git a/include/dt-bindings/firmware/thead,th1520-aon.h b/include/dt-bindings/firmware/thead,th1520-aon.h new file mode 100644 index 000000000000..7607522289f7 --- /dev/null +++ b/include/dt-bindings/firmware/thead,th1520-aon.h @@ -0,0 +1,18 @@ +/* SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) */ +/* + * Copyright (C) 2022 Alibaba Group Holding Limited. + * Copyright (c) 2024 Samsung Electronics Co., Ltd. + * Author: Michal Wilczynski <m.wilczynski@samsung.com> + */ + +#ifndef __DT_BINDINGS_AON_TH1520_H +#define __DT_BINDINGS_AON_TH1520_H + +#define TH1520_AON_VDEC_PD 1 +#define TH1520_AON_NPU_PD 2 +#define TH1520_AON_VENC_PD 3 +#define TH1520_AON_GPU_PD 4 +#define TH1520_AON_DSP0_PD 5 +#define TH1520_AON_DSP1_PD 6 + +#endif
The kernel communicates with the E902 core through the mailbox transport using AON firmware protocol. Add dt-bindings to document it the dt node. Signed-off-by: Michal Wilczynski <m.wilczynski@samsung.com> --- .../bindings/firmware/thead,th1520-aon.yaml | 53 +++++++++++++++++++ MAINTAINERS | 2 + .../dt-bindings/firmware/thead,th1520-aon.h | 18 +++++++ 3 files changed, 73 insertions(+) create mode 100644 Documentation/devicetree/bindings/firmware/thead,th1520-aon.yaml create mode 100644 include/dt-bindings/firmware/thead,th1520-aon.h