diff mbox series

cpufreq: Use str_enable_disable() helper

Message ID 20250207035953.2420053-1-zhenglifeng1@huawei.com (mailing list archive)
State New
Delegated to: viresh kumar
Headers show
Series cpufreq: Use str_enable_disable() helper | expand

Commit Message

zhenglifeng (A) Feb. 7, 2025, 3:59 a.m. UTC
Commit f994c1cb6c43 ("cpufreq: Use str_enable_disable()-like helpers") has
already introduced helpers from string_choices.h and replaced ternary
syntax with it. Use str_enable_disable() helper in this line to stay
consistent.

Signed-off-by: Lifeng Zheng <zhenglifeng1@huawei.com>
---
 drivers/cpufreq/cpufreq.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Viresh Kumar Feb. 7, 2025, 4:16 a.m. UTC | #1
On 07-02-25, 11:59, Lifeng Zheng wrote:
> Commit f994c1cb6c43 ("cpufreq: Use str_enable_disable()-like helpers") has
> already introduced helpers from string_choices.h and replaced ternary
> syntax with it. Use str_enable_disable() helper in this line to stay
> consistent.
> 
> Signed-off-by: Lifeng Zheng <zhenglifeng1@huawei.com>
> ---
>  drivers/cpufreq/cpufreq.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c
> index 30ffbddc7ece..a12e1da89163 100644
> --- a/drivers/cpufreq/cpufreq.c
> +++ b/drivers/cpufreq/cpufreq.c
> @@ -1578,7 +1578,7 @@ static int cpufreq_online(unsigned int cpu)
>  		if (ret) {
>  			/* If the set_boost fails, the online operation is not affected */
>  			pr_info("%s: CPU%d: Cannot %s BOOST\n", __func__, policy->cpu,
> -				policy->boost_enabled ? "enable" : "disable");
> +				str_enable_disable(policy->boost_enabled));
>  			policy->boost_enabled = !policy->boost_enabled;
>  		}
>  	}

Applied, thanks.

Rafael, I have picked this since I am carrying other boost related
changes via my series. Please let me know if you want to pick it up
for rc.
diff mbox series

Patch

diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c
index 30ffbddc7ece..a12e1da89163 100644
--- a/drivers/cpufreq/cpufreq.c
+++ b/drivers/cpufreq/cpufreq.c
@@ -1578,7 +1578,7 @@  static int cpufreq_online(unsigned int cpu)
 		if (ret) {
 			/* If the set_boost fails, the online operation is not affected */
 			pr_info("%s: CPU%d: Cannot %s BOOST\n", __func__, policy->cpu,
-				policy->boost_enabled ? "enable" : "disable");
+				str_enable_disable(policy->boost_enabled));
 			policy->boost_enabled = !policy->boost_enabled;
 		}
 	}