| Message ID | 20250207124802.165408-3-csokas.bence@prolan.hu (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | Add more devm_ functions to simplify probe path in drivers/spi/atmel-quadspi.c | expand |
On Fri, Feb 7, 2025 at 1:48 PM Bence Csókás <csokas.bence@prolan.hu> wrote: > > Add `devm_pm_runtime_set_active()` and > `devm_pm_runtime_get_noresume()` for > simplifying common use cases in drivers. > > Signed-off-by: Bence Csókás <csokas.bence@prolan.hu> So I don't like this and it is not as straightforward as it looks, but let me have a look at the entire series again and see why you think this is useful. > --- > drivers/base/power/runtime.c | 36 ++++++++++++++++++++++++++++++++++++ > include/linux/pm_runtime.h | 4 ++++ > 2 files changed, 40 insertions(+) > > diff --git a/drivers/base/power/runtime.c b/drivers/base/power/runtime.c > index 2ee45841486b..f0a6c64bec19 100644 > --- a/drivers/base/power/runtime.c > +++ b/drivers/base/power/runtime.c > @@ -1545,6 +1545,24 @@ void pm_runtime_enable(struct device *dev) > } > EXPORT_SYMBOL_GPL(pm_runtime_enable); > > +static void pm_runtime_set_suspended_action(void *data) > +{ > + pm_runtime_set_suspended(data); > +} > + > +/** > + * devm_pm_runtime_set_active - devres-enabled version of pm_runtime_set_active. > + * > + * @dev: Device to handle. > + */ > +int devm_pm_runtime_set_active(struct device *dev) > +{ > + pm_runtime_set_active(dev); > + > + return devm_add_action_or_reset(dev, pm_runtime_set_suspended_action, dev); > +} > +EXPORT_SYMBOL_GPL(devm_pm_runtime_set_active); > + > static void pm_runtime_disable_action(void *data) > { > pm_runtime_dont_use_autosuspend(data); > @@ -1567,6 +1585,24 @@ int devm_pm_runtime_enable(struct device *dev) > } > EXPORT_SYMBOL_GPL(devm_pm_runtime_enable); > > +static void pm_runtime_put_noidle_action(void *data) > +{ > + pm_runtime_put_noidle(data); > +} > + > +/** > + * devm_pm_runtime_get_noresume - devres-enabled version of pm_runtime_get_noresume. > + * > + * @dev: Device to handle. > + */ > +int devm_pm_runtime_get_noresume(struct device *dev) > +{ > + pm_runtime_get_noresume(dev); > + > + return devm_add_action_or_reset(dev, pm_runtime_put_noidle_action, dev); > +} > +EXPORT_SYMBOL_GPL(devm_pm_runtime_get_noresume); > + > /** > * pm_runtime_forbid - Block runtime PM of a device. > * @dev: Device to handle. > diff --git a/include/linux/pm_runtime.h b/include/linux/pm_runtime.h > index d39dc863f612..d7eca86150b8 100644 > --- a/include/linux/pm_runtime.h > +++ b/include/linux/pm_runtime.h > @@ -93,7 +93,9 @@ extern void pm_runtime_new_link(struct device *dev); > extern void pm_runtime_drop_link(struct device_link *link); > extern void pm_runtime_release_supplier(struct device_link *link); > > +int devm_pm_runtime_set_active(struct device *dev); > extern int devm_pm_runtime_enable(struct device *dev); > +int devm_pm_runtime_get_noresume(struct device *dev); > > /** > * pm_suspend_ignore_children - Set runtime PM behavior regarding children. > @@ -276,7 +278,9 @@ static inline void __pm_runtime_disable(struct device *dev, bool c) {} > static inline void pm_runtime_allow(struct device *dev) {} > static inline void pm_runtime_forbid(struct device *dev) {} > > +static inline int devm_pm_runtime_set_active(struct device *dev) { return 0; } > static inline int devm_pm_runtime_enable(struct device *dev) { return 0; } > +static inline int devm_pm_runtime_get_noresume(struct device *dev) { return 0; } > > static inline void pm_suspend_ignore_children(struct device *dev, bool enable) {} > static inline void pm_runtime_get_noresume(struct device *dev) {} > -- > 2.48.1 > >
Hi, On 2025. 02. 08. 12:30, Rafael J. Wysocki wrote: > On Fri, Feb 7, 2025 at 1:48 PM Bence Csókás <csokas.bence@prolan.hu> wrote: >> >> Add `devm_pm_runtime_set_active()` and >> `devm_pm_runtime_get_noresume()` for >> simplifying common use cases in drivers. >> >> Signed-off-by: Bence Csókás <csokas.bence@prolan.hu> > > So I don't like this and it is not as straightforward as it looks, but > let me have a look at the entire series again and see why you think > this is useful. What exactly don't you like? And did you have a chance to look at the rest of the series? I sent a cut-back version that should be easier to review (I took out the DMA parts): https://lore.kernel.org/linux-kernel/20250210111008.248929-1-csokas.bence@prolan.hu/ Bence
diff --git a/drivers/base/power/runtime.c b/drivers/base/power/runtime.c index 2ee45841486b..f0a6c64bec19 100644 --- a/drivers/base/power/runtime.c +++ b/drivers/base/power/runtime.c @@ -1545,6 +1545,24 @@ void pm_runtime_enable(struct device *dev) } EXPORT_SYMBOL_GPL(pm_runtime_enable); +static void pm_runtime_set_suspended_action(void *data) +{ + pm_runtime_set_suspended(data); +} + +/** + * devm_pm_runtime_set_active - devres-enabled version of pm_runtime_set_active. + * + * @dev: Device to handle. + */ +int devm_pm_runtime_set_active(struct device *dev) +{ + pm_runtime_set_active(dev); + + return devm_add_action_or_reset(dev, pm_runtime_set_suspended_action, dev); +} +EXPORT_SYMBOL_GPL(devm_pm_runtime_set_active); + static void pm_runtime_disable_action(void *data) { pm_runtime_dont_use_autosuspend(data); @@ -1567,6 +1585,24 @@ int devm_pm_runtime_enable(struct device *dev) } EXPORT_SYMBOL_GPL(devm_pm_runtime_enable); +static void pm_runtime_put_noidle_action(void *data) +{ + pm_runtime_put_noidle(data); +} + +/** + * devm_pm_runtime_get_noresume - devres-enabled version of pm_runtime_get_noresume. + * + * @dev: Device to handle. + */ +int devm_pm_runtime_get_noresume(struct device *dev) +{ + pm_runtime_get_noresume(dev); + + return devm_add_action_or_reset(dev, pm_runtime_put_noidle_action, dev); +} +EXPORT_SYMBOL_GPL(devm_pm_runtime_get_noresume); + /** * pm_runtime_forbid - Block runtime PM of a device. * @dev: Device to handle. diff --git a/include/linux/pm_runtime.h b/include/linux/pm_runtime.h index d39dc863f612..d7eca86150b8 100644 --- a/include/linux/pm_runtime.h +++ b/include/linux/pm_runtime.h @@ -93,7 +93,9 @@ extern void pm_runtime_new_link(struct device *dev); extern void pm_runtime_drop_link(struct device_link *link); extern void pm_runtime_release_supplier(struct device_link *link); +int devm_pm_runtime_set_active(struct device *dev); extern int devm_pm_runtime_enable(struct device *dev); +int devm_pm_runtime_get_noresume(struct device *dev); /** * pm_suspend_ignore_children - Set runtime PM behavior regarding children. @@ -276,7 +278,9 @@ static inline void __pm_runtime_disable(struct device *dev, bool c) {} static inline void pm_runtime_allow(struct device *dev) {} static inline void pm_runtime_forbid(struct device *dev) {} +static inline int devm_pm_runtime_set_active(struct device *dev) { return 0; } static inline int devm_pm_runtime_enable(struct device *dev) { return 0; } +static inline int devm_pm_runtime_get_noresume(struct device *dev) { return 0; } static inline void pm_suspend_ignore_children(struct device *dev, bool enable) {} static inline void pm_runtime_get_noresume(struct device *dev) {}
Add `devm_pm_runtime_set_active()` and `devm_pm_runtime_get_noresume()` for simplifying common use cases in drivers. Signed-off-by: Bence Csókás <csokas.bence@prolan.hu> --- drivers/base/power/runtime.c | 36 ++++++++++++++++++++++++++++++++++++ include/linux/pm_runtime.h | 4 ++++ 2 files changed, 40 insertions(+)