| Message ID | 20250215005244.1212285-12-superm1@kernel.org (mailing list archive) |
|---|---|
| State | Superseded, archived |
| Headers | show |
| Series | amd-pstate cleanups | expand |
On Fri, Feb 14, 2025 at 06:52:38PM -0600, Mario Limonciello wrote: > From: Mario Limonciello <mario.limonciello@amd.com> > > Bitfield masks are easier to follow and less error prone. LGTM. Reviewed-by: Gautham R. Shenoy <gautham.shenoy@amd.com> > > Reviewed-by: Dhananjay Ugwekar <dhananjay.ugwekar@amd.com> > Signed-off-by: Mario Limonciello <mario.limonciello@amd.com> > --- > v2: > * Add a comment in msr-index.h > * Pick up tag > --- > arch/x86/include/asm/msr-index.h | 20 +++++++++++--------- > arch/x86/kernel/acpi/cppc.c | 2 +- > drivers/cpufreq/amd-pstate-ut.c | 8 ++++---- > drivers/cpufreq/amd-pstate.c | 16 ++++++---------- > 4 files changed, 22 insertions(+), 24 deletions(-) > > diff --git a/arch/x86/include/asm/msr-index.h b/arch/x86/include/asm/msr-index.h > index 3eadc4d5de837..4bb87884998a0 100644 > --- a/arch/x86/include/asm/msr-index.h > +++ b/arch/x86/include/asm/msr-index.h > @@ -700,15 +700,17 @@ > #define MSR_AMD_CPPC_REQ 0xc00102b3 > #define MSR_AMD_CPPC_STATUS 0xc00102b4 > > -#define AMD_CPPC_LOWEST_PERF(x) (((x) >> 0) & 0xff) > -#define AMD_CPPC_LOWNONLIN_PERF(x) (((x) >> 8) & 0xff) > -#define AMD_CPPC_NOMINAL_PERF(x) (((x) >> 16) & 0xff) > -#define AMD_CPPC_HIGHEST_PERF(x) (((x) >> 24) & 0xff) > - > -#define AMD_CPPC_MAX_PERF(x) (((x) & 0xff) << 0) > -#define AMD_CPPC_MIN_PERF(x) (((x) & 0xff) << 8) > -#define AMD_CPPC_DES_PERF(x) (((x) & 0xff) << 16) > -#define AMD_CPPC_ENERGY_PERF_PREF(x) (((x) & 0xff) << 24) > +/* Masks for use with MSR_AMD_CPPC_CAP1 */ > +#define AMD_CPPC_LOWEST_PERF_MASK GENMASK(7, 0) > +#define AMD_CPPC_LOWNONLIN_PERF_MASK GENMASK(15, 8) > +#define AMD_CPPC_NOMINAL_PERF_MASK GENMASK(23, 16) > +#define AMD_CPPC_HIGHEST_PERF_MASK GENMASK(31, 24) > + > +/* Masks for use with MSR_AMD_CPPC_REQ */ > +#define AMD_CPPC_MAX_PERF_MASK GENMASK(7, 0) > +#define AMD_CPPC_MIN_PERF_MASK GENMASK(15, 8) > +#define AMD_CPPC_DES_PERF_MASK GENMASK(23, 16) > +#define AMD_CPPC_EPP_PERF_MASK GENMASK(31, 24) > > /* AMD Performance Counter Global Status and Control MSRs */ > #define MSR_AMD64_PERF_CNTR_GLOBAL_STATUS 0xc0000300 > diff --git a/arch/x86/kernel/acpi/cppc.c b/arch/x86/kernel/acpi/cppc.c > index f96053c305c61..77bfb846490c0 100644 > --- a/arch/x86/kernel/acpi/cppc.c > +++ b/arch/x86/kernel/acpi/cppc.c > @@ -151,7 +151,7 @@ int amd_get_highest_perf(unsigned int cpu, u32 *highest_perf) > if (ret) > goto out; > > - val = AMD_CPPC_HIGHEST_PERF(val); > + val = FIELD_GET(AMD_CPPC_HIGHEST_PERF_MASK, val); > } else { > ret = cppc_get_highest_perf(cpu, &val); > if (ret) > diff --git a/drivers/cpufreq/amd-pstate-ut.c b/drivers/cpufreq/amd-pstate-ut.c > index 9db20ac357042..067e9e325102e 100644 > --- a/drivers/cpufreq/amd-pstate-ut.c > +++ b/drivers/cpufreq/amd-pstate-ut.c > @@ -142,10 +142,10 @@ static int amd_pstate_ut_check_perf(u32 index) > return ret; > } > > - highest_perf = AMD_CPPC_HIGHEST_PERF(cap1); > - nominal_perf = AMD_CPPC_NOMINAL_PERF(cap1); > - lowest_nonlinear_perf = AMD_CPPC_LOWNONLIN_PERF(cap1); > - lowest_perf = AMD_CPPC_LOWEST_PERF(cap1); > + highest_perf = FIELD_GET(AMD_CPPC_HIGHEST_PERF_MASK, cap1); > + nominal_perf = FIELD_GET(AMD_CPPC_NOMINAL_PERF_MASK, cap1); > + lowest_nonlinear_perf = FIELD_GET(AMD_CPPC_LOWNONLIN_PERF_MASK, cap1); > + lowest_perf = FIELD_GET(AMD_CPPC_LOWEST_PERF_MASK, cap1); > } > > cur_perf = READ_ONCE(cpudata->perf); > diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c > index e5983e5c77ba2..0a7e69fd32dbf 100644 > --- a/drivers/cpufreq/amd-pstate.c > +++ b/drivers/cpufreq/amd-pstate.c > @@ -89,11 +89,6 @@ static bool cppc_enabled; > static bool amd_pstate_prefcore = true; > static struct quirk_entry *quirks; > > -#define AMD_CPPC_MAX_PERF_MASK GENMASK(7, 0) > -#define AMD_CPPC_MIN_PERF_MASK GENMASK(15, 8) > -#define AMD_CPPC_DES_PERF_MASK GENMASK(23, 16) > -#define AMD_CPPC_EPP_PERF_MASK GENMASK(31, 24) > - > /* > * AMD Energy Preference Performance (EPP) > * The EPP is used in the CCLK DPM controller to drive > @@ -439,12 +434,13 @@ static int msr_init_perf(struct amd_cpudata *cpudata) > > perf.highest_perf = numerator; > perf.max_limit_perf = numerator; > - perf.min_limit_perf = AMD_CPPC_LOWEST_PERF(cap1); > - perf.nominal_perf = AMD_CPPC_NOMINAL_PERF(cap1); > - perf.lowest_nonlinear_perf = AMD_CPPC_LOWNONLIN_PERF(cap1); > - perf.lowest_perf = AMD_CPPC_LOWEST_PERF(cap1); > + perf.min_limit_perf = FIELD_GET(AMD_CPPC_LOWEST_PERF_MASK, cap1); > + perf.nominal_perf = FIELD_GET(AMD_CPPC_NOMINAL_PERF_MASK, cap1); > + perf.lowest_nonlinear_perf = FIELD_GET(AMD_CPPC_LOWNONLIN_PERF_MASK, cap1); > + perf.lowest_perf = FIELD_GET(AMD_CPPC_LOWEST_PERF_MASK, cap1); > WRITE_ONCE(cpudata->perf, perf); > - WRITE_ONCE(cpudata->prefcore_ranking, AMD_CPPC_HIGHEST_PERF(cap1)); > + WRITE_ONCE(cpudata->prefcore_ranking, FIELD_GET(AMD_CPPC_HIGHEST_PERF_MASK, cap1)); > + > return 0; > } > > -- > 2.43.0 >
Hi Mario, kernel test robot noticed the following build errors: [auto build test ERROR on amd-pstate/linux-next] [also build test ERROR on amd-pstate/bleeding-edge] [cannot apply to rafael-pm/linux-next rafael-pm/bleeding-edge tip/x86/core linus/master v6.14-rc3 next-20250217] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Mario-Limonciello/cpufreq-amd-pstate-Show-a-warning-when-a-CPU-fails-to-setup/20250215-085903 base: https://git.kernel.org/pub/scm/linux/kernel/git/superm1/linux.git linux-next patch link: https://lore.kernel.org/r/20250215005244.1212285-12-superm1%40kernel.org patch subject: [PATCH v2 11/17] cpufreq/amd-pstate: Replace all AMD_CPPC_* macros with masks config: i386-randconfig-063-20250216 (https://download.01.org/0day-ci/archive/20250218/202502180139.g2a2yoPe-lkp@intel.com/config) compiler: clang version 19.1.3 (https://github.com/llvm/llvm-project ab51eccf88f5321e7c60591c5546b254b6afab99) reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250218/202502180139.g2a2yoPe-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp@intel.com> | Closes: https://lore.kernel.org/oe-kbuild-all/202502180139.g2a2yoPe-lkp@intel.com/ All errors (new ones prefixed by >>): >> drivers/cpufreq/amd-pstate-ut.c:145:19: error: call to undeclared function 'FIELD_GET'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration] 145 | highest_perf = FIELD_GET(AMD_CPPC_HIGHEST_PERF_MASK, cap1); | ^ 1 error generated. vim +/FIELD_GET +145 drivers/cpufreq/amd-pstate-ut.c 105 106 /* 107 * check if performance values are reasonable. 108 * highest_perf >= nominal_perf > lowest_nonlinear_perf > lowest_perf > 0 109 */ 110 static int amd_pstate_ut_check_perf(u32 index) 111 { 112 int cpu = 0, ret = 0; 113 u32 highest_perf = 0, nominal_perf = 0, lowest_nonlinear_perf = 0, lowest_perf = 0; 114 u64 cap1 = 0; 115 struct cppc_perf_caps cppc_perf; 116 struct amd_cpudata *cpudata = NULL; 117 union perf_cached cur_perf; 118 119 for_each_possible_cpu(cpu) { 120 struct cpufreq_policy *policy __free(put_cpufreq_policy) = NULL; 121 122 policy = cpufreq_cpu_get(cpu); 123 if (!policy) 124 continue; 125 cpudata = policy->driver_data; 126 127 if (get_shared_mem()) { 128 ret = cppc_get_perf_caps(cpu, &cppc_perf); 129 if (ret) { 130 pr_err("%s cppc_get_perf_caps ret=%d error!\n", __func__, ret); 131 return ret; 132 } 133 134 highest_perf = cppc_perf.highest_perf; 135 nominal_perf = cppc_perf.nominal_perf; 136 lowest_nonlinear_perf = cppc_perf.lowest_nonlinear_perf; 137 lowest_perf = cppc_perf.lowest_perf; 138 } else { 139 ret = rdmsrl_safe_on_cpu(cpu, MSR_AMD_CPPC_CAP1, &cap1); 140 if (ret) { 141 pr_err("%s read CPPC_CAP1 ret=%d error!\n", __func__, ret); 142 return ret; 143 } 144 > 145 highest_perf = FIELD_GET(AMD_CPPC_HIGHEST_PERF_MASK, cap1); 146 nominal_perf = FIELD_GET(AMD_CPPC_NOMINAL_PERF_MASK, cap1); 147 lowest_nonlinear_perf = FIELD_GET(AMD_CPPC_LOWNONLIN_PERF_MASK, cap1); 148 lowest_perf = FIELD_GET(AMD_CPPC_LOWEST_PERF_MASK, cap1); 149 } 150 151 cur_perf = READ_ONCE(cpudata->perf); 152 if (highest_perf != cur_perf.highest_perf && !cpudata->hw_prefcore) { 153 pr_err("%s cpu%d highest=%d %d highest perf doesn't match\n", 154 __func__, cpu, highest_perf, cpudata->perf.highest_perf); 155 return -EINVAL; 156 } 157 if (nominal_perf != cur_perf.nominal_perf || 158 (lowest_nonlinear_perf != cur_perf.lowest_nonlinear_perf) || 159 (lowest_perf != cur_perf.lowest_perf)) { 160 pr_err("%s cpu%d nominal=%d %d lowest_nonlinear=%d %d lowest=%d %d, they should be equal!\n", 161 __func__, cpu, nominal_perf, cpudata->perf.nominal_perf, 162 lowest_nonlinear_perf, cpudata->perf.lowest_nonlinear_perf, 163 lowest_perf, cpudata->perf.lowest_perf); 164 return -EINVAL; 165 } 166 167 if (!((highest_perf >= nominal_perf) && 168 (nominal_perf > lowest_nonlinear_perf) && 169 (lowest_nonlinear_perf >= lowest_perf) && 170 (lowest_perf > 0))) { 171 pr_err("%s cpu%d highest=%d >= nominal=%d > lowest_nonlinear=%d > lowest=%d > 0, the formula is incorrect!\n", 172 __func__, cpu, highest_perf, nominal_perf, 173 lowest_nonlinear_perf, lowest_perf); 174 return -EINVAL; 175 } 176 } 177 178 return 0; 179 } 180
diff --git a/arch/x86/include/asm/msr-index.h b/arch/x86/include/asm/msr-index.h index 3eadc4d5de837..4bb87884998a0 100644 --- a/arch/x86/include/asm/msr-index.h +++ b/arch/x86/include/asm/msr-index.h @@ -700,15 +700,17 @@ #define MSR_AMD_CPPC_REQ 0xc00102b3 #define MSR_AMD_CPPC_STATUS 0xc00102b4 -#define AMD_CPPC_LOWEST_PERF(x) (((x) >> 0) & 0xff) -#define AMD_CPPC_LOWNONLIN_PERF(x) (((x) >> 8) & 0xff) -#define AMD_CPPC_NOMINAL_PERF(x) (((x) >> 16) & 0xff) -#define AMD_CPPC_HIGHEST_PERF(x) (((x) >> 24) & 0xff) - -#define AMD_CPPC_MAX_PERF(x) (((x) & 0xff) << 0) -#define AMD_CPPC_MIN_PERF(x) (((x) & 0xff) << 8) -#define AMD_CPPC_DES_PERF(x) (((x) & 0xff) << 16) -#define AMD_CPPC_ENERGY_PERF_PREF(x) (((x) & 0xff) << 24) +/* Masks for use with MSR_AMD_CPPC_CAP1 */ +#define AMD_CPPC_LOWEST_PERF_MASK GENMASK(7, 0) +#define AMD_CPPC_LOWNONLIN_PERF_MASK GENMASK(15, 8) +#define AMD_CPPC_NOMINAL_PERF_MASK GENMASK(23, 16) +#define AMD_CPPC_HIGHEST_PERF_MASK GENMASK(31, 24) + +/* Masks for use with MSR_AMD_CPPC_REQ */ +#define AMD_CPPC_MAX_PERF_MASK GENMASK(7, 0) +#define AMD_CPPC_MIN_PERF_MASK GENMASK(15, 8) +#define AMD_CPPC_DES_PERF_MASK GENMASK(23, 16) +#define AMD_CPPC_EPP_PERF_MASK GENMASK(31, 24) /* AMD Performance Counter Global Status and Control MSRs */ #define MSR_AMD64_PERF_CNTR_GLOBAL_STATUS 0xc0000300 diff --git a/arch/x86/kernel/acpi/cppc.c b/arch/x86/kernel/acpi/cppc.c index f96053c305c61..77bfb846490c0 100644 --- a/arch/x86/kernel/acpi/cppc.c +++ b/arch/x86/kernel/acpi/cppc.c @@ -151,7 +151,7 @@ int amd_get_highest_perf(unsigned int cpu, u32 *highest_perf) if (ret) goto out; - val = AMD_CPPC_HIGHEST_PERF(val); + val = FIELD_GET(AMD_CPPC_HIGHEST_PERF_MASK, val); } else { ret = cppc_get_highest_perf(cpu, &val); if (ret) diff --git a/drivers/cpufreq/amd-pstate-ut.c b/drivers/cpufreq/amd-pstate-ut.c index 9db20ac357042..067e9e325102e 100644 --- a/drivers/cpufreq/amd-pstate-ut.c +++ b/drivers/cpufreq/amd-pstate-ut.c @@ -142,10 +142,10 @@ static int amd_pstate_ut_check_perf(u32 index) return ret; } - highest_perf = AMD_CPPC_HIGHEST_PERF(cap1); - nominal_perf = AMD_CPPC_NOMINAL_PERF(cap1); - lowest_nonlinear_perf = AMD_CPPC_LOWNONLIN_PERF(cap1); - lowest_perf = AMD_CPPC_LOWEST_PERF(cap1); + highest_perf = FIELD_GET(AMD_CPPC_HIGHEST_PERF_MASK, cap1); + nominal_perf = FIELD_GET(AMD_CPPC_NOMINAL_PERF_MASK, cap1); + lowest_nonlinear_perf = FIELD_GET(AMD_CPPC_LOWNONLIN_PERF_MASK, cap1); + lowest_perf = FIELD_GET(AMD_CPPC_LOWEST_PERF_MASK, cap1); } cur_perf = READ_ONCE(cpudata->perf); diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c index e5983e5c77ba2..0a7e69fd32dbf 100644 --- a/drivers/cpufreq/amd-pstate.c +++ b/drivers/cpufreq/amd-pstate.c @@ -89,11 +89,6 @@ static bool cppc_enabled; static bool amd_pstate_prefcore = true; static struct quirk_entry *quirks; -#define AMD_CPPC_MAX_PERF_MASK GENMASK(7, 0) -#define AMD_CPPC_MIN_PERF_MASK GENMASK(15, 8) -#define AMD_CPPC_DES_PERF_MASK GENMASK(23, 16) -#define AMD_CPPC_EPP_PERF_MASK GENMASK(31, 24) - /* * AMD Energy Preference Performance (EPP) * The EPP is used in the CCLK DPM controller to drive @@ -439,12 +434,13 @@ static int msr_init_perf(struct amd_cpudata *cpudata) perf.highest_perf = numerator; perf.max_limit_perf = numerator; - perf.min_limit_perf = AMD_CPPC_LOWEST_PERF(cap1); - perf.nominal_perf = AMD_CPPC_NOMINAL_PERF(cap1); - perf.lowest_nonlinear_perf = AMD_CPPC_LOWNONLIN_PERF(cap1); - perf.lowest_perf = AMD_CPPC_LOWEST_PERF(cap1); + perf.min_limit_perf = FIELD_GET(AMD_CPPC_LOWEST_PERF_MASK, cap1); + perf.nominal_perf = FIELD_GET(AMD_CPPC_NOMINAL_PERF_MASK, cap1); + perf.lowest_nonlinear_perf = FIELD_GET(AMD_CPPC_LOWNONLIN_PERF_MASK, cap1); + perf.lowest_perf = FIELD_GET(AMD_CPPC_LOWEST_PERF_MASK, cap1); WRITE_ONCE(cpudata->perf, perf); - WRITE_ONCE(cpudata->prefcore_ranking, AMD_CPPC_HIGHEST_PERF(cap1)); + WRITE_ONCE(cpudata->prefcore_ranking, FIELD_GET(AMD_CPPC_HIGHEST_PERF_MASK, cap1)); + return 0; }