| Message ID | 20250312-batt_ops-v1-1-88e0bb3129fd@google.com (mailing list archive) |
|---|---|
| State | Handled Elsewhere, archived |
| Headers | show |
| Series | Add support for Battery Status & Battery Caps AMS in TCPM | expand |
On Wed, Mar 12, 2025 at 04:42:01PM -0700, Amit Sunil Dhamne wrote: > Add a new "fixed-batteries" DT property to connector class. This > property is populated with nodes associated with battery type power > supplies powering the USB PD connector. This is needed by the Type-C > Port Manager (TCPM) to query psy properties which are used to feed What is "psy" in terms of bindings? > Battery_Status & Battery_Capacity AMS. > > Signed-off-by: Amit Sunil Dhamne <amitsd@google.com> > --- > Documentation/devicetree/bindings/connector/usb-connector.yaml | 8 ++++++++ > Documentation/devicetree/bindings/usb/maxim,max33359.yaml | 1 + > 2 files changed, 9 insertions(+) > > diff --git a/Documentation/devicetree/bindings/connector/usb-connector.yaml b/Documentation/devicetree/bindings/connector/usb-connector.yaml > index 11e40d225b9f3a0d0aeea7bf764f1c00a719d615..5e15bc060f5a2cfce842f83de738f1e8bae3ce2d 100644 > --- a/Documentation/devicetree/bindings/connector/usb-connector.yaml > +++ b/Documentation/devicetree/bindings/connector/usb-connector.yaml > @@ -300,6 +300,14 @@ properties: > $ref: /schemas/types.yaml#/definitions/uint8-array > maxItems: 4 > > + fixed-batteries: > + description: Contains references to nodes associated with battery type power > + supplies powering the USB PD device. These batteries are fixed type and What is a "battery type power supply"? If you just link here batteries, then we have type for it - monitored-battery - but I doubt connector has direct connection to the battery. If you mean chargers, the OF graph is already there for this and no need for this patch. > + not hot swappable. > + minItems: 1 > + maxItems: 4 > + $ref: /schemas/types.yaml#/definitions/phandle-array > + > dependencies: > sink-vdos-v1: [ sink-vdos ] > sink-vdos: [ sink-vdos-v1 ] > diff --git a/Documentation/devicetree/bindings/usb/maxim,max33359.yaml b/Documentation/devicetree/bindings/usb/maxim,max33359.yaml > index 3de4dc40b79192b60443421b557bd2fb18683bf7..66c99f0131f074f1c08e31d7481f555647e3b2f8 100644 > --- a/Documentation/devicetree/bindings/usb/maxim,max33359.yaml > +++ b/Documentation/devicetree/bindings/usb/maxim,max33359.yaml > @@ -75,6 +75,7 @@ examples: > PDO_FIXED(9000, 2000, 0)>; > sink-bc12-completion-time-ms = <500>; > pd-revision = /bits/ 8 <0x03 0x01 0x01 0x08>; > + fixed-batteries = <&batt1 &batt2>; Two phandles, so two <>. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/connector/usb-connector.yaml b/Documentation/devicetree/bindings/connector/usb-connector.yaml index 11e40d225b9f3a0d0aeea7bf764f1c00a719d615..5e15bc060f5a2cfce842f83de738f1e8bae3ce2d 100644 --- a/Documentation/devicetree/bindings/connector/usb-connector.yaml +++ b/Documentation/devicetree/bindings/connector/usb-connector.yaml @@ -300,6 +300,14 @@ properties: $ref: /schemas/types.yaml#/definitions/uint8-array maxItems: 4 + fixed-batteries: + description: Contains references to nodes associated with battery type power + supplies powering the USB PD device. These batteries are fixed type and + not hot swappable. + minItems: 1 + maxItems: 4 + $ref: /schemas/types.yaml#/definitions/phandle-array + dependencies: sink-vdos-v1: [ sink-vdos ] sink-vdos: [ sink-vdos-v1 ] diff --git a/Documentation/devicetree/bindings/usb/maxim,max33359.yaml b/Documentation/devicetree/bindings/usb/maxim,max33359.yaml index 3de4dc40b79192b60443421b557bd2fb18683bf7..66c99f0131f074f1c08e31d7481f555647e3b2f8 100644 --- a/Documentation/devicetree/bindings/usb/maxim,max33359.yaml +++ b/Documentation/devicetree/bindings/usb/maxim,max33359.yaml @@ -75,6 +75,7 @@ examples: PDO_FIXED(9000, 2000, 0)>; sink-bc12-completion-time-ms = <500>; pd-revision = /bits/ 8 <0x03 0x01 0x01 0x08>; + fixed-batteries = <&batt1 &batt2>; }; }; };