| Message ID | 20250315081225.92118-7-john.madieu.xa@bp.renesas.com (mailing list archive) |
|---|---|
| State | Superseded, archived |
| Headers | show |
| Series | thermal: renesas: Add support fot RZ/G3E | expand |
On Sat, Mar 15, 2025 at 09:12:16AM +0100, John Madieu wrote:
> Enable the CONFIG_RZG3E_THERMAL flag for the RZ/G3E SoC.
s/RZ/Renesas RZ/ and which *upstream* board uses it? This is not your
platform defconfig, but all platforms and all users defconfig.
Best regards,
Krzysztof
Hi Krzysztof, Thanks for the review! > -----Original Message----- > From: Krzysztof Kozlowski <krzk@kernel.org> > Sent: Monday, March 17, 2025 10:29 AM > To: John Madieu <john.madieu.xa@bp.renesas.com> > Subject: Re: [PATCH v3 6/6] arm64: defconfig: Enable RZ/G3E thermal > > On Sat, Mar 15, 2025 at 09:12:16AM +0100, John Madieu wrote: > > Enable the CONFIG_RZG3E_THERMAL flag for the RZ/G3E SoC. > > s/RZ/Renesas RZ/ and which *upstream* board uses it? This is not your > platform defconfig, but all platforms and all users defconfig. > Noted for the fix. However, most thermal drivers use SOC-specific config options, as we can see in arm64 defconfig: [...] CONFIG_IMX8MM_THERMAL=m CONFIG_K3_THERMAL=m CONFIG_QORIQ_THERMAL=m CONFIG_SUN8I_THERMAL=y CONFIG_ROCKCHIP_THERMAL=m CONFIG_RCAR_THERMAL=y CONFIG_RCAR_GEN3_THERMAL=y CONFIG_RZG2L_THERMAL=y CONFIG_ARMADA_THERMAL=y CONFIG_MTK_THERMAL=m CONFIG_MTK_LVTS_THERMAL=m CONFIG_BCM2711_THERMAL=m CONFIG_BCM2835_THERMAL=m CONFIG_BRCMSTB_THERMAL=m [...] Hence my choice for RZG3E_THERMAL, or did I miss something in your comment? > Best regards, > Krzysztof Regards, John
Hi John, On Mon, 17 Mar 2025 at 12:14, John Madieu <john.madieu.xa@bp.renesas.com> wrote: > > From: Krzysztof Kozlowski <krzk@kernel.org> > > On Sat, Mar 15, 2025 at 09:12:16AM +0100, John Madieu wrote: > > > Enable the CONFIG_RZG3E_THERMAL flag for the RZ/G3E SoC. > > > > s/RZ/Renesas RZ/ and which *upstream* board uses it? This is not your > > platform defconfig, but all platforms and all users defconfig. > > > > Noted for the fix. > > However, most thermal drivers use SOC-specific config options, > as we can see in arm64 defconfig: > > [...] > CONFIG_IMX8MM_THERMAL=m > CONFIG_K3_THERMAL=m > CONFIG_QORIQ_THERMAL=m > CONFIG_SUN8I_THERMAL=y > CONFIG_ROCKCHIP_THERMAL=m > CONFIG_RCAR_THERMAL=y > CONFIG_RCAR_GEN3_THERMAL=y > CONFIG_RZG2L_THERMAL=y > CONFIG_ARMADA_THERMAL=y > CONFIG_MTK_THERMAL=m > CONFIG_MTK_LVTS_THERMAL=m > CONFIG_BCM2711_THERMAL=m > CONFIG_BCM2835_THERMAL=m > CONFIG_BRCMSTB_THERMAL=m > [...] > > Hence my choice for RZG3E_THERMAL, or did I miss something in your comment? I think Krzysztof is complaining about "RZ/G3E SoC" in the patch description, not about the name of the config symbol (which is fixed). In addition, he asks for mentioning the board this will be used on. E.g.: Enable the Renesas RZ/G3E thermal driver, as used on the Renesas RZ/G3E SMARC EVK board. Gr{oetje,eeting}s, Geert
Hi Geert, > -----Original Message----- > From: Geert Uytterhoeven <geert@linux-m68k.org> > Sent: Monday, March 17, 2025 2:07 PM > To: John Madieu <john.madieu.xa@bp.renesas.com> > Subject: Re: [PATCH v3 6/6] arm64: defconfig: Enable RZ/G3E thermal > > Hi John, > > > I think Krzysztof is complaining about "RZ/G3E SoC" in the patch > description, not about the name of the config symbol (which is fixed). > In addition, he asks for mentioning the board this will be used on. > > E.g.: > > Enable the Renesas RZ/G3E thermal driver, as used on the Renesas > RZ/G3E SMARC EVK board. Thanks for clarifying. > > Gr{oetje,eeting}s, Regards, John
On 17/03/2025 12:14, John Madieu wrote: > Hi Krzysztof, > > Thanks for the review! > >> -----Original Message----- >> From: Krzysztof Kozlowski <krzk@kernel.org> >> Sent: Monday, March 17, 2025 10:29 AM >> To: John Madieu <john.madieu.xa@bp.renesas.com> >> Subject: Re: [PATCH v3 6/6] arm64: defconfig: Enable RZ/G3E thermal >> >> On Sat, Mar 15, 2025 at 09:12:16AM +0100, John Madieu wrote: >>> Enable the CONFIG_RZG3E_THERMAL flag for the RZ/G3E SoC. >> >> s/RZ/Renesas RZ/ and which *upstream* board uses it? This is not your >> platform defconfig, but all platforms and all users defconfig. >> > > Noted for the fix. > > However, most thermal drivers use SOC-specific config options, > as we can see in arm64 defconfig: > > [...] > CONFIG_IMX8MM_THERMAL=m > CONFIG_K3_THERMAL=m > CONFIG_QORIQ_THERMAL=m > CONFIG_SUN8I_THERMAL=y > CONFIG_ROCKCHIP_THERMAL=m > CONFIG_RCAR_THERMAL=y > CONFIG_RCAR_GEN3_THERMAL=y > CONFIG_RZG2L_THERMAL=y > CONFIG_ARMADA_THERMAL=y > CONFIG_MTK_THERMAL=m > CONFIG_MTK_LVTS_THERMAL=m > CONFIG_BCM2711_THERMAL=m > CONFIG_BCM2835_THERMAL=m > CONFIG_BRCMSTB_THERMAL=m > [...] > > Hence my choice for RZG3E_THERMAL, or did I miss something in your comment? Your commit msg must explain why do we want it. I gave you idea, if you don't want to use it, sure, come with other. Best regards, Krzysztof
On 17/03/2025 14:06, Geert Uytterhoeven wrote: > Hi John, > > On Mon, 17 Mar 2025 at 12:14, John Madieu <john.madieu.xa@bp.renesas.com> wrote: >>> From: Krzysztof Kozlowski <krzk@kernel.org> >>> On Sat, Mar 15, 2025 at 09:12:16AM +0100, John Madieu wrote: >>>> Enable the CONFIG_RZG3E_THERMAL flag for the RZ/G3E SoC. >>> >>> s/RZ/Renesas RZ/ and which *upstream* board uses it? This is not your >>> platform defconfig, but all platforms and all users defconfig. ... >> >> Hence my choice for RZG3E_THERMAL, or did I miss something in your comment? > > I think Krzysztof is complaining about "RZ/G3E SoC" in the patch > description, not about the name of the config symbol (which is fixed). > In addition, he asks for mentioning the board this will be used on. > > E.g.: > > Enable the Renesas RZ/G3E thermal driver, as used on the Renesas > RZ/G3E SMARC EVK board. Yes. Best regards, Krzysztof
diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig index a1cc3814b09b..91136c0196b5 100644 --- a/arch/arm64/configs/defconfig +++ b/arch/arm64/configs/defconfig @@ -714,6 +714,7 @@ CONFIG_ROCKCHIP_THERMAL=m CONFIG_RCAR_THERMAL=y CONFIG_RCAR_GEN3_THERMAL=y CONFIG_RZG2L_THERMAL=y +CONFIG_RZG3E_THERMAL=y CONFIG_ARMADA_THERMAL=y CONFIG_MTK_THERMAL=m CONFIG_MTK_LVTS_THERMAL=m
Enable the CONFIG_RZG3E_THERMAL flag for the RZ/G3E SoC. Signed-off-by: John Madieu <john.madieu.xa@bp.renesas.com> --- v1 -> v2: no changes v2 -> v3: no changes arch/arm64/configs/defconfig | 1 + 1 file changed, 1 insertion(+)