diff mbox

cpufreq: exynos: allow build for !THERMAL or !CPU_THERMAL cases

Message ID 2275232.48muFcOOQv@amdc1032 (mailing list archive)
State Not Applicable, archived
Headers show

Commit Message

Bartlomiej Zolnierkiewicz Feb. 20, 2015, 4:20 p.m. UTC
Allow driver build for !THERMAL or !CPU_THERMAL cases.

The new dependency rule is the same as the one that CPUFREQ_DT
option has (for cpufreq-dt driver which has the same issue with
using of_cpufreq_cooling_register()).

Cc: Kukjin Kim <kgene@kernel.org>
Cc: Arnd Bergmann <arnd@arndb.de>
Cc: Eduardo Valentin <edubezval@gmail.com>
Cc: Lukasz Majewski <l.majewski@samsung.com>
Fixes: 8b2b4a4e5366 ("cpufreq: exynos: allow modular build")
Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
---
 drivers/cpufreq/Kconfig.arm | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Viresh Kumar Feb. 23, 2015, 4:37 a.m. UTC | #1
On 20 February 2015 at 21:50, Bartlomiej Zolnierkiewicz
<b.zolnierkie@samsung.com> wrote:
> Allow driver build for !THERMAL or !CPU_THERMAL cases.
>
> The new dependency rule is the same as the one that CPUFREQ_DT
> option has (for cpufreq-dt driver which has the same issue with
> using of_cpufreq_cooling_register()).
>
> Cc: Kukjin Kim <kgene@kernel.org>
> Cc: Arnd Bergmann <arnd@arndb.de>
> Cc: Eduardo Valentin <edubezval@gmail.com>
> Cc: Lukasz Majewski <l.majewski@samsung.com>
> Fixes: 8b2b4a4e5366 ("cpufreq: exynos: allow modular build")
> Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
> ---
>  drivers/cpufreq/Kconfig.arm | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/cpufreq/Kconfig.arm b/drivers/cpufreq/Kconfig.arm
> index 1b06fc4..f4df4af3 100644
> --- a/drivers/cpufreq/Kconfig.arm
> +++ b/drivers/cpufreq/Kconfig.arm
> @@ -28,7 +28,8 @@ config ARM_VEXPRESS_SPC_CPUFREQ
>  config ARM_EXYNOS_CPUFREQ
>         tristate "SAMSUNG EXYNOS CPUfreq Driver"
>         depends on CPU_EXYNOS4210 || SOC_EXYNOS4212 || SOC_EXYNOS4412 || SOC_EXYNOS5250
> -       depends on THERMAL
> +       # if CPU_THERMAL is on and THERMAL=m, ARM_EXYNOS_CPUFREQ cannot be =y:
> +       depends on !CPU_THERMAL || THERMAL
>         help
>           This adds the CPUFreq driver for Samsung EXYNOS platforms.
>           Supported SoC versions are:

Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
--
To unsubscribe from this list: send the line "unsubscribe linux-pm" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Bartlomiej Zolnierkiewicz March 23, 2015, 4:43 p.m. UTC | #2
Hi,

On Monday, February 23, 2015 10:07:50 AM Viresh Kumar wrote:
> On 20 February 2015 at 21:50, Bartlomiej Zolnierkiewicz
> <b.zolnierkie@samsung.com> wrote:
> > Allow driver build for !THERMAL or !CPU_THERMAL cases.
> >
> > The new dependency rule is the same as the one that CPUFREQ_DT
> > option has (for cpufreq-dt driver which has the same issue with
> > using of_cpufreq_cooling_register()).
> >
> > Cc: Kukjin Kim <kgene@kernel.org>
> > Cc: Arnd Bergmann <arnd@arndb.de>
> > Cc: Eduardo Valentin <edubezval@gmail.com>
> > Cc: Lukasz Majewski <l.majewski@samsung.com>
> > Fixes: 8b2b4a4e5366 ("cpufreq: exynos: allow modular build")
> > Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
> > ---
> >  drivers/cpufreq/Kconfig.arm | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/cpufreq/Kconfig.arm b/drivers/cpufreq/Kconfig.arm
> > index 1b06fc4..f4df4af3 100644
> > --- a/drivers/cpufreq/Kconfig.arm
> > +++ b/drivers/cpufreq/Kconfig.arm
> > @@ -28,7 +28,8 @@ config ARM_VEXPRESS_SPC_CPUFREQ
> >  config ARM_EXYNOS_CPUFREQ
> >         tristate "SAMSUNG EXYNOS CPUfreq Driver"
> >         depends on CPU_EXYNOS4210 || SOC_EXYNOS4212 || SOC_EXYNOS4412 || SOC_EXYNOS5250
> > -       depends on THERMAL
> > +       # if CPU_THERMAL is on and THERMAL=m, ARM_EXYNOS_CPUFREQ cannot be =y:
> > +       depends on !CPU_THERMAL || THERMAL
> >         help
> >           This adds the CPUFreq driver for Samsung EXYNOS platforms.
> >           Supported SoC versions are:
> 
> Acked-by: Viresh Kumar <viresh.kumar@linaro.org>

Thank you for the ACK.

Would you pick this patch up or should I resend it to Rafael?

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics

--
To unsubscribe from this list: send the line "unsubscribe linux-pm" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Viresh Kumar March 24, 2015, 2:25 a.m. UTC | #3
On 23 March 2015 at 22:13, Bartlomiej Zolnierkiewicz
<b.zolnierkie@samsung.com> wrote:
> Would you pick this patch up or should I resend it to Rafael?

Please resend it to Rafael and cc me and linux-pm list.. Also add my
Ack to it.
--
To unsubscribe from this list: send the line "unsubscribe linux-pm" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
kgene@kernel.org March 24, 2015, 12:53 p.m. UTC | #4
Bartlomiej Zolnierkiewicz wrote:
> 
> Hi,
> 
Hi,

> On Monday, February 23, 2015 10:07:50 AM Viresh Kumar wrote:
> > On 20 February 2015 at 21:50, Bartlomiej Zolnierkiewicz
> > <b.zolnierkie@samsung.com> wrote:
> > > Allow driver build for !THERMAL or !CPU_THERMAL cases.
> > >
> > > The new dependency rule is the same as the one that CPUFREQ_DT
> > > option has (for cpufreq-dt driver which has the same issue with
> > > using of_cpufreq_cooling_register()).
> > >
> > > Cc: Kukjin Kim <kgene@kernel.org>

Looks OK to me,

Acked-by: Kukjin Kim <kgene@kernel.org>

Thanks,
Kukjin

> > > Cc: Arnd Bergmann <arnd@arndb.de>
> > > Cc: Eduardo Valentin <edubezval@gmail.com>
> > > Cc: Lukasz Majewski <l.majewski@samsung.com>
> > > Fixes: 8b2b4a4e5366 ("cpufreq: exynos: allow modular build")
> > > Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
> > > ---
> > >  drivers/cpufreq/Kconfig.arm | 3 ++-
> > >  1 file changed, 2 insertions(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/cpufreq/Kconfig.arm b/drivers/cpufreq/Kconfig.arm
> > > index 1b06fc4..f4df4af3 100644
> > > --- a/drivers/cpufreq/Kconfig.arm
> > > +++ b/drivers/cpufreq/Kconfig.arm
> > > @@ -28,7 +28,8 @@ config ARM_VEXPRESS_SPC_CPUFREQ
> > >  config ARM_EXYNOS_CPUFREQ
> > >         tristate "SAMSUNG EXYNOS CPUfreq Driver"
> > >         depends on CPU_EXYNOS4210 || SOC_EXYNOS4212 || SOC_EXYNOS4412 || SOC_EXYNOS5250
> > > -       depends on THERMAL
> > > +       # if CPU_THERMAL is on and THERMAL=m, ARM_EXYNOS_CPUFREQ cannot be =y:
> > > +       depends on !CPU_THERMAL || THERMAL
> > >         help
> > >           This adds the CPUFreq driver for Samsung EXYNOS platforms.
> > >           Supported SoC versions are:
> >
> > Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
> 
> Thank you for the ACK.
> 
> Would you pick this patch up or should I resend it to Rafael?
> 
> Best regards,
> --
> Bartlomiej Zolnierkiewicz
> Samsung R&D Institute Poland
> Samsung Electronics

--
To unsubscribe from this list: send the line "unsubscribe linux-pm" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Eduardo Valentin March 24, 2015, 2:53 p.m. UTC | #5
On Fri, Feb 20, 2015 at 05:20:22PM +0100, Bartlomiej Zolnierkiewicz wrote:
> Allow driver build for !THERMAL or !CPU_THERMAL cases.
> 
> The new dependency rule is the same as the one that CPUFREQ_DT
> option has (for cpufreq-dt driver which has the same issue with
> using of_cpufreq_cooling_register()).
> 
> Cc: Kukjin Kim <kgene@kernel.org>
> Cc: Arnd Bergmann <arnd@arndb.de>
> Cc: Eduardo Valentin <edubezval@gmail.com>
> Cc: Lukasz Majewski <l.majewski@samsung.com>
> Fixes: 8b2b4a4e5366 ("cpufreq: exynos: allow modular build")
> Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>

Acked-by: Eduardo Valentin <edubezval@gmail.com>

> ---
>  drivers/cpufreq/Kconfig.arm | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/cpufreq/Kconfig.arm b/drivers/cpufreq/Kconfig.arm
> index 1b06fc4..f4df4af3 100644
> --- a/drivers/cpufreq/Kconfig.arm
> +++ b/drivers/cpufreq/Kconfig.arm
> @@ -28,7 +28,8 @@ config ARM_VEXPRESS_SPC_CPUFREQ
>  config ARM_EXYNOS_CPUFREQ
>  	tristate "SAMSUNG EXYNOS CPUfreq Driver"
>  	depends on CPU_EXYNOS4210 || SOC_EXYNOS4212 || SOC_EXYNOS4412 || SOC_EXYNOS5250
> -	depends on THERMAL
> +	# if CPU_THERMAL is on and THERMAL=m, ARM_EXYNOS_CPUFREQ cannot be =y:
> +	depends on !CPU_THERMAL || THERMAL
>  	help
>  	  This adds the CPUFreq driver for Samsung EXYNOS platforms.
>  	  Supported SoC versions are:
> -- 
> 1.8.2.3
> 
>
diff mbox

Patch

diff --git a/drivers/cpufreq/Kconfig.arm b/drivers/cpufreq/Kconfig.arm
index 1b06fc4..f4df4af3 100644
--- a/drivers/cpufreq/Kconfig.arm
+++ b/drivers/cpufreq/Kconfig.arm
@@ -28,7 +28,8 @@  config ARM_VEXPRESS_SPC_CPUFREQ
 config ARM_EXYNOS_CPUFREQ
 	tristate "SAMSUNG EXYNOS CPUfreq Driver"
 	depends on CPU_EXYNOS4210 || SOC_EXYNOS4212 || SOC_EXYNOS4412 || SOC_EXYNOS5250
-	depends on THERMAL
+	# if CPU_THERMAL is on and THERMAL=m, ARM_EXYNOS_CPUFREQ cannot be =y:
+	depends on !CPU_THERMAL || THERMAL
 	help
 	  This adds the CPUFreq driver for Samsung EXYNOS platforms.
 	  Supported SoC versions are: