From patchwork Fri Dec 14 08:56:46 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thomas Renninger X-Patchwork-Id: 10730725 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 9B26414DE for ; Fri, 14 Dec 2018 08:56:49 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 858C92C91F for ; Fri, 14 Dec 2018 08:56:49 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 7657F2D2C9; Fri, 14 Dec 2018 08:56:49 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 0FDCA2C91F for ; Fri, 14 Dec 2018 08:56:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727206AbeLNI4s (ORCPT ); Fri, 14 Dec 2018 03:56:48 -0500 Received: from mx2.suse.de ([195.135.220.15]:41546 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726520AbeLNI4s (ORCPT ); Fri, 14 Dec 2018 03:56:48 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id B2AD5ADAB; Fri, 14 Dec 2018 08:56:46 +0000 (UTC) From: Thomas Renninger To: linux-pm@vger.kernel.org Cc: srinivas.pandruvada@linux.intel.com, rafael.j.wysocki@intel.com, Len Brown Subject: Why is guaranteed frequency exposed via intel_pstate driver and not via cppc_data? Date: Fri, 14 Dec 2018 09:56:46 +0100 Message-ID: <2340775.C3S44OUvaq@house> MIME-Version: 1.0 Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Hi, this is about: Subject: ACPI / CPPC: Add support for guaranteed performance Git-commit: 29523f095397637edca60c627bc3e5c25a02c40f and Subject: cpufreq: intel_pstate: Add base_frequency attribute Git-commit: 86d333a8cc7f66c2314ab1e147834a1cd95ec2de both came in 4.20-rc1 (so this sysfs API has not been released yet!) why has the guaranteed freq retrieved from ACPI CPPC data not been exposed in: /sys/devices/system/cpu/cpu1/acpi_cppc /sys/devices/system/cpu/cpu1/acpi_cppc/reference_perf /sys/devices/system/cpu/cpu1/acpi_cppc/highest_perf /sys/devices/system/cpu/cpu1/acpi_cppc/nominal_perf /sys/devices/system/cpu/cpu1/acpi_cppc/lowest_perf /sys/devices/system/cpu/cpu1/acpi_cppc/lowest_nonlinear_perf /sys/devices/system/cpu/cpu1/acpi_cppc/feedback_ctrs /sys/devices/system/cpu/cpu1/acpi_cppc/wraparound_time like all the other cppc_perf_caps fields? Instead the above mentioned second patch (86d333a8cc7f66c2314ab1): exports it through intel_pstate cpufreq driver sysfs subdirs. This data might be available and useful even if no intel_pstate driver is running. It should have been as straight forward as (untested like this): show_cppc_data(cppc_get_perf_ctrs, cppc_perf_fb_ctrs, wraparound_time); @@ -189,6 +190,7 @@ static struct attribute *cppc_attrs[] = { &nominal_perf.attr, &nominal_freq.attr, &lowest_freq.attr, + &guaranteed_freq.attr, NULL }; diff --git a/drivers/acpi/cppc_acpi.c b/drivers/acpi/cppc_acpi.c index 217a782c3e55..ed52ce259788 100644 --- a/drivers/acpi/cppc_acpi.c +++ b/drivers/acpi/cppc_acpi.c @@ -159,6 +159,7 @@ show_cppc_data(cppc_get_perf_caps, cppc_perf_caps, nominal_perf); show_cppc_data(cppc_get_perf_caps, cppc_perf_caps, lowest_nonlinear_perf); show_cppc_data(cppc_get_perf_caps, cppc_perf_caps, lowest_freq); show_cppc_data(cppc_get_perf_caps, cppc_perf_caps, nominal_freq); +show_cppc_data(cppc_get_perf_caps, cppc_perf_caps, guaranteed_freq); show_cppc_data(cppc_get_perf_ctrs, cppc_perf_fb_ctrs, reference_perf);