From patchwork Mon Mar 13 10:07:35 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Viresh Kumar X-Patchwork-Id: 9620407 X-Patchwork-Delegate: rui.zhang@intel.com Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 2BDD360244 for ; Mon, 13 Mar 2017 10:08:33 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 1FE7928410 for ; Mon, 13 Mar 2017 10:08:33 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 14AEA2845C; Mon, 13 Mar 2017 10:08:33 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_SPAM autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 9608928410 for ; Mon, 13 Mar 2017 10:08:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751941AbdCMKIa (ORCPT ); Mon, 13 Mar 2017 06:08:30 -0400 Received: from mail-pg0-f46.google.com ([74.125.83.46]:36481 "EHLO mail-pg0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751738AbdCMKIU (ORCPT ); Mon, 13 Mar 2017 06:08:20 -0400 Received: by mail-pg0-f46.google.com with SMTP id g2so44682142pge.3 for ; Mon, 13 Mar 2017 03:08:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :in-reply-to:references; bh=OVFmnBfrfcs2sbUrb0h4bZ1Dfni77nwfvsHkVknparY=; b=iUjv9z/V6gq8+Lk3PkJhlUafnIYtI6T8NHW7EFKMrbxSPegX+L7niGUZgZL8S4RpoZ M4LOs95hE6P+DBOydl9UC/1I8frBou2hQea14tpapWXYkJmEk3Ed9a076hNh19gbyn8u Kjx7JpA4CgF2NbLnslqsfS0kdj9ntuz1x+agQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:in-reply-to:references; bh=OVFmnBfrfcs2sbUrb0h4bZ1Dfni77nwfvsHkVknparY=; b=rqgpZC53rBzYIi7O69iQRlbt+G/J4BNllLD9KFX0gadd7a2EGkQPqL2wXJmYU0mn8c OFyVnCAzWRqou/2LVNaRmZe1eMsXhmkMq3+7sBniCaKmvcXb7cXuaGZYIkrcvs5mczhY A5QSpZ9TxNdJZnOziHjWg3skOjeEu3Zm5bsUFvnDYCSq9gr4jeNFyqs41ASk8+pMPCGI csJYJrv2+KboCZ5SrJensRp5Xsw07sE7k35ECUKXhBvsjuVt+BHrWBLyVImDAGqAnJXE fpWhc5kxIv6tnOTxRYFXfoIkfcJBE0a/vjBHdbon4Oh50yjGqlOcgHxFjYo6jSyklseV +jBg== X-Gm-Message-State: AMke39nwu4UGKBcA8gApCKCgFx7HRWOcw+tjLjEU1p2ISqi1xyevp+uUYBU5GnqBnhAq18h0 X-Received: by 10.99.101.199 with SMTP id z190mr34852541pgb.219.1489399698409; Mon, 13 Mar 2017 03:08:18 -0700 (PDT) Received: from localhost ([122.171.239.200]) by smtp.gmail.com with ESMTPSA id z4sm21050058pge.49.2017.03.13.03.08.17 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 13 Mar 2017 03:08:17 -0700 (PDT) From: Viresh Kumar To: Rafael Wysocki , rui.zhang@intel.com, edubezval@gmail.com Cc: linaro-kernel@lists.linaro.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Vincent Guittot , dan.carpenter@oracle.com, Viresh Kumar Subject: [PATCH V3 2/5] thermal: devfreq_cooling: Replace dev_warn with dev_err Date: Mon, 13 Mar 2017 15:37:35 +0530 Message-Id: <3386850b3136e749e78aedaf689b9b0f20a67f3d.1489399567.git.viresh.kumar@linaro.org> X-Mailer: git-send-email 2.7.1.410.g6faf27b In-Reply-To: References: In-Reply-To: References: Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP There isn't much the user can do on seeing this warning, as the hardware is actually okay. dev_err suits much better here. Signed-off-by: Viresh Kumar Acked-by: Zhang Rui --- drivers/thermal/devfreq_cooling.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/thermal/devfreq_cooling.c b/drivers/thermal/devfreq_cooling.c index 4793fc7b06dd..e99d0e026a53 100644 --- a/drivers/thermal/devfreq_cooling.c +++ b/drivers/thermal/devfreq_cooling.c @@ -193,9 +193,9 @@ get_static_power(struct devfreq_cooling_device *dfc, unsigned long freq) dev_pm_opp_put(opp); if (voltage == 0) { - dev_warn_ratelimited(dev, - "Failed to get voltage for frequency %lu: %ld\n", - freq, IS_ERR(opp) ? PTR_ERR(opp) : 0); + dev_err_ratelimited(dev, + "Failed to get voltage for frequency %lu: %ld\n", + freq, IS_ERR(opp) ? PTR_ERR(opp) : 0); return 0; }