From patchwork Thu Dec 7 09:45:19 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Viresh Kumar X-Patchwork-Id: 10097921 X-Patchwork-Delegate: rjw@sisk.pl Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 8DA3460329 for ; Thu, 7 Dec 2017 09:45:36 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 7FD1328D42 for ; Thu, 7 Dec 2017 09:45:36 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 74524292BD; Thu, 7 Dec 2017 09:45:36 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, RCVD_IN_DNSWL_HI autolearn=unavailable version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 4AF54292BB for ; Thu, 7 Dec 2017 09:45:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752132AbdLGJpb (ORCPT ); Thu, 7 Dec 2017 04:45:31 -0500 Received: from mail-pg0-f65.google.com ([74.125.83.65]:35316 "EHLO mail-pg0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750947AbdLGJpa (ORCPT ); Thu, 7 Dec 2017 04:45:30 -0500 Received: by mail-pg0-f65.google.com with SMTP id q20so4108713pgv.2 for ; Thu, 07 Dec 2017 01:45:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=1NE185+YaY1DLyl7P6bHKo/5ylNZzsfb7GLHfUqsfRA=; b=LOzZZQJVVbTLYB4O/bZ4R7c4oZOT/UP1Pmp5QE0NgTQi1hKa5QxGef0BbmdhvlYI9r 9WPvCx10ZPSPduHa7at14/CLWz2+RRw/0CFCKmeBz7di0eCAUIDYTj1Xfnsy79E3pCUo AmPCQXEwwuR7iiks0e0cJ7M6k355GxtYPwmyA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=1NE185+YaY1DLyl7P6bHKo/5ylNZzsfb7GLHfUqsfRA=; b=eo2kbT1Tswa3NGfWgjZV20vJQQ1G4BP8iQhSOZwtf3AU+WiVnXWhxgBtWO3XgXIZ9U kZyXAiks4fM7Cpp055rmoYk35sWMUm4MyWaqpc6VgD8gowGDjQ/npOuKdO83q2/1wo/T qdKqpi7BM/WcvzH6YXwHWgSYMIYi+Qr23GOcECJdwMS0qNiAaoexLYhyP3D6j41F2h96 fUFP1ROxrJZEH0ppv5cuflXB+yol1By6ogNVirDE4iFyee3GJLo14EWqactgUgX8cV7c CEnRJ+78I/glnhBrdOO9NJh2E/jrJuXjRbEzOB33g7a+PEedDvBcaolVQAhiE9dOK/z9 CEHw== X-Gm-Message-State: AJaThX4qjLG0crXM4UtTScguUAl/om6EFy5O+TecN9J8Odx0L721oFXO TqEbq1PT1XNnBs6HGRiTQHjyHQ== X-Google-Smtp-Source: AGs4zMbSNTqvEpKd5WTm2P9AFG3wv/MQCvd8MpHKuMC7qTNeXAT1wsCzYhFrrR4XRZeKPwHs1qN2cQ== X-Received: by 10.99.146.18 with SMTP id o18mr24674733pgd.380.1512639929469; Thu, 07 Dec 2017 01:45:29 -0800 (PST) Received: from localhost ([117.223.196.91]) by smtp.gmail.com with ESMTPSA id p77sm10048678pfd.132.2017.12.07.01.45.27 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 07 Dec 2017 01:45:28 -0800 (PST) From: Viresh Kumar To: Rafael Wysocki , mroos@linux.ee Cc: Viresh Kumar , linux-pm@vger.kernel.org, Vincent Guittot , "4 . 14+" , linux-kernel@vger.kernel.org Subject: [PATCH V2] cpufreq: longhaul: Revert transition_delay_us to 200 ms Date: Thu, 7 Dec 2017 15:15:19 +0530 Message-Id: <4985fe0a825edcd4b5a13f4c42e4d5b8f49d25ff.1512639844.git.viresh.kumar@linaro.org> X-Mailer: git-send-email 2.14.1 In-Reply-To: References: Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The commit e948bc8fbee0 ("cpufreq: Cap the default transition delay value to 10 ms") caused a regression on EPIA-M min-ITX computer where shutdown or reboot hangs occasionally with a print message like: longhaul: Warning: Timeout while waiting for idle PCI bus cpufreq: __target_index: Failed to change cpu frequency: -16 This probably happens because the cpufreq governor tries to change the frequency of the CPU faster than allowed by the hardware. Before the above commit, the default transition delay was set to 200 ms for a transition_latency of 200000 ns. Lets revert back to that transition delay value to fix it. Note that several other transition delay values were tested like 20 ms and 30 ms and none of them have resolved system hang issue completely. Fixes: e948bc8fbee0 ("cpufreq: Cap the default transition delay value to 10 ms") Cc: 4.14+ # 4.14+ Reported-by: Meelis Roos Suggested-by: Rafael J. Wysocki Signed-off-by: Viresh Kumar --- V1->V2: - s/20 ms/200 ms. drivers/cpufreq/longhaul.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/cpufreq/longhaul.c b/drivers/cpufreq/longhaul.c index c46a12df40dd..5faa37c5b091 100644 --- a/drivers/cpufreq/longhaul.c +++ b/drivers/cpufreq/longhaul.c @@ -894,7 +894,7 @@ static int longhaul_cpu_init(struct cpufreq_policy *policy) if ((longhaul_version != TYPE_LONGHAUL_V1) && (scale_voltage != 0)) longhaul_setup_voltagescaling(); - policy->cpuinfo.transition_latency = 200000; /* nsec */ + policy->transition_delay_us = 200000; /* usec */ return cpufreq_table_validate_and_show(policy, longhaul_table); }