From patchwork Mon Feb 18 10:51:18 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Srivatsa S. Bhat" X-Patchwork-Id: 2156791 Return-Path: X-Original-To: patchwork-linux-pm@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork1.kernel.org (Postfix) with ESMTP id 1C91D3FDF1 for ; Mon, 18 Feb 2013 10:53:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751328Ab3BRKxd (ORCPT ); Mon, 18 Feb 2013 05:53:33 -0500 Received: from e23smtp03.au.ibm.com ([202.81.31.145]:39555 "EHLO e23smtp03.au.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751045Ab3BRKxc (ORCPT ); Mon, 18 Feb 2013 05:53:32 -0500 Received: from /spool/local by e23smtp03.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 18 Feb 2013 20:47:33 +1000 Received: from d23dlp02.au.ibm.com (202.81.31.213) by e23smtp03.au.ibm.com (202.81.31.209) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Mon, 18 Feb 2013 20:47:29 +1000 Received: from d23relay04.au.ibm.com (d23relay04.au.ibm.com [9.190.234.120]) by d23dlp02.au.ibm.com (Postfix) with ESMTP id 7B00A2BB0053; Mon, 18 Feb 2013 21:53:24 +1100 (EST) Received: from d23av04.au.ibm.com (d23av04.au.ibm.com [9.190.235.139]) by d23relay04.au.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r1IAf7MV9306418; Mon, 18 Feb 2013 21:41:07 +1100 Received: from d23av04.au.ibm.com (loopback [127.0.0.1]) by d23av04.au.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id r1IArLbs028564; Mon, 18 Feb 2013 21:53:24 +1100 Received: from srivatsabhat.in.ibm.com (srivatsabhat.in.ibm.com [9.124.35.204] (may be forged)) by d23av04.au.ibm.com (8.14.4/8.13.1/NCO v10.0 AVin) with ESMTP id r1IArFsD028507; Mon, 18 Feb 2013 21:53:16 +1100 Message-ID: <512207A6.4000402@linux.vnet.ibm.com> Date: Mon, 18 Feb 2013 16:21:18 +0530 From: "Srivatsa S. Bhat" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:15.0) Gecko/20120828 Thunderbird/15.0 MIME-Version: 1.0 To: Vincent Guittot CC: paulmck@linux.vnet.ibm.com, Russell King - ARM Linux , linux-doc@vger.kernel.org, peterz@infradead.org, fweisbec@gmail.com, linux-kernel@vger.kernel.org, walken@google.com, mingo@kernel.org, linux-arch@vger.kernel.org, xiaoguangrong@linux.vnet.ibm.com, wangyun@linux.vnet.ibm.com, nikunj@linux.vnet.ibm.com, linux-pm@vger.kernel.org, Rusty Russell , rostedt@goodmis.org, rjw@sisk.pl, namhyung@kernel.org, tglx@linutronix.de, linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org, oleg@redhat.com, sbw@mit.edu, tj@kernel.org, akpm@linux-foundation.org, linuxppc-dev@lists.ozlabs.org Subject: Re: [PATCH v5 00/45] CPU hotplug: stop_machine()-free CPU hotplug References: <20130122073210.13822.50434.stgit@srivatsabhat.in.ibm.com> <510FBC01.2030405@linux.vnet.ibm.com> <87haloiwv0.fsf@rustcorp.com.au> <51134596.4080106@linux.vnet.ibm.com> <20130208154113.GV17833@n2100.arm.linux.org.uk> <51152B81.2050501@linux.vnet.ibm.com> <51153F72.1060005@linux.vnet.ibm.com> <5118E2CD.90401@linux.vnet.ibm.com> <20130211190852.GA5695@linux.vnet.ibm.com> <5119BDFD.1000909@linux.vnet.ibm.com> <511E8F3C.2010406@linux.vnet.ibm.com> <512203B3.7090002@linux.vnet.ibm.com> In-Reply-To: <512203B3.7090002@linux.vnet.ibm.com> X-Content-Scanned: Fidelis XPS MAILER x-cbid: 13021810-6102-0000-0000-00000305616A Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org On 02/18/2013 04:04 PM, Srivatsa S. Bhat wrote: > On 02/18/2013 03:54 PM, Vincent Guittot wrote: >> On 15 February 2013 20:40, Srivatsa S. Bhat >> wrote: >>> Hi Vincent, >>> >>> On 02/15/2013 06:58 PM, Vincent Guittot wrote: >>>> Hi Srivatsa, >>>> >>>> I have run some tests with you branch (thanks Paul for the git tree) >>>> and you will find results below. >>>> >>> >>> Thank you very much for testing this patchset! >>> >>>> The tests condition are: >>>> - 5 CPUs system in 2 clusters >>>> - The test plugs/unplugs CPU2 and it increases the system load each 20 >>>> plug/unplug sequence with either more cyclictests threads >>>> - The test is done with all CPUs online and with only CPU0 and CPU2 >>>> >>>> The main conclusion is that there is no differences with and without >>>> your patches with my stress tests. I'm not sure that it was the >>>> expected results but the cpu_down is already quite low : 4-5ms in >>>> average >>>> >>> >>> Atleast my patchset doesn't perform _worse_ than mainline, with respect >>> to cpu_down duration :-) >> >> yes exactly and it has pass more than 400 consecutive plug/unplug on >> an ARM platform >> > > Great! However, did you turn on CPU_IDLE during your tests? > > In my tests, I had turned off cpu idle in the .config, like I had mentioned in > the cover letter. I'm struggling to get it working with CPU_IDLE/INTEL_IDLE > turned on, because it gets into a lockup almost immediately. It appears that > the lock-holder of clockevents_lock never releases it, for some reason.. > See below for the full log. Lockdep has not been useful in debugging this, > unfortunately :-( > Ah, nevermind, the following diff fixes it :-) I had applied this fix on v5 and tested but it still had races where I used to hit the lockups. Now after I fixed all the memory barrier issues that Paul and Oleg pointed out in v5, I applied this fix again and tested it just now - it works beautifully! :-) I'll include this fix and post a v6 soon. Regards, Srivatsa S. Bhat ---------------------------------------------------------------------------> --- To unsubscribe from this list: send the line "unsubscribe linux-pm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/kernel/time/clockevents.c b/kernel/time/clockevents.c index 30b6de0..ca340fd 100644 --- a/kernel/time/clockevents.c +++ b/kernel/time/clockevents.c @@ -17,6 +17,7 @@ #include #include #include +#include #include "tick-internal.h" @@ -431,6 +432,7 @@ void clockevents_notify(unsigned long reason, void *arg) unsigned long flags; int cpu; + get_online_cpus_atomic(); raw_spin_lock_irqsave(&clockevents_lock, flags); clockevents_do_notify(reason, arg); @@ -459,6 +461,7 @@ void clockevents_notify(unsigned long reason, void *arg) break; } raw_spin_unlock_irqrestore(&clockevents_lock, flags); + put_online_cpus_atomic(); } EXPORT_SYMBOL_GPL(clockevents_notify); #endif