From patchwork Mon Jun 17 18:12:04 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Randy Dunlap X-Patchwork-Id: 2737001 X-Patchwork-Delegate: rui.zhang@intel.com Return-Path: X-Original-To: patchwork-linux-pm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 04F15C0AB1 for ; Mon, 17 Jun 2013 18:12:23 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 3884B20588 for ; Mon, 17 Jun 2013 18:12:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 36E082057E for ; Mon, 17 Jun 2013 18:12:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753583Ab3FQSMU (ORCPT ); Mon, 17 Jun 2013 14:12:20 -0400 Received: from merlin.infradead.org ([205.233.59.134]:51908 "EHLO merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751950Ab3FQSMT (ORCPT ); Mon, 17 Jun 2013 14:12:19 -0400 Received: from static-50-53-38-135.bvtn.or.frontiernet.net ([50.53.38.135] helo=dragon.site) by merlin.infradead.org with esmtpsa (Exim 4.80.1 #2 (Red Hat Linux)) id 1Uoduc-0000jq-0F; Mon, 17 Jun 2013 18:12:18 +0000 Message-ID: <51BF5174.805@infradead.org> Date: Mon, 17 Jun 2013 11:12:04 -0700 From: Randy Dunlap User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130510 Thunderbird/17.0.6 MIME-Version: 1.0 To: Srinivas Pandruvada CC: Stephen Rothwell , linux-next@vger.kernel.org, linux-kernel@vger.kernel.org, Zhang Rui , Linux PM list Subject: [PATCH -next v2] thermal: fix x86_pkg_temp_thermal.c build and Kconfig References: <20130617185106.5950ffbf4b96acd9b2b2c834@canb.auug.org.au> <51BF4159.1000004@infradead.org> <51BF46C3.3090900@linux.intel.com> <51BF4DA2.40601@infradead.org> <51BF50E3.9000806@linux.intel.com> In-Reply-To: <51BF50E3.9000806@linux.intel.com> Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org X-Spam-Status: No, score=-8.0 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On 06/17/13 11:09, Srinivas Pandruvada wrote: > Sorry for this issue. I was about to submit a patch for this, > > You should change to > > depends on X86 && X86_MCE && X86_THERMAL_VECTOR --- From: Randy Dunlap Fix build error in x86_pkg_temp_thermal.c. It requires that X86_MCE be enabled, so depend on that symbol. Also, X86_PKG_TEMP_THERMAL is already inside an "if THERMAL" block, so remove that duplicated dependency. ERROR: "platform_thermal_package_rate_control" [drivers/thermal/x86_pkg_temp_thermal.ko] undefined! ERROR: "platform_thermal_package_notify" [drivers/thermal/x86_pkg_temp_thermal.ko] undefined! Signed-off-by: Randy Dunlap --- drivers/thermal/Kconfig | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe linux-pm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html --- linux-next-20130617.orig/drivers/thermal/Kconfig +++ linux-next-20130617/drivers/thermal/Kconfig @@ -171,8 +171,7 @@ config INTEL_POWERCLAMP config X86_PKG_TEMP_THERMAL tristate "X86 package temperature thermal driver" - depends on THERMAL - depends on X86 + depends on X86 && X86_MCE && X86_THERMAL_VECTOR select THERMAL_GOV_USER_SPACE default m help