From patchwork Sun Jun 30 16:33:56 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: "Srivatsa S. Bhat" X-Patchwork-Id: 2804541 Return-Path: X-Original-To: patchwork-linux-pm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 41845BF4A1 for ; Sun, 30 Jun 2013 16:37:27 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 588AA20116 for ; Sun, 30 Jun 2013 16:37:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 624E720114 for ; Sun, 30 Jun 2013 16:37:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752023Ab3F3QhU (ORCPT ); Sun, 30 Jun 2013 12:37:20 -0400 Received: from e28smtp03.in.ibm.com ([122.248.162.3]:46529 "EHLO e28smtp03.in.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751802Ab3F3QhT (ORCPT ); Sun, 30 Jun 2013 12:37:19 -0400 Received: from /spool/local by e28smtp03.in.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Sun, 30 Jun 2013 22:01:06 +0530 Received: from d28dlp02.in.ibm.com (9.184.220.127) by e28smtp03.in.ibm.com (192.168.1.133) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Sun, 30 Jun 2013 22:01:05 +0530 Received: from d28relay01.in.ibm.com (d28relay01.in.ibm.com [9.184.220.58]) by d28dlp02.in.ibm.com (Postfix) with ESMTP id D9F813940053; Sun, 30 Jun 2013 22:07:11 +0530 (IST) Received: from d28av03.in.ibm.com (d28av03.in.ibm.com [9.184.220.65]) by d28relay01.in.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r5UGbYf429753566; Sun, 30 Jun 2013 22:07:35 +0530 Received: from d28av03.in.ibm.com (loopback [127.0.0.1]) by d28av03.in.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id r5UGbCjk016408; Mon, 1 Jul 2013 02:37:12 +1000 Received: from srivatsabhat.in.ibm.com ([9.79.218.233]) by d28av03.in.ibm.com (8.14.4/8.13.1/NCO v10.0 AVin) with ESMTP id r5UGbBUe016397; Mon, 1 Jul 2013 02:37:11 +1000 Message-ID: <51D05DF4.50704@linux.vnet.ibm.com> Date: Sun, 30 Jun 2013 22:03:56 +0530 From: "Srivatsa S. Bhat" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:15.0) Gecko/20120828 Thunderbird/15.0 MIME-Version: 1.0 To: "Rafael J. Wysocki" , =?UTF-8?B?VG9yYWxmIEbDtnJzdGVy?= CC: Viresh Kumar , cpufreq@vger.kernel.org, Linux PM list Subject: Re: 3.10-rcX: cpu governor ondemand doesn't scale well after s2ram References: <51C08370.4050906@gmx.de> <51CF1E53.6060902@gmx.de> <8029836.CFiJCXmRQ0@vostro.rjw.lan> In-Reply-To: <8029836.CFiJCXmRQ0@vostro.rjw.lan> X-TM-AS-MML: No X-Content-Scanned: Fidelis XPS MAILER x-cbid: 13063016-3864-0000-0000-000008DE80EE Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On 06/30/2013 07:52 PM, Rafael J. Wysocki wrote: > On Saturday, June 29, 2013 07:50:11 PM Toralf Förster wrote: >> The latest bisect attempt gave : >> >> commit a66b2e503fc79fff6632d02ef5a0ee47c1d2553d >> Author: Srivatsa S. Bhat >> Date: Wed May 15 21:47:17 2013 +0200 >> >> cpufreq: Preserve sysfs files across suspend/resume >> >> The file permissions of cpufreq per-cpu sysfs files are not preserved >> across suspend/resume because we internally go through the CPU >> Hotplug path which reinitializes the file permissions on CPU online. >> >> But the user is not supposed to know that we are using CPU hotplug >> internally within suspend/resume (IOW, the kernel should not silently >> wreck the user-set file permissions across a suspend cycle). >> Therefore, we need to preserve the file permissions as they are >> across suspend/resume. >> >> The simplest way to achieve that is to just not touch the sysfs files >> at all - ie., just ignore the CPU hotplug notifications in the >> suspend/resume path (_FROZEN) in the cpufreq hotplug callback. >> >> Reported-by: Robert Jarzmik >> Reported-by: Durgadoss R >> Signed-off-by: Srivatsa S. Bhat >> Acked-by: Viresh Kumar >> Signed-off-by: Rafael J. Wysocki >> >> >> >> To get a more reliable bisect result I had to start BOINC before (4 >> childs each with nice -19 started) > > Well, to be honest, I'm not really sure how the above commit can cause the > problem you're seeing to happen ... > > Srivatsa, Viresh, any ideas? > I tried to look up what problem is being reported, but apart from the hint from the subject line, I couldn't find anything more. So, guessing that there is something wrong with cpufreq after an s3 cycle, Toralf, can you please try out the below patch and see if it improves anything? (Don't revert anything, just apply the below diff on a problematic kernel and see if it solves your issue). --- drivers/cpufreq/cpufreq_stats.c | 1 + 1 file changed, 1 insertion(+) -- To unsubscribe from this list: send the line "unsubscribe linux-pm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/cpufreq/cpufreq_stats.c b/drivers/cpufreq/cpufreq_stats.c index fb65dec..591b6fb 100644 --- a/drivers/cpufreq/cpufreq_stats.c +++ b/drivers/cpufreq/cpufreq_stats.c @@ -349,6 +349,7 @@ static int __cpuinit cpufreq_stat_cpu_callback(struct notifier_block *nfb, switch (action) { case CPU_ONLINE: + case CPU_ONLINE_FROZEN: cpufreq_update_policy(cpu); break; case CPU_DOWN_PREPARE: