From patchwork Wed Sep 11 03:28:41 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "lan,Tianyu" X-Patchwork-Id: 2868591 Return-Path: X-Original-To: patchwork-linux-pm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id E45EF9F495 for ; Wed, 11 Sep 2013 03:38:35 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 0708820378 for ; Wed, 11 Sep 2013 03:38:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 306D220367 for ; Wed, 11 Sep 2013 03:38:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751276Ab3IKDiA (ORCPT ); Tue, 10 Sep 2013 23:38:00 -0400 Received: from mga01.intel.com ([192.55.52.88]:60386 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751081Ab3IKDh7 (ORCPT ); Tue, 10 Sep 2013 23:37:59 -0400 Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga101.fm.intel.com with ESMTP; 10 Sep 2013 20:37:59 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.90,881,1371106800"; d="scan'208";a="399698734" Received: from lantianyu-ws.sh.intel.com (HELO [10.239.37.18]) ([10.239.37.18]) by fmsmga002.fm.intel.com with ESMTP; 10 Sep 2013 20:37:57 -0700 Message-ID: <522FE369.3030106@intel.com> Date: Wed, 11 Sep 2013 11:28:41 +0800 From: Lan Tianyu User-Agent: Mozilla/5.0 (X11; Linux i686; rv:14.0) Gecko/20120714 Thunderbird/14.0 MIME-Version: 1.0 To: Viresh Kumar CC: "Rafael J. Wysocki" , "cpufreq@vger.kernel.org" , "linux-pm@vger.kernel.org" , Linux Kernel Mailing List Subject: Re: [PATCH 1/1] Cpufreq: Remove fossil comment of cpufreq_set_policy References: <1378824287-7696-1-git-send-email-tianyu.lan@intel.com> In-Reply-To: Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org X-Spam-Status: No, score=-7.6 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On 2013?09?10? 23:31, Viresh Kumar wrote: > On 10 September 2013 20:14, wrote: >> From: Lan Tianyu >> >> The cpufreq_set_policy() has been removed by commit 632786c. So remove >> related comment. >> --- >> drivers/cpufreq/cpufreq.c | 4 ---- >> 1 file changed, 4 deletions(-) > > I have got another patch that takes care of this while fixing other issues.. > Yet to be posted though.. but I have queued it up for 3.13.. > > https://git.linaro.org/gitweb?p=people/vireshk/linux.git;a=commit;h=85267596078e3160b3b03de39d95c8e4b5bdf554 > Ok. I get it. Please ignore it. I just find another such comment related with cpufreq_set_policy(). Please have a look. From 668e1b6fd94b5c0e56a651b4c60cbbc7a6868b46 Mon Sep 17 00:00:00 2001 From: Lan Tianyu Date: Wed, 11 Sep 2013 11:31:15 +0800 Subject: [PATCH] Cpufreq/governor: Remove fossil comment cpufreq_set_policy() has been changed to origin __cpufreq_set_policy() and policy->lock has been converted to rewrite lock by commit 5a01f2. So remove it. Signed-off-by: Lan Tianyu Acked-by: Viresh Kumar --- drivers/cpufreq/cpufreq_userspace.c | 11 ----------- 1 file changed, 11 deletions(-) return ret; -- 1.8.4.rc0.1.g8f6a3e5.dirty diff --git a/drivers/cpufreq/cpufreq_userspace.c b/drivers/cpufreq/cpufreq_userspace.c index 0307809..4dbf1db 100644 --- a/drivers/cpufreq/cpufreq_userspace.c +++ b/drivers/cpufreq/cpufreq_userspace.c @@ -38,18 +38,7 @@ static int cpufreq_set(struct cpufreq_policy *policy, unsigned int freq) if (!per_cpu(cpu_is_managed, policy->cpu)) goto err; - /* - * We're safe from concurrent calls to ->target() here - * as we hold the userspace_mutex lock. If we were calling - * cpufreq_driver_target, a deadlock situation might occur: - * A: cpufreq_set (lock userspace_mutex) -> - * cpufreq_driver_target(lock policy->lock) - * B: cpufreq_set_policy(lock policy->lock) -> - * __cpufreq_governor -> - * cpufreq_governor_userspace (lock userspace_mutex) - */ ret = __cpufreq_driver_target(policy, freq, CPUFREQ_RELATION_L); - err: mutex_unlock(&userspace_mutex);