diff mbox

cpufreq: ondemand: Remove redundant return statement

Message ID 5272A118.1090908@semaphore.gr (mailing list archive)
State Accepted, archived
Headers show

Commit Message

Stratos Karafotis Oct. 31, 2013, 6:27 p.m. UTC
After commit dfa5bb622555d9da0df21b50f46ebdeef390041b
"cpufreq: ondemand: Change the calculation of target frequency",
this return statement is no longer needed.

Reported-by: Henrik Nilsson <Karl.Henrik.Nilsson@gmail.com>
Signed-off-by: Stratos Karafotis <stratosk@semaphore.gr>
---
 drivers/cpufreq/cpufreq_ondemand.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Viresh Kumar Oct. 31, 2013, 6:39 p.m. UTC | #1
On 31 October 2013 23:57, Stratos Karafotis <stratosk@semaphore.gr> wrote:
> After commit dfa5bb622555d9da0df21b50f46ebdeef390041b
> "cpufreq: ondemand: Change the calculation of target frequency",
> this return statement is no longer needed.
>
> Reported-by: Henrik Nilsson <Karl.Henrik.Nilsson@gmail.com>
> Signed-off-by: Stratos Karafotis <stratosk@semaphore.gr>
> ---
>  drivers/cpufreq/cpufreq_ondemand.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/cpufreq/cpufreq_ondemand.c b/drivers/cpufreq/cpufreq_ondemand.c
> index 32f26f6..18d4091 100644
> --- a/drivers/cpufreq/cpufreq_ondemand.c
> +++ b/drivers/cpufreq/cpufreq_ondemand.c
> @@ -168,7 +168,6 @@ static void od_check_cpu(int cpu, unsigned int load)
>                         dbs_info->rate_mult =
>                                 od_tuners->sampling_down_factor;
>                 dbs_freq_increase(policy, policy->max);
> -               return;
>         } else {
>                 /* Calculate the next frequency proportional to load */
>                 unsigned int freq_next;

Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
--
To unsubscribe from this list: send the line "unsubscribe linux-pm" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Rafael J. Wysocki Nov. 1, 2013, 12:18 a.m. UTC | #2
On Friday, November 01, 2013 12:09:16 AM Viresh Kumar wrote:
> On 31 October 2013 23:57, Stratos Karafotis <stratosk@semaphore.gr> wrote:
> > After commit dfa5bb622555d9da0df21b50f46ebdeef390041b
> > "cpufreq: ondemand: Change the calculation of target frequency",
> > this return statement is no longer needed.
> >
> > Reported-by: Henrik Nilsson <Karl.Henrik.Nilsson@gmail.com>
> > Signed-off-by: Stratos Karafotis <stratosk@semaphore.gr>
> > ---
> >  drivers/cpufreq/cpufreq_ondemand.c | 1 -
> >  1 file changed, 1 deletion(-)
> >
> > diff --git a/drivers/cpufreq/cpufreq_ondemand.c b/drivers/cpufreq/cpufreq_ondemand.c
> > index 32f26f6..18d4091 100644
> > --- a/drivers/cpufreq/cpufreq_ondemand.c
> > +++ b/drivers/cpufreq/cpufreq_ondemand.c
> > @@ -168,7 +168,6 @@ static void od_check_cpu(int cpu, unsigned int load)
> >                         dbs_info->rate_mult =
> >                                 od_tuners->sampling_down_factor;
> >                 dbs_freq_increase(policy, policy->max);
> > -               return;
> >         } else {
> >                 /* Calculate the next frequency proportional to load */
> >                 unsigned int freq_next;
> 
> Acked-by: Viresh Kumar <viresh.kumar@linaro.org>

Queued up for 3.13, thanks!
Stratos Karafotis Nov. 1, 2013, 6:13 p.m. UTC | #3
On 11/01/2013 02:18 AM, Rafael J. Wysocki wrote:
> On Friday, November 01, 2013 12:09:16 AM Viresh Kumar wrote:
>> On 31 October 2013 23:57, Stratos Karafotis <stratosk@semaphore.gr> wrote:
>>> After commit dfa5bb622555d9da0df21b50f46ebdeef390041b
>>> "cpufreq: ondemand: Change the calculation of target frequency",
>>> this return statement is no longer needed.
>>>
>>> Reported-by: Henrik Nilsson <Karl.Henrik.Nilsson@gmail.com>
>>> Signed-off-by: Stratos Karafotis <stratosk@semaphore.gr>
>>> ---
>>>   drivers/cpufreq/cpufreq_ondemand.c | 1 -
>>>   1 file changed, 1 deletion(-)
>>>
>>> diff --git a/drivers/cpufreq/cpufreq_ondemand.c b/drivers/cpufreq/cpufreq_ondemand.c
>>> index 32f26f6..18d4091 100644
>>> --- a/drivers/cpufreq/cpufreq_ondemand.c
>>> +++ b/drivers/cpufreq/cpufreq_ondemand.c
>>> @@ -168,7 +168,6 @@ static void od_check_cpu(int cpu, unsigned int load)
>>>                          dbs_info->rate_mult =
>>>                                  od_tuners->sampling_down_factor;
>>>                  dbs_freq_increase(policy, policy->max);
>>> -               return;
>>>          } else {
>>>                  /* Calculate the next frequency proportional to load */
>>>                  unsigned int freq_next;
>>
>> Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
>
> Queued up for 3.13, thanks!
>

Thank you both for your immediate response!

Stratos
--
To unsubscribe from this list: send the line "unsubscribe linux-pm" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/cpufreq/cpufreq_ondemand.c b/drivers/cpufreq/cpufreq_ondemand.c
index 32f26f6..18d4091 100644
--- a/drivers/cpufreq/cpufreq_ondemand.c
+++ b/drivers/cpufreq/cpufreq_ondemand.c
@@ -168,7 +168,6 @@  static void od_check_cpu(int cpu, unsigned int load)
 			dbs_info->rate_mult =
 				od_tuners->sampling_down_factor;
 		dbs_freq_increase(policy, policy->max);
-		return;
 	} else {
 		/* Calculate the next frequency proportional to load */
 		unsigned int freq_next;