| Message ID | 537B9B0B.1020404@semaphore.gr (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Headers | show |
On 20 May 2014 23:42, Stratos Karafotis <stratosk@semaphore.gr> wrote: > Although, a value is assigned to member name of struct cpudata, > it is never used. > > We can safely remove it. > > Signed-off-by: Stratos Karafotis <stratosk@semaphore.gr> > --- > drivers/cpufreq/intel_pstate.c | 4 ---- > 1 file changed, 4 deletions(-) Looks fine to me atleast, lets see what Dirk will say :) Acked-by: Viresh Kumar <viresh.kumar@linaro.org> -- To unsubscribe from this list: send the line "unsubscribe linux-pm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 05/20/2014 11:12 AM, Stratos Karafotis wrote: > Although, a value is assigned to member name of struct cpudata, > it is never used. > > We can safely remove it. > > Signed-off-by: Stratos Karafotis <stratosk@semaphore.gr> Acked-by: Dirk Brandewie <dirk.j.brandewie@intel.com> > --- > drivers/cpufreq/intel_pstate.c | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/drivers/cpufreq/intel_pstate.c b/drivers/cpufreq/intel_pstate.c > index 24a534a..a6d5afa 100644 > --- a/drivers/cpufreq/intel_pstate.c > +++ b/drivers/cpufreq/intel_pstate.c > @@ -88,8 +88,6 @@ struct _pid { > struct cpudata { > int cpu; > > - char name[64]; > - > struct timer_list timer; > > struct pstate_data pstate; > @@ -544,8 +542,6 @@ static inline void intel_pstate_pstate_decrease(struct cpudata *cpu, int steps) > > static void intel_pstate_get_cpu_pstates(struct cpudata *cpu) > { > - sprintf(cpu->name, "Intel 2nd generation core"); > - > cpu->pstate.min_pstate = pstate_funcs.get_min(); > cpu->pstate.max_pstate = pstate_funcs.get_max(); > cpu->pstate.turbo_pstate = pstate_funcs.get_turbo(); > -- To unsubscribe from this list: send the line "unsubscribe linux-pm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/cpufreq/intel_pstate.c b/drivers/cpufreq/intel_pstate.c index 24a534a..a6d5afa 100644 --- a/drivers/cpufreq/intel_pstate.c +++ b/drivers/cpufreq/intel_pstate.c @@ -88,8 +88,6 @@ struct _pid { struct cpudata { int cpu; - char name[64]; - struct timer_list timer; struct pstate_data pstate; @@ -544,8 +542,6 @@ static inline void intel_pstate_pstate_decrease(struct cpudata *cpu, int steps) static void intel_pstate_get_cpu_pstates(struct cpudata *cpu) { - sprintf(cpu->name, "Intel 2nd generation core"); - cpu->pstate.min_pstate = pstate_funcs.get_min(); cpu->pstate.max_pstate = pstate_funcs.get_max(); cpu->pstate.turbo_pstate = pstate_funcs.get_turbo();
Although, a value is assigned to member name of struct cpudata, it is never used. We can safely remove it. Signed-off-by: Stratos Karafotis <stratosk@semaphore.gr> --- drivers/cpufreq/intel_pstate.c | 4 ---- 1 file changed, 4 deletions(-)