| Message ID | 53962059.6070306@semaphore.gr (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Headers | show |
On 10 June 2014 02:30, Stratos Karafotis <stratosk@semaphore.gr> wrote: > We check the CPU ID during driver init. There is no need > to do it again per logical CPU initialization. > > So, remove the duplicate check. > > Signed-off-by: Stratos Karafotis <stratosk@semaphore.gr> > --- > drivers/cpufreq/intel_pstate.c | 6 ------ > 1 file changed, 6 deletions(-) > > diff --git a/drivers/cpufreq/intel_pstate.c b/drivers/cpufreq/intel_pstate.c > index aebd457..4e7f492 100644 > --- a/drivers/cpufreq/intel_pstate.c > +++ b/drivers/cpufreq/intel_pstate.c > @@ -691,14 +691,8 @@ MODULE_DEVICE_TABLE(x86cpu, intel_pstate_cpu_ids); > > static int intel_pstate_init_cpu(unsigned int cpunum) > { > - > - const struct x86_cpu_id *id; > struct cpudata *cpu; > > - id = x86_match_cpu(intel_pstate_cpu_ids); > - if (!id) > - return -ENODEV; > - > all_cpu_data[cpunum] = kzalloc(sizeof(struct cpudata), GFP_KERNEL); > if (!all_cpu_data[cpunum]) > return -ENOMEM; Acked-by: Viresh Kumar <viresh.kumar@linaro.org> -- To unsubscribe from this list: send the line "unsubscribe linux-pm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 06/09/2014 10:21 PM, Viresh Kumar wrote: > On 10 June 2014 02:30, Stratos Karafotis <stratosk@semaphore.gr> wrote: >> We check the CPU ID during driver init. There is no need >> to do it again per logical CPU initialization. >> >> So, remove the duplicate check. >> >> Signed-off-by: Stratos Karafotis <stratosk@semaphore.gr> >> --- >> drivers/cpufreq/intel_pstate.c | 6 ------ >> 1 file changed, 6 deletions(-) >> >> diff --git a/drivers/cpufreq/intel_pstate.c b/drivers/cpufreq/intel_pstate.c >> index aebd457..4e7f492 100644 >> --- a/drivers/cpufreq/intel_pstate.c >> +++ b/drivers/cpufreq/intel_pstate.c >> @@ -691,14 +691,8 @@ MODULE_DEVICE_TABLE(x86cpu, intel_pstate_cpu_ids); >> >> static int intel_pstate_init_cpu(unsigned int cpunum) >> { >> - >> - const struct x86_cpu_id *id; >> struct cpudata *cpu; >> >> - id = x86_match_cpu(intel_pstate_cpu_ids); >> - if (!id) >> - return -ENODEV; >> - >> all_cpu_data[cpunum] = kzalloc(sizeof(struct cpudata), GFP_KERNEL); >> if (!all_cpu_data[cpunum]) >> return -ENOMEM; > > Acked-by: Viresh Kumar <viresh.kumar@linaro.org> > Acked-by: Dirk Brandewie <dirk.j.brandewie@intel.com> -- To unsubscribe from this list: send the line "unsubscribe linux-pm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tuesday, June 10, 2014 10:14:29 AM Dirk Brandewie wrote: > On 06/09/2014 10:21 PM, Viresh Kumar wrote: > > On 10 June 2014 02:30, Stratos Karafotis <stratosk@semaphore.gr> wrote: > >> We check the CPU ID during driver init. There is no need > >> to do it again per logical CPU initialization. > >> > >> So, remove the duplicate check. > >> > >> Signed-off-by: Stratos Karafotis <stratosk@semaphore.gr> > >> --- > >> drivers/cpufreq/intel_pstate.c | 6 ------ > >> 1 file changed, 6 deletions(-) > >> > >> diff --git a/drivers/cpufreq/intel_pstate.c b/drivers/cpufreq/intel_pstate.c > >> index aebd457..4e7f492 100644 > >> --- a/drivers/cpufreq/intel_pstate.c > >> +++ b/drivers/cpufreq/intel_pstate.c > >> @@ -691,14 +691,8 @@ MODULE_DEVICE_TABLE(x86cpu, intel_pstate_cpu_ids); > >> > >> static int intel_pstate_init_cpu(unsigned int cpunum) > >> { > >> - > >> - const struct x86_cpu_id *id; > >> struct cpudata *cpu; > >> > >> - id = x86_match_cpu(intel_pstate_cpu_ids); > >> - if (!id) > >> - return -ENODEV; > >> - > >> all_cpu_data[cpunum] = kzalloc(sizeof(struct cpudata), GFP_KERNEL); > >> if (!all_cpu_data[cpunum]) > >> return -ENOMEM; > > > > Acked-by: Viresh Kumar <viresh.kumar@linaro.org> > > > Acked-by: Dirk Brandewie <dirk.j.brandewie@intel.com> [1/7] applied, please wait with the rest until after 3.16-rc1 is released. Thanks!
diff --git a/drivers/cpufreq/intel_pstate.c b/drivers/cpufreq/intel_pstate.c index aebd457..4e7f492 100644 --- a/drivers/cpufreq/intel_pstate.c +++ b/drivers/cpufreq/intel_pstate.c @@ -691,14 +691,8 @@ MODULE_DEVICE_TABLE(x86cpu, intel_pstate_cpu_ids); static int intel_pstate_init_cpu(unsigned int cpunum) { - - const struct x86_cpu_id *id; struct cpudata *cpu; - id = x86_match_cpu(intel_pstate_cpu_ids); - if (!id) - return -ENODEV; - all_cpu_data[cpunum] = kzalloc(sizeof(struct cpudata), GFP_KERNEL); if (!all_cpu_data[cpunum]) return -ENOMEM;
We check the CPU ID during driver init. There is no need to do it again per logical CPU initialization. So, remove the duplicate check. Signed-off-by: Stratos Karafotis <stratosk@semaphore.gr> --- drivers/cpufreq/intel_pstate.c | 6 ------ 1 file changed, 6 deletions(-)