| Message ID | 53962087.8000706@semaphore.gr (mailing list archive) |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
On 10 June 2014 02:30, Stratos Karafotis <stratosk@semaphore.gr> wrote: > Also put them in alphabetical order. > > Signed-off-by: Stratos Karafotis <stratosk@semaphore.gr> > --- > drivers/cpufreq/intel_pstate.c | 17 ++--------------- > 1 file changed, 2 insertions(+), 15 deletions(-) > > diff --git a/drivers/cpufreq/intel_pstate.c b/drivers/cpufreq/intel_pstate.c > index 26a0262..d4f0518 100644 > --- a/drivers/cpufreq/intel_pstate.c > +++ b/drivers/cpufreq/intel_pstate.c > @@ -10,26 +10,13 @@ > * of the License. > */ > > -#include <linux/kernel.h> > -#include <linux/kernel_stat.h> > -#include <linux/module.h> > -#include <linux/ktime.h> > -#include <linux/hrtimer.h> > -#include <linux/tick.h> > -#include <linux/slab.h> > -#include <linux/sched.h> > -#include <linux/list.h> > +#include <linux/acpi.h> > #include <linux/cpu.h> > #include <linux/cpufreq.h> > -#include <linux/sysfs.h> > -#include <linux/types.h> > -#include <linux/fs.h> > #include <linux/debugfs.h> > -#include <linux/acpi.h> > +#include <linux/module.h> > #include <trace/events/power.h> > > -#include <asm/div64.h> > -#include <asm/msr.h> > #include <asm/cpu_device_id.h> As a rule, header files for all the symbols directly used by a file must be included directly by the file and must not depend on indirect inclusions. So even if it compiles, its the wrong thing to do. Though you can obviously remove the headers which aren't used. -- To unsubscribe from this list: send the line "unsubscribe linux-pm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 10/06/2014 08:29 ??, Viresh Kumar wrote: > On 10 June 2014 02:30, Stratos Karafotis <stratosk@semaphore.gr> wrote: >> Also put them in alphabetical order. >> >> Signed-off-by: Stratos Karafotis <stratosk@semaphore.gr> >> --- >> drivers/cpufreq/intel_pstate.c | 17 ++--------------- >> 1 file changed, 2 insertions(+), 15 deletions(-) >> >> diff --git a/drivers/cpufreq/intel_pstate.c b/drivers/cpufreq/intel_pstate.c >> index 26a0262..d4f0518 100644 >> --- a/drivers/cpufreq/intel_pstate.c >> +++ b/drivers/cpufreq/intel_pstate.c >> @@ -10,26 +10,13 @@ >> * of the License. >> */ >> >> -#include <linux/kernel.h> >> -#include <linux/kernel_stat.h> >> -#include <linux/module.h> >> -#include <linux/ktime.h> >> -#include <linux/hrtimer.h> >> -#include <linux/tick.h> >> -#include <linux/slab.h> >> -#include <linux/sched.h> >> -#include <linux/list.h> >> +#include <linux/acpi.h> >> #include <linux/cpu.h> >> #include <linux/cpufreq.h> >> -#include <linux/sysfs.h> >> -#include <linux/types.h> >> -#include <linux/fs.h> >> #include <linux/debugfs.h> >> -#include <linux/acpi.h> >> +#include <linux/module.h> >> #include <trace/events/power.h> >> >> -#include <asm/div64.h> >> -#include <asm/msr.h> >> #include <asm/cpu_device_id.h> > > As a rule, header files for all the symbols directly used by a file must > be included directly by the file and must not depend on indirect inclusions. > > So even if it compiles, its the wrong thing to do. Though you can obviously > remove the headers which aren't used. > I didn't know this. I will drop this patch. I'm sorry for the noise. Thanks for your comments! Stratos -- To unsubscribe from this list: send the line "unsubscribe linux-pm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/cpufreq/intel_pstate.c b/drivers/cpufreq/intel_pstate.c index 26a0262..d4f0518 100644 --- a/drivers/cpufreq/intel_pstate.c +++ b/drivers/cpufreq/intel_pstate.c @@ -10,26 +10,13 @@ * of the License. */ -#include <linux/kernel.h> -#include <linux/kernel_stat.h> -#include <linux/module.h> -#include <linux/ktime.h> -#include <linux/hrtimer.h> -#include <linux/tick.h> -#include <linux/slab.h> -#include <linux/sched.h> -#include <linux/list.h> +#include <linux/acpi.h> #include <linux/cpu.h> #include <linux/cpufreq.h> -#include <linux/sysfs.h> -#include <linux/types.h> -#include <linux/fs.h> #include <linux/debugfs.h> -#include <linux/acpi.h> +#include <linux/module.h> #include <trace/events/power.h> -#include <asm/div64.h> -#include <asm/msr.h> #include <asm/cpu_device_id.h> #define BYT_RATIOS 0x66a
Also put them in alphabetical order. Signed-off-by: Stratos Karafotis <stratosk@semaphore.gr> --- drivers/cpufreq/intel_pstate.c | 17 ++--------------- 1 file changed, 2 insertions(+), 15 deletions(-)