Message ID | 546C7E75.9080301@users.sourceforge.net (mailing list archive) |
---|---|
State | Rejected, archived |
Headers | show |
On Wed, Nov 19, 2014 at 12:26:45PM +0100, SF Markus Elfring wrote: > --- a/drivers/base/power/wakeup.c > +++ b/drivers/base/power/wakeup.c > @@ -267,8 +267,7 @@ int device_wakeup_disable(struct device *dev) > return -EINVAL; > > ws = device_wakeup_detach(dev); > - if (ws) > - wakeup_source_unregister(ws); > + wakeup_source_unregister(ws); In the original code, it's clear that the programmer thought about what happens when the device_wakeup_detach() returns NULL but in the new code that's not clear. I guess the information is still there in the git archive, but why hide the good code by covering it with confusing code? regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe linux-pm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Am 19.11.2014 13:09, schrieb Dan Carpenter: > On Wed, Nov 19, 2014 at 12:26:45PM +0100, SF Markus Elfring wrote: >> --- a/drivers/base/power/wakeup.c >> +++ b/drivers/base/power/wakeup.c >> @@ -267,8 +267,7 @@ int device_wakeup_disable(struct device *dev) >> return -EINVAL; >> >> ws = device_wakeup_detach(dev); >> - if (ws) >> - wakeup_source_unregister(ws); >> + wakeup_source_unregister(ws); > > In the original code, it's clear that the programmer thought about what > happens when the device_wakeup_detach() returns NULL but in the new code > that's not clear. > > I guess the information is still there in the git archive, but why hide > the good code by covering it with confusing code? > hi, just to add an other point of view ... device_wakeup_detach returns dev->power.wakeup what is never NULL in this case. (not visible here but a few line before exactly this is checked) so this code can be compacted to: wakeup_source_unregister(device_wakeup_detach(dev)); --readability let the maintainer decide this byte-saving vs readability re, wh -- To unsubscribe from this list: send the line "unsubscribe linux-pm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Wed, Nov 19, 2014 at 01:54:49PM +0100, walter harms wrote: > device_wakeup_detach returns dev->power.wakeup what is never NULL in this case. > (not visible here but a few line before exactly this is checked) Huh? I don't see a NULL check. I think you may be confusing "dev->power.can_wakeup" with "dev->power.wakeup"? regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe linux-pm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Am 19.11.2014 14:05, schrieb Dan Carpenter: > On Wed, Nov 19, 2014 at 01:54:49PM +0100, walter harms wrote: >> device_wakeup_detach returns dev->power.wakeup what is never NULL in this case. >> (not visible here but a few line before exactly this is checked) > > Huh? I don't see a NULL check. > > I think you may be confusing "dev->power.can_wakeup" with > "dev->power.wakeup"? > > mea culpa, you are right dev->power.can_wakeup != dev->power.wakeup therefore device_wakeup_detach(dev) CAN return NULL re, wh -- To unsubscribe from this list: send the line "unsubscribe linux-pm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/base/power/wakeup.c b/drivers/base/power/wakeup.c index eb1bd2e..87dfc1d 100644 --- a/drivers/base/power/wakeup.c +++ b/drivers/base/power/wakeup.c @@ -267,8 +267,7 @@ int device_wakeup_disable(struct device *dev) return -EINVAL; ws = device_wakeup_detach(dev); - if (ws) - wakeup_source_unregister(ws); + wakeup_source_unregister(ws); return 0; }