From patchwork Tue Jan 27 07:15:34 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Srinivas Kandagatla X-Patchwork-Id: 5715141 X-Patchwork-Delegate: eduardo.valentin@ti.com Return-Path: X-Original-To: patchwork-linux-pm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 75B6E9F358 for ; Tue, 27 Jan 2015 07:15:43 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 66161201F2 for ; Tue, 27 Jan 2015 07:15:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 25CCA201FE for ; Tue, 27 Jan 2015 07:15:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753795AbbA0HPi (ORCPT ); Tue, 27 Jan 2015 02:15:38 -0500 Received: from mail-we0-f172.google.com ([74.125.82.172]:64456 "EHLO mail-we0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752270AbbA0HPh (ORCPT ); Tue, 27 Jan 2015 02:15:37 -0500 Received: by mail-we0-f172.google.com with SMTP id q59so13153996wes.3 for ; Mon, 26 Jan 2015 23:15:36 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:date:from:user-agent:mime-version:to :cc:subject:references:in-reply-to:content-type :content-transfer-encoding; bh=RXKaLS3HlwOuaVyNVWSuLr9hULZ4OWKWL2k1D9lgZJM=; b=mU0umbYAdVNsBy5xIDFjqdBD/kdSdrtx9fy8zELMzvD4gn7mjUlpko3SqsmFKr1Giy ntB9vVZWr9iZxTRxHM7hCCJJcLuQEQClndewDslrnyC4I5tJcijs3UUQrTfewqtkzGNK PbWobJ9lhxtiMOfYgxWjPtxf9lcyvNrl3lJYJPeSi280i/kUNCeoimQikLX8KA3GSGdj IyRzuoXDRj5XJDdxwH7MSKAYJC2lu8Cr5Wfx90wC58AHc2gzwEAgPYuAqnWclQxR+6rE jK/fp/T6BlnbYmvTKUX8jpd7ZmVJgR4FInXjDyaaelA032qdIZs/bVLSvw6DcZ/xvI78 nq5Q== X-Gm-Message-State: ALoCoQlGkDHmQFt7eqC4RS5ibZyrX1CWadc8oyce6iMtygGcbtdiQpeeKq6S/8afRVy6mf9MT6IC X-Received: by 10.194.201.103 with SMTP id jz7mr53583273wjc.14.1422342936348; Mon, 26 Jan 2015 23:15:36 -0800 (PST) Received: from [192.168.1.11] (host-2-98-216-248.as13285.net. [2.98.216.248]) by mx.google.com with ESMTPSA id b1sm923199wiz.6.2015.01.26.23.15.34 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 26 Jan 2015 23:15:35 -0800 (PST) Message-ID: <54C73B16.2030506@linaro.org> Date: Tue, 27 Jan 2015 07:15:34 +0000 From: Srinivas Kandagatla User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Narendran Rajan , Zhang Rui , Eduardo Valentin CC: Linux ARM MSM , Linux PM Subject: Re: [PATCH] dt-bindings: document qcom tsens thermal References: <1422331687-19535-1-git-send-email-nrajan@codeaurora.org> In-Reply-To: <1422331687-19535-1-git-send-email-nrajan@codeaurora.org> Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Hi Narendran, What a coincidence.. I was just in the middle of forward porting the same driver from 3.4 kernel :-) You look fast... :-) On 27/01/15 04:08, Narendran Rajan wrote: > Add binding documentation for the QCOM tsens device tree node > --- > .../devicetree/bindings/thermal/qcom-thermal.txt | 58 ++++++++++++++++++++++ > 1 file changed, 58 insertions(+) > create mode 100644 Documentation/devicetree/bindings/thermal/qcom-thermal.txt > > diff --git a/Documentation/devicetree/bindings/thermal/qcom-thermal.txt b/Documentation/devicetree/bindings/thermal/qcom-thermal.txt > new file mode 100644 > index 0000000..d2e99d6 > --- /dev/null > +++ b/Documentation/devicetree/bindings/thermal/qcom-thermal.txt > @@ -0,0 +1,58 @@ > +* QCOM SoC Temperature Sensor (TSENS) > + > +Required properties: > +- compatible : "qcom,ipq806x-tsens" I think this should be something like qcom,msm8960-tsens as that is the first part where this tsens appeared. > +- interrupts : The interrupt number to the cpu. The interrupt specifier format > + depends on the interrupt controller. > +- qcom,imem : Must contain phandle to imem syscon node Doing this way would work but not great, We should try to do this in an abstracted way so that all the drivers who are in need of qfprom would not add the same code all the time. I did send some WIP patches on msm mailing list. > +- qcom,tsens-base : Must contain phandle to clock controller node This is not correct, you dont need this property. AFAIK for APQ8064 Tsens should be a child of gcc as some of the registers are in already mapped by gcc. You should probably use this patch + do a base = dev_get_regmap(dev->parent, NULL); ------------------>cut<----------------------------- From 87b71df272048fb3aaa89b77524e4b6426e5ddc5 Mon Sep 17 00:00:00 2001 From: Srinivas Kandagatla Date: Thu, 22 Jan 2015 14:03:53 +0000 Subject: [PATCH] clk: qcom: gcc-msm8960: add child devices support. This patch adds support to add child devices to gcc as some of the registers mapped by gcc are used by things like thermal sensors. Signed-off-by: Srinivas Kandagatla --- drivers/clk/qcom/gcc-msm8960.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) static int gcc_msm8960_remove(struct platform_device *pdev) diff --git a/drivers/clk/qcom/gcc-msm8960.c b/drivers/clk/qcom/gcc-msm8960.c index 0b61e8a..8307db3 100644 --- a/drivers/clk/qcom/gcc-msm8960.c +++ b/drivers/clk/qcom/gcc-msm8960.c @@ -15,6 +15,7 @@ #include #include #include +#include #include #include #include @@ -3666,7 +3667,8 @@ static int gcc_msm8960_probe(struct platform_device *pdev) hfpll_l2.d = &hfpll_l2_8064_data; } - return qcom_cc_probe(pdev, match->data); + qcom_cc_probe(pdev, match->data); + return of_platform_populate(pdev->dev.of_node, NULL, NULL, &pdev->dev); }