| Message ID | 54E9C271.1080902@laposte.net (mailing list archive) |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
2015-02-22 12:50 GMT+01:00 Nicolas JOURDEN <nicolas.jourden@laposte.net>: > Hello, > > Looks like my mailer changed the format/indent for the patch. > This patch fix the TWL4030 charger module for the RTC battery. > Could you put a proper title for this patch describing in few words what is fixed? Additionally could you describe the exact fix details in commit message. For example these details could be useful: 1. What is the problem, 2. When the problem appears (or how the problem can be reproduced). 3. What is the "fix". I am asking for these details to better understand the error you found and the fix for it. Best regards, Krzysztof > > Signed-off-by: Nicolas JOURDEN <nicolas.jourden@laposte.net> > --- > diff --git a/drivers/power/twl4030_charger.c b/drivers/power/twl4030_charger.c > index 2598c58..89184ae 100644 > --- a/drivers/power/twl4030_charger.c > +++ b/drivers/power/twl4030_charger.c > @@ -719,10 +719,11 @@ static struct platform_driver twl4030_bci_driver = { > .owner = THIS_MODULE, > .of_match_table = of_match_ptr(twl_bci_of_match), > }, > + .probe = twl4030_bci_probe, > .remove = __exit_p(twl4030_bci_remove), > }; > > -module_platform_driver_probe(twl4030_bci_driver, twl4030_bci_probe); > +module_platform_driver(twl4030_bci_driver); > > MODULE_AUTHOR("Gražvydas Ignotas"); > MODULE_DESCRIPTION("TWL4030 Battery Charger Interface driver"); -- To unsubscribe from this list: send the line "unsubscribe linux-pm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/power/twl4030_charger.c b/drivers/power/twl4030_charger.c index 2598c58..89184ae 100644 --- a/drivers/power/twl4030_charger.c +++ b/drivers/power/twl4030_charger.c @@ -719,10 +719,11 @@ static struct platform_driver twl4030_bci_driver = { .owner = THIS_MODULE, .of_match_table = of_match_ptr(twl_bci_of_match), }, + .probe = twl4030_bci_probe, .remove = __exit_p(twl4030_bci_remove), }; -module_platform_driver_probe(twl4030_bci_driver, twl4030_bci_probe); +module_platform_driver(twl4030_bci_driver); MODULE_AUTHOR("Gražvydas Ignotas"); MODULE_DESCRIPTION("TWL4030 Battery Charger Interface driver");
Hello, Looks like my mailer changed the format/indent for the patch. This patch fix the TWL4030 charger module for the RTC battery. Signed-off-by: Nicolas JOURDEN <nicolas.jourden@laposte.net> --- -- To unsubscribe from this list: send the line "unsubscribe linux-pm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html