| Message ID | 558FCAC1.1090605@users.sourceforge.net (mailing list archive) |
|---|---|
| State | Rejected, archived |
| Delegated to: | Rafael Wysocki |
| Headers | show |
On Sun 2015-06-28 12:21:53, SF Markus Elfring wrote: > From: Markus Elfring <elfring@users.sourceforge.net> > Date: Sun, 28 Jun 2015 12:14:43 +0200 > > The functions dev_pm_disarm_wake_irq() and wakeup_source_unregister() test > whether their argument is NULL and then return immediately. > Thus the test around the calls is not needed. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> ACK. > --- > drivers/base/power/wakeup.c | 10 +++------- > 1 file changed, 3 insertions(+), 7 deletions(-) > > diff --git a/drivers/base/power/wakeup.c b/drivers/base/power/wakeup.c > index 40f7160..3741bc2 100644 > --- a/drivers/base/power/wakeup.c > +++ b/drivers/base/power/wakeup.c > @@ -341,8 +341,7 @@ void device_wakeup_arm_wake_irqs(void) > > rcu_read_lock(); > list_for_each_entry_rcu(ws, &wakeup_sources, entry) { > - if (ws->wakeirq) > - dev_pm_arm_wake_irq(ws->wakeirq); > + dev_pm_arm_wake_irq(ws->wakeirq); > } > rcu_read_unlock(); > } > @@ -358,8 +357,7 @@ void device_wakeup_disarm_wake_irqs(void) > > rcu_read_lock(); > list_for_each_entry_rcu(ws, &wakeup_sources, entry) { > - if (ws->wakeirq) > - dev_pm_disarm_wake_irq(ws->wakeirq); > + dev_pm_disarm_wake_irq(ws->wakeirq); > } > rcu_read_unlock(); > } > @@ -396,9 +394,7 @@ int device_wakeup_disable(struct device *dev) > return -EINVAL; > > ws = device_wakeup_detach(dev); > - if (ws) > - wakeup_source_unregister(ws); > - > + wakeup_source_unregister(ws); > return 0; > } > EXPORT_SYMBOL_GPL(device_wakeup_disable); > -- > 2.4.4
Am 28.06.2015 um 12:21 schrieb SF Markus Elfring: > From: Markus Elfring <elfring@users.sourceforge.net> > Date: Sun, 28 Jun 2015 12:14:43 +0200 > > The functions dev_pm_disarm_wake_irq() and wakeup_source_unregister() test > whether their argument is NULL and then return immediately. > Thus the test around the calls is not needed. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> > --- > drivers/base/power/wakeup.c | 10 +++------- > 1 file changed, 3 insertions(+), 7 deletions(-) > > diff --git a/drivers/base/power/wakeup.c b/drivers/base/power/wakeup.c > index 40f7160..3741bc2 100644 > --- a/drivers/base/power/wakeup.c > +++ b/drivers/base/power/wakeup.c > @@ -341,8 +341,7 @@ void device_wakeup_arm_wake_irqs(void) > > rcu_read_lock(); > list_for_each_entry_rcu(ws, &wakeup_sources, entry) { > - if (ws->wakeirq) > - dev_pm_arm_wake_irq(ws->wakeirq); > + dev_pm_arm_wake_irq(ws->wakeirq); > } > rcu_read_unlock(); > } > @@ -358,8 +357,7 @@ void device_wakeup_disarm_wake_irqs(void) > > rcu_read_lock(); > list_for_each_entry_rcu(ws, &wakeup_sources, entry) { > - if (ws->wakeirq) > - dev_pm_disarm_wake_irq(ws->wakeirq); > + dev_pm_disarm_wake_irq(ws->wakeirq); > } > rcu_read_unlock(); > } > @@ -396,9 +394,7 @@ int device_wakeup_disable(struct device *dev) > return -EINVAL; > > ws = device_wakeup_detach(dev); > - if (ws) > - wakeup_source_unregister(ws); > - > + wakeup_source_unregister(ws); > return 0; > } > EXPORT_SYMBOL_GPL(device_wakeup_disable); > How do you think about to integrate this update suggestion into another source code repository? Regards, Markus -- To unsubscribe from this list: send the line "unsubscribe linux-pm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Friday, July 22, 2016 10:35:27 PM SF Markus Elfring wrote: > Am 28.06.2015 um 12:21 schrieb SF Markus Elfring: > > From: Markus Elfring <elfring@users.sourceforge.net> > > Date: Sun, 28 Jun 2015 12:14:43 +0200 > > > > The functions dev_pm_disarm_wake_irq() and wakeup_source_unregister() test > > whether their argument is NULL and then return immediately. > > Thus the test around the calls is not needed. > > > > This issue was detected by using the Coccinelle software. > > > > Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> > > --- > > drivers/base/power/wakeup.c | 10 +++------- > > 1 file changed, 3 insertions(+), 7 deletions(-) > > > > diff --git a/drivers/base/power/wakeup.c b/drivers/base/power/wakeup.c > > index 40f7160..3741bc2 100644 > > --- a/drivers/base/power/wakeup.c > > +++ b/drivers/base/power/wakeup.c > > @@ -341,8 +341,7 @@ void device_wakeup_arm_wake_irqs(void) > > > > rcu_read_lock(); > > list_for_each_entry_rcu(ws, &wakeup_sources, entry) { > > - if (ws->wakeirq) > > - dev_pm_arm_wake_irq(ws->wakeirq); > > + dev_pm_arm_wake_irq(ws->wakeirq); > > } > > rcu_read_unlock(); > > } > > @@ -358,8 +357,7 @@ void device_wakeup_disarm_wake_irqs(void) > > > > rcu_read_lock(); > > list_for_each_entry_rcu(ws, &wakeup_sources, entry) { > > - if (ws->wakeirq) > > - dev_pm_disarm_wake_irq(ws->wakeirq); > > + dev_pm_disarm_wake_irq(ws->wakeirq); > > } > > rcu_read_unlock(); > > } > > @@ -396,9 +394,7 @@ int device_wakeup_disable(struct device *dev) > > return -EINVAL; > > > > ws = device_wakeup_detach(dev); > > - if (ws) > > - wakeup_source_unregister(ws); > > - > > + wakeup_source_unregister(ws); > > return 0; > > } > > EXPORT_SYMBOL_GPL(device_wakeup_disable); > > > > How do you think about to integrate this update suggestion > into another source code repository? I'm not really sure what you mean. Thanks, Rafael -- To unsubscribe from this list: send the line "unsubscribe linux-pm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
>> How do you think about to integrate this update suggestion >> into another source code repository? > > I'm not really sure what you mean. Do you find the suggested source code change acceptable? http://article.gmane.org/gmane.linux.power-management.general/61766 https://lkml.org/lkml/2015/6/28/21 Who would dare to commit it? Regards, Markus -- To unsubscribe from this list: send the line "unsubscribe linux-pm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Saturday, July 23, 2016 07:32:22 AM SF Markus Elfring wrote: > >> How do you think about to integrate this update suggestion > >> into another source code repository? > > > > I'm not really sure what you mean. > > Do you find the suggested source code change acceptable? > > http://article.gmane.org/gmane.linux.power-management.general/61766 > https://lkml.org/lkml/2015/6/28/21 Yes, it is acceptable, but you also should remove some braces that aren't necessary any more. Thanks, Rafael -- To unsubscribe from this list: send the line "unsubscribe linux-pm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/base/power/wakeup.c b/drivers/base/power/wakeup.c index 40f7160..3741bc2 100644 --- a/drivers/base/power/wakeup.c +++ b/drivers/base/power/wakeup.c @@ -341,8 +341,7 @@ void device_wakeup_arm_wake_irqs(void) rcu_read_lock(); list_for_each_entry_rcu(ws, &wakeup_sources, entry) { - if (ws->wakeirq) - dev_pm_arm_wake_irq(ws->wakeirq); + dev_pm_arm_wake_irq(ws->wakeirq); } rcu_read_unlock(); } @@ -358,8 +357,7 @@ void device_wakeup_disarm_wake_irqs(void) rcu_read_lock(); list_for_each_entry_rcu(ws, &wakeup_sources, entry) { - if (ws->wakeirq) - dev_pm_disarm_wake_irq(ws->wakeirq); + dev_pm_disarm_wake_irq(ws->wakeirq); } rcu_read_unlock(); } @@ -396,9 +394,7 @@ int device_wakeup_disable(struct device *dev) return -EINVAL; ws = device_wakeup_detach(dev); - if (ws) - wakeup_source_unregister(ws); - + wakeup_source_unregister(ws); return 0; } EXPORT_SYMBOL_GPL(device_wakeup_disable);