diff mbox

[2/2] blackfin-cpufreq: Mark cpu_set_cclk() as static

Message ID 56786FF6.4060900@users.sourceforge.net (mailing list archive)
State Accepted, archived
Delegated to: Rafael Wysocki
Headers show

Commit Message

SF Markus Elfring Dec. 21, 2015, 9:32 p.m. UTC 
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Mon, 21 Dec 2015 22:12:26 +0100

The cpu_set_cclk() function was only used in a single source file so far.
Indicate this setting also by the corresponding linkage specifier.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
---
 drivers/cpufreq/blackfin-cpufreq.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Viresh Kumar Dec. 22, 2015, 5:35 a.m. UTC | #1 
On 21-12-15, 22:32, SF Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Mon, 21 Dec 2015 22:12:26 +0100
> 
> The cpu_set_cclk() function was only used in a single source file so far.
> Indicate this setting also by the corresponding linkage specifier.
> 
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
> Acked-by: Viresh Kumar <viresh.kumar@linaro.org>

Well, I never Acked this patch as such and you shouldn't have
mentioned it by yourself. But it looks fine otherwise and so

Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
SF Markus Elfring Dec. 22, 2015, 8:29 a.m. UTC | #2 
> Well, I never Acked this patch as such and you shouldn't have
> mentioned it by yourself.

Did I interpret your positive feedback too early in the way
that I can add this tag myself already?


> But it looks fine otherwise and so
> Acked-by: Viresh Kumar <viresh.kumar@linaro.org>

Thanks for another acknowledgement.

Regards,
Markus
--
To unsubscribe from this list: send the line "unsubscribe linux-pm" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Viresh Kumar Dec. 22, 2015, 8:31 a.m. UTC | #3 
On 22-12-15, 09:29, SF Markus Elfring wrote:
> > Well, I never Acked this patch as such and you shouldn't have
> > mentioned it by yourself.
> 
> Did I interpret your positive feedback too early in the way
> that I can add this tag myself already?

You aren't supposed to add a Tag on someone else's behalf, even if
they said that the change is okay. Others have to send this
separately.
Rafael J. Wysocki Jan. 3, 2016, 1:02 a.m. UTC | #4 
On Tuesday, December 22, 2015 11:05:43 AM Viresh Kumar wrote:
> On 21-12-15, 22:32, SF Markus Elfring wrote:
> > From: Markus Elfring <elfring@users.sourceforge.net>
> > Date: Mon, 21 Dec 2015 22:12:26 +0100
> > 
> > The cpu_set_cclk() function was only used in a single source file so far.
> > Indicate this setting also by the corresponding linkage specifier.
> > 
> > Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
> > Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
> 
> Well, I never Acked this patch as such and you shouldn't have
> mentioned it by yourself. But it looks fine otherwise and so
> 
> Acked-by: Viresh Kumar <viresh.kumar@linaro.org>

Series applied, thanks!

--
To unsubscribe from this list: send the line "unsubscribe linux-pm" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/cpufreq/blackfin-cpufreq.c b/drivers/cpufreq/blackfin-cpufreq.c
index 2a6f3ac..12e97d8 100644
--- a/drivers/cpufreq/blackfin-cpufreq.c
+++ b/drivers/cpufreq/blackfin-cpufreq.c
@@ -112,7 +112,7 @@  static unsigned int bfin_getfreq_khz(unsigned int cpu)
 }
 
 #ifdef CONFIG_BF60x
-int cpu_set_cclk(int cpu, unsigned long new)
+static int cpu_set_cclk(int cpu, unsigned long new)
 {
 	struct clk *clk;
 	int ret;