From patchwork Wed Jun 15 16:14:14 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mason X-Patchwork-Id: 9178917 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id C330D60776 for ; Wed, 15 Jun 2016 16:14:44 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id B4FBC27D5D for ; Wed, 15 Jun 2016 16:14:44 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id A9C1327E5A; Wed, 15 Jun 2016 16:14:44 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 5A6A427D5D for ; Wed, 15 Jun 2016 16:14:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932570AbcFOQOd (ORCPT ); Wed, 15 Jun 2016 12:14:33 -0400 Received: from smtp2-g21.free.fr ([212.27.42.2]:10669 "EHLO smtp2-g21.free.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932554AbcFOQOa (ORCPT ); Wed, 15 Jun 2016 12:14:30 -0400 Received: from [172.27.0.114] (unknown [83.142.147.193]) (Authenticated sender: slash.tmp) by smtp2-g21.free.fr (Postfix) with ESMTPSA id 443E820039C; Wed, 15 Jun 2016 16:06:20 +0200 (CEST) To: Kevin Hilman , Eduardo Valentin , Javi Merino Cc: linux-pm , "Rafael J. Wysocki" , Sebastian Frias From: Mason Subject: [RFC] Adding PM support to thermal driver Message-ID: <57617ED6.6050305@free.fr> Date: Wed, 15 Jun 2016 18:14:14 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:43.0) Gecko/20100101 Firefox/43.0 SeaMonkey/2.40 MIME-Version: 1.0 Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Hello, I need to support suspend-to-RAM in my platform. This platform powers down on suspend, so the contents of device registers are lost. Can you tell me if this patch looks OK for adding S2R support? (I would then make a formal submission.) Regards. --- To unsubscribe from this list: send the line "unsubscribe linux-pm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/thermal/tango_thermal.c b/drivers/thermal/tango_thermal.c index 70e0d9f406e9..29ef9f2f1b93 100644 --- a/drivers/thermal/tango_thermal.c +++ b/drivers/thermal/tango_thermal.c @@ -62,10 +62,16 @@ static int tango_get_temp(void *arg, int *res) static const struct thermal_zone_of_device_ops ops = { .get_temp = tango_get_temp, }; +static void tango_thermal_init(struct tango_thermal_priv *priv) +{ + writel(0, priv->base + TEMPSI_CFG); + writel(CMD_ON, priv->base + TEMPSI_CMD); +} + static int tango_thermal_probe(struct platform_device *pdev) { struct resource *res; struct tango_thermal_priv *priv; struct thermal_zone_device *tzdev; @@ -77,18 +83,28 @@ static int tango_thermal_probe(struct platform_device *pdev) res = platform_get_resource(pdev, IORESOURCE_MEM, 0); priv->base = devm_ioremap_resource(&pdev->dev, res); if (IS_ERR(priv->base)) return PTR_ERR(priv->base); + platform_set_drvdata(pdev, priv); priv->thresh_idx = IDX_MIN; - writel(0, priv->base + TEMPSI_CFG); - writel(CMD_ON, priv->base + TEMPSI_CMD); + tango_thermal_init(priv); tzdev = devm_thermal_zone_of_sensor_register(&pdev->dev, 0, priv, &ops); return PTR_ERR_OR_ZERO(tzdev); } +static int tango_thermal_resume(struct device *dev) +{ + struct tango_thermal_priv *priv = dev_get_drvdata(dev); + tango_thermal_init(priv); + + return 0; +} + +static SIMPLE_DEV_PM_OPS(tango_thermal_pm_ops, NULL, tango_thermal_resume); + static const struct of_device_id tango_sensor_ids[] = { { .compatible = "sigma,smp8758-thermal", }, { /* sentinel */ } @@ -97,10 +113,11 @@ static const struct of_device_id tango_sensor_ids[] = { static struct platform_driver tango_thermal_driver = { .probe = tango_thermal_probe, .driver = { .name = "tango-thermal", .of_match_table = tango_sensor_ids, + .pm = &tango_thermal_pm_ops, }, }; module_platform_driver(tango_thermal_driver);