Message ID | 58ae61a8e5c09f94140d68f3c081559823fa885f.1424345053.git.viresh.kumar@linaro.org (mailing list archive) |
---|---|
State | Changes Requested, archived |
Headers | show |
On 02/19/2015 03:32 AM, Viresh Kumar wrote: > From: Saravana Kannan <skannan@codeaurora.org> > > In order to prepare for the next few commits, that will stop migrating sysfs > files on cpu hotplug, this patch starts managing sysfs-cpu separately. > > The behavior is still the same as we are still migrating sysfs files on hotplug, > later commits would change that. > > Signed-off-by: Saravana Kannan <skannan@codeaurora.org> > Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org> > --- > drivers/cpufreq/cpufreq.c | 11 +++++++---- > include/linux/cpufreq.h | 4 +++- > 2 files changed, 10 insertions(+), 5 deletions(-) > > diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c > index 155e6ff2fa85..fff08145d9ff 100644 > --- a/drivers/cpufreq/cpufreq.c > +++ b/drivers/cpufreq/cpufreq.c > @@ -981,7 +981,7 @@ static int cpufreq_add_dev_symlink(struct cpufreq_policy *policy) > for_each_cpu(j, policy->cpus) { > struct device *cpu_dev; > > - if (j == policy->cpu) > + if (j == policy->kobj_cpu) > continue; > > pr_debug("Adding link for CPU: %u\n", j); > @@ -1200,6 +1200,7 @@ static int update_policy_cpu(struct cpufreq_policy *policy, unsigned int cpu, > > down_write(&policy->rwsem); > policy->cpu = cpu; > + policy->kobj_cpu = cpu; > up_write(&policy->rwsem); > > return 0; > @@ -1257,10 +1258,12 @@ static int cpufreq_add_dev(struct device *dev, struct subsys_interface *sif) > * the creation of a brand new one. So we need to perform this update > * by invoking update_policy_cpu(). > */ > - if (recover_policy && cpu != policy->cpu) > + if (recover_policy && cpu != policy->cpu) { > WARN_ON(update_policy_cpu(policy, cpu, dev)); > - else > + } else { > policy->cpu = cpu; > + policy->kobj_cpu = cpu; > + } > > cpumask_copy(policy->cpus, cpumask_of(cpu)); > > @@ -1439,7 +1442,7 @@ static int __cpufreq_remove_dev_prepare(struct device *dev, > CPUFREQ_NAME_LEN); > up_write(&policy->rwsem); > > - if (cpu != policy->cpu) { > + if (cpu != policy->kobj_cpu) { > sysfs_remove_link(&dev->kobj, "cpufreq"); > } else if (cpus > 1) { > /* Nominate new CPU */ > diff --git a/include/linux/cpufreq.h b/include/linux/cpufreq.h > index 48e37c07eb84..29ad97c34fd5 100644 > --- a/include/linux/cpufreq.h > +++ b/include/linux/cpufreq.h > @@ -65,7 +65,9 @@ struct cpufreq_policy { > > unsigned int shared_type; /* ACPI: ANY or ALL affected CPUs > should set cpufreq */ > - unsigned int cpu; /* cpu nr of CPU managing this policy */ > + unsigned int cpu; /* cpu managing this policy, must be online */ > + unsigned int kobj_cpu; /* cpu managing sysfs files, can be offline */ > + > struct clk *clk; > struct cpufreq_cpuinfo cpuinfo;/* see above */ > > Acked? -Saravana
On 2 April 2015 at 10:10, Saravana Kannan <skannan@codeaurora.org> wrote:
> Acked?
Yeah, you can Ack the final version..
--
To unsubscribe from this list: send the line "unsubscribe linux-pm" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c index 155e6ff2fa85..fff08145d9ff 100644 --- a/drivers/cpufreq/cpufreq.c +++ b/drivers/cpufreq/cpufreq.c @@ -981,7 +981,7 @@ static int cpufreq_add_dev_symlink(struct cpufreq_policy *policy) for_each_cpu(j, policy->cpus) { struct device *cpu_dev; - if (j == policy->cpu) + if (j == policy->kobj_cpu) continue; pr_debug("Adding link for CPU: %u\n", j); @@ -1200,6 +1200,7 @@ static int update_policy_cpu(struct cpufreq_policy *policy, unsigned int cpu, down_write(&policy->rwsem); policy->cpu = cpu; + policy->kobj_cpu = cpu; up_write(&policy->rwsem); return 0; @@ -1257,10 +1258,12 @@ static int cpufreq_add_dev(struct device *dev, struct subsys_interface *sif) * the creation of a brand new one. So we need to perform this update * by invoking update_policy_cpu(). */ - if (recover_policy && cpu != policy->cpu) + if (recover_policy && cpu != policy->cpu) { WARN_ON(update_policy_cpu(policy, cpu, dev)); - else + } else { policy->cpu = cpu; + policy->kobj_cpu = cpu; + } cpumask_copy(policy->cpus, cpumask_of(cpu)); @@ -1439,7 +1442,7 @@ static int __cpufreq_remove_dev_prepare(struct device *dev, CPUFREQ_NAME_LEN); up_write(&policy->rwsem); - if (cpu != policy->cpu) { + if (cpu != policy->kobj_cpu) { sysfs_remove_link(&dev->kobj, "cpufreq"); } else if (cpus > 1) { /* Nominate new CPU */ diff --git a/include/linux/cpufreq.h b/include/linux/cpufreq.h index 48e37c07eb84..29ad97c34fd5 100644 --- a/include/linux/cpufreq.h +++ b/include/linux/cpufreq.h @@ -65,7 +65,9 @@ struct cpufreq_policy { unsigned int shared_type; /* ACPI: ANY or ALL affected CPUs should set cpufreq */ - unsigned int cpu; /* cpu nr of CPU managing this policy */ + unsigned int cpu; /* cpu managing this policy, must be online */ + unsigned int kobj_cpu; /* cpu managing sysfs files, can be offline */ + struct clk *clk; struct cpufreq_cpuinfo cpuinfo;/* see above */