From patchwork Mon Mar 13 10:07:37 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Viresh Kumar X-Patchwork-Id: 9620421 X-Patchwork-Delegate: rui.zhang@intel.com Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id DDB6D60522 for ; Mon, 13 Mar 2017 10:09:22 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id D169A28410 for ; Mon, 13 Mar 2017 10:09:22 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id C2D1228461; Mon, 13 Mar 2017 10:09:22 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, RCVD_IN_DNSWL_HI autolearn=unavailable version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 76ACE28454 for ; Mon, 13 Mar 2017 10:09:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752421AbdCMKJM (ORCPT ); Mon, 13 Mar 2017 06:09:12 -0400 Received: from mail-pf0-f171.google.com ([209.85.192.171]:33311 "EHLO mail-pf0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751989AbdCMKI0 (ORCPT ); Mon, 13 Mar 2017 06:08:26 -0400 Received: by mail-pf0-f171.google.com with SMTP id w189so67580698pfb.0 for ; Mon, 13 Mar 2017 03:08:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :in-reply-to:references; bh=4g65T5MeJKEW1cwwOUI/A/iiZq9bizlL1jVfV5BI6j4=; b=Og8/5FcWft4zbbc+PWGflx6racUjuG6c5qru0dsbng9j7pS4NOtxWwvKStUlp3BAZT KCPwZ7fNb/PeoKSYG6/jicwA4GG3Qzd5jQJv6sclujZ/vlbC5GjD9Xtobu4FyDJ7DfkH yU5pjjlnWJtxiKAfuaFpZVxM1sFaPQ7Ml1Awo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:in-reply-to:references; bh=4g65T5MeJKEW1cwwOUI/A/iiZq9bizlL1jVfV5BI6j4=; b=fygnlVwo9LkdtQ6NKhVrp4HficBzBAAkM2NKJr7WoPRCPCPyFXVmimMuOyGo75c6e0 wMn4FTsIPMQz3rBtze3OBzdB4K0ghN3NAXmHb27Ekc53G+rkZPUktts9ttqUfpyfPoVX 5VnU+bRVtcfN6R38Q0UJc3vV5oy7EdJrEBO61ZwUsktLN3p628JHdpME9Jl53/LmHvNX T1xHUA59uWRFAEqHq8xR0W+FamAL60kNP6fARS3hiB2F0nMWPt6AJv9ebIeck66YiDYx n2NWSYyM+zJPHN6yR9Lsphp9PdpweTcNG7i+ivLh4mVkrfkkkuvd9y+dYcUDQtVFN2sf OcmA== X-Gm-Message-State: AMke39nytcZ+Ggmg4BLy1Uo8K10yvaUCVMAp8yw3ggCas5ZCM//tMOAxTfvmYf+zu/d1ENza X-Received: by 10.84.241.203 with SMTP id t11mr46838376plm.48.1489399704885; Mon, 13 Mar 2017 03:08:24 -0700 (PDT) Received: from localhost ([122.171.239.200]) by smtp.gmail.com with ESMTPSA id o5sm32246694pgj.66.2017.03.13.03.08.23 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 13 Mar 2017 03:08:24 -0700 (PDT) From: Viresh Kumar To: Rafael Wysocki , rui.zhang@intel.com, edubezval@gmail.com, Amit Daniel Kachhap , Viresh Kumar , Javi Merino Cc: linaro-kernel@lists.linaro.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Vincent Guittot , dan.carpenter@oracle.com Subject: [PATCH V3 4/5] thermal: cpu_cooling: Replace dev_warn with dev_err Date: Mon, 13 Mar 2017 15:37:37 +0530 Message-Id: <7b61db5a96f6c829ecf76712613aca249c6c263d.1489399567.git.viresh.kumar@linaro.org> X-Mailer: git-send-email 2.7.1.410.g6faf27b In-Reply-To: References: In-Reply-To: References: Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP There isn't much the user can do on seeing these warnings, as the hardware is actually okay. dev_err suits much better here. Signed-off-by: Viresh Kumar Acked-by: Zhang Rui --- drivers/thermal/cpu_cooling.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/thermal/cpu_cooling.c b/drivers/thermal/cpu_cooling.c index 91048eeca28b..2f9a1c7e7b1f 100644 --- a/drivers/thermal/cpu_cooling.c +++ b/drivers/thermal/cpu_cooling.c @@ -399,9 +399,9 @@ static int get_static_power(struct cpufreq_cooling_device *cpufreq_device, dev_pm_opp_put(opp); if (voltage == 0) { - dev_warn_ratelimited(cpufreq_device->cpu_dev, - "Failed to get voltage for frequency %lu: %ld\n", - freq_hz, IS_ERR(opp) ? PTR_ERR(opp) : 0); + dev_err_ratelimited(cpufreq_device->cpu_dev, + "Failed to get voltage for frequency %lu: %ld\n", + freq_hz, IS_ERR(opp) ? PTR_ERR(opp) : 0); return -EINVAL; } @@ -693,9 +693,9 @@ static int cpufreq_power2state(struct thermal_cooling_device *cdev, *state = cpufreq_cooling_get_level(cpu, target_freq); if (*state == THERMAL_CSTATE_INVALID) { - dev_warn_ratelimited(&cdev->device, - "Failed to convert %dKHz for cpu %d into a cdev state\n", - target_freq, cpu); + dev_err_ratelimited(&cdev->device, + "Failed to convert %dKHz for cpu %d into a cdev state\n", + target_freq, cpu); return -EINVAL; }