| Message ID | 87c6aeb265a0281b3abebd07ba2069d80da21944.1711335714.git.perry.yuan@amd.com (mailing list archive) |
|---|---|
| State | Needs ACK |
| Headers | show |
| Series | AMD Pstate Fixes And Enhancements | expand |
On Mon, Mar 25, 2024 at 11:03:22AM +0800, Yuan, Perry wrote: > From: "Gautham R. Shenoy" <gautham.shenoy@amd.com> > > The min_limit_freq, max_limit_freq, min_freq, max_freq, nominal_freq > and the lowest_nominal_freq members of struct cpudata store the > frequency value in khz to be consistent with the cpufreq > core. Update the comment to document this. > > Reviewed-by: Li Meng <li.meng@amd.com> > Tested-by: Dhananjay Ugwekar <Dhananjay.Ugwekar@amd.com> > Signed-off-by: Gautham R. Shenoy <gautham.shenoy@amd.com> > Signed-off-by: Perry Yuan <perry.yuan@amd.com> > --- Acked-by: Huang Rui <ray.huang@amd.com> > include/linux/amd-pstate.h | 14 +++++++------- > 1 file changed, 7 insertions(+), 7 deletions(-) > > diff --git a/include/linux/amd-pstate.h b/include/linux/amd-pstate.h > index 212f377d615b..ab7e82533718 100644 > --- a/include/linux/amd-pstate.h > +++ b/include/linux/amd-pstate.h > @@ -51,15 +51,15 @@ struct amd_aperf_mperf { > * priority. > * @min_limit_perf: Cached value of the perf corresponding to policy->min > * @max_limit_perf: Cached value of the perf corresponding to policy->max > - * @min_limit_freq: Cached value of policy->min > - * @max_limit_freq: Cached value of policy->max > - * @max_freq: the frequency that mapped to highest_perf > - * @min_freq: the frequency that mapped to lowest_perf > - * @nominal_freq: the frequency that mapped to nominal_perf > - * @lowest_nonlinear_freq: the frequency that mapped to lowest_nonlinear_perf > + * @min_limit_freq: Cached value of policy->min (in khz) > + * @max_limit_freq: Cached value of policy->max (in khz) > + * @max_freq: the frequency (in khz) that mapped to highest_perf > + * @min_freq: the frequency (in khz) that mapped to lowest_perf > + * @nominal_freq: the frequency (in khz) that mapped to nominal_perf > + * @lowest_nonlinear_freq: the frequency (in khz) that mapped to lowest_nonlinear_perf > * @cur: Difference of Aperf/Mperf/tsc count between last and current sample > * @prev: Last Aperf/Mperf/tsc count value read from register > - * @freq: current cpu frequency value > + * @freq: current cpu frequency value (in khz) > * @boost_supported: check whether the Processor or SBIOS supports boost mode > * @hw_prefcore: check whether HW supports preferred core featue. > * Only when hw_prefcore and early prefcore param are true, > -- > 2.34.1 >
diff --git a/include/linux/amd-pstate.h b/include/linux/amd-pstate.h index 212f377d615b..ab7e82533718 100644 --- a/include/linux/amd-pstate.h +++ b/include/linux/amd-pstate.h @@ -51,15 +51,15 @@ struct amd_aperf_mperf { * priority. * @min_limit_perf: Cached value of the perf corresponding to policy->min * @max_limit_perf: Cached value of the perf corresponding to policy->max - * @min_limit_freq: Cached value of policy->min - * @max_limit_freq: Cached value of policy->max - * @max_freq: the frequency that mapped to highest_perf - * @min_freq: the frequency that mapped to lowest_perf - * @nominal_freq: the frequency that mapped to nominal_perf - * @lowest_nonlinear_freq: the frequency that mapped to lowest_nonlinear_perf + * @min_limit_freq: Cached value of policy->min (in khz) + * @max_limit_freq: Cached value of policy->max (in khz) + * @max_freq: the frequency (in khz) that mapped to highest_perf + * @min_freq: the frequency (in khz) that mapped to lowest_perf + * @nominal_freq: the frequency (in khz) that mapped to nominal_perf + * @lowest_nonlinear_freq: the frequency (in khz) that mapped to lowest_nonlinear_perf * @cur: Difference of Aperf/Mperf/tsc count between last and current sample * @prev: Last Aperf/Mperf/tsc count value read from register - * @freq: current cpu frequency value + * @freq: current cpu frequency value (in khz) * @boost_supported: check whether the Processor or SBIOS supports boost mode * @hw_prefcore: check whether HW supports preferred core featue. * Only when hw_prefcore and early prefcore param are true,