diff mbox

[2/3] pm2301-charger: Improve a size determination in pm2xxx_wall_charger_probe()

Message ID 8b954bef-c66e-2ad9-233c-9cb05ee0871f@users.sourceforge.net (mailing list archive)
State Not Applicable, archived
Headers show

Commit Message

SF Markus Elfring Dec. 16, 2017, 8:13 p.m. UTC 
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Sat, 16 Dec 2017 20:33:37 +0100

Replace the specification of a data structure by a pointer dereference
as the parameter for the operator "sizeof" to make the corresponding size
determination a bit safer according to the Linux coding style convention.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
 drivers/power/supply/pm2301_charger.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff mbox

Patch

diff --git a/drivers/power/supply/pm2301_charger.c b/drivers/power/supply/pm2301_charger.c
index 0a0c2da936cf..99a9892f0f68 100644
--- a/drivers/power/supply/pm2301_charger.c
+++ b/drivers/power/supply/pm2301_charger.c
@@ -990,7 +990,7 @@  static int pm2xxx_wall_charger_probe(struct i2c_client *i2c_client,
 		return -EINVAL;
 	}
 
-	pm2 = kzalloc(sizeof(struct pm2xxx_charger), GFP_KERNEL);
+	pm2 = kzalloc(sizeof(*pm2), GFP_KERNEL);
 	if (!pm2)
 		return -ENOMEM;